What are the worst programming habits?

[dan sh]

I am currently working on something that has massive presence of #1, 2 and 4. Other than that I totally hate if someone mixes up naming conventions. I have my favorites but I am OK with any convention. Just stick to single bloody way. Other than that, for some reason, heavily parameterized methods and constructors to bother me. I also totally hate logic and calculations in constructors (unless that is really needed).

My CP workspace: Incredibly trivial and probably useless code samples[^]

[JMK NI]

Not sealing classes by default/crazy overuse of inheritance Just because something needs something else doesn't mean it is a base class of that other thing, I think in a modern programming language you rarely actually need to use inheritance Also, Code that does nothing, but hasn't been taken out of the project, eugh I rarely comment my code unless I am doing something weird, I assume the next developer will be at least as smart as me, if not much much smarter (likely) I might use o as a variable name if I'm maybe inside a for loop inside another for loop (using i for the outer one), everybody should know what for(var i = 0; i < blah; i++) means, anything more descriptive is a waste of keystrokes Everything else I agree with

[PIEBALDconsult]

Eddy Vluggen wrote:

Removing the access modifier "private" from code

There should be no default access modifiers; the developer's intent should be clearly specified. I don't want to have to guess, and you don't want me to keep asking you. Specify it, and decrease the hit to your own productivity caused by your juniors.

You'll never get very far if all you do is follow instructions.

[Gary Wheeler]

Misspelled identifiers. Inconsistent naming for related items. C++ header files that group things by their access method (public:, protected:, private:) rather than putting related items together. Hungarian notation should die in a fire.

Software Zen: delete this;

[dan sh]

Use of var is justifiable? In my useless opinion, var is useless in .Net framework World.

My CP workspace: Incredibly trivial and probably useless code samples[^]

[Dave Kreskowiak]

I gotta call foul on removing the private access specifier. In C# the default is private while in VB it's Public. I absolutely hate that and really dont want to have to remember what the defaults ars supposed to be when scanning over code for problems.

A guide to posting questions on CodeProject

How to debug small programs
Dave Kreskowiak

[Lost User]

That var is obviously an int, and you didn't even save any characters there..

[PIEBALDconsult]

Gary Wheeler wrote:

Hungarian notation should die in a fire

That's too good for it. However, have you read this: Making Wrong Code Look Wrong by Joel Spolsky[^]

You'll never get very far if all you do is follow instructions.

[JMK NI]

I disagree, in a situation like:

CryptographicUnexpectedOperationException exception = new CryptographicUnexpectedOperationException();

I find this more readable:

var exception = new CryptographicUnexpectedOperationException();

Typing CryptographicUnexpectedOperationException twice in such a short space I think is a bit redundant

[JMK NI]

I didn't waste any characters either :^)

[Lost User]

PIEBALDconsult wrote:

the developer's intent should be clearly specified.

It IS clearly specified if it is omitted. It is not some arcane trick, it is not something that causes side-effects, and it improves readability. It is as usefull as typing "begin" and "end" instead of the default scope-blocks. It might take some getting used to, but it conveys the same amount of information using less symbols. That's kinda essential, and the reason why we are not programming in COBOL.

PIEBALDconsult wrote:

I don't want to have to guess

If you have to guess at the default access modifier in C#, you should not be writing in C#.

PIEBALDconsult wrote:

and decrease the hit to your own productivity caused by your juniors.

Should I prefix each class with a complete namespace? Otherwise they'd be guessing at which class it will take :D You explain a junior ONCE that everything that does not have a modifier is private. If they come asking, even once, then make them prefix everything. Using "this" and "that", using namespaces, using "global::". Throw in some hungarian systems, so they won't have to guess the type :suss:

Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]

[Lost User]

Hmm.. OK fine, I'll accept that excuse. This time.

[dan sh]

Intellisense does help. For reading, indentation is something I would prefer. It is opinion. I think MS wants to divide and rule. When did Britishers took over MS? *Last 2 sentences are supposed to be humor.

My CP workspace: Incredibly trivial and probably useless code samples[^]

[Lost User]

Eddy Vluggen wrote:

Should I prefix each class with a complete namespace? Otherwise they'd be guessing at which class it will take

You've done it now :-D

[OriginalGriff]

var is handy in two places: 1) When using Linq and returning "An IEnumerable of something, gawddammit, but I have no idea what the compiler is going to call it" 2) To identify people whose code you can't trust because they have no idea or no interest in what type a variable should be. It may save five keystrokes to use var instead of IEnumerable<Customer> but it doesn't help understanding when you have to read the code later.

Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952) Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)

[OriginalGriff]

d@nish wrote:

When did Britishers took over MS?

We didn't. If we had, the Color class would be spelled properly!

Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952) Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)

[dan sh]

OriginalGriff wrote:

To identify people whose code you can't trust

:thumbsup:

My CP workspace: Incredibly trivial and probably useless code samples[^]

[dan sh]

Wait, that explains it. Those who have trouble typing a "u", can not type IEnumerable< Whatever the hell it is >. I now know the whole purpose of var. Enlightened.

My CP workspace: Incredibly trivial and probably useless code samples[^]

[PIEBALDconsult]

Eddy Vluggen wrote:

explain a junior ONCE

That's once too many.

You'll never get very far if all you do is follow instructions.

[Lost User]

Adding oil to the fire, a practical example;

using System;
using System.Threading;
using System.Windows.Forms;
using System.Timers;

namespace ConsoleApplication5
{
class Program
{
Timer t = new System.Threading.Timer(null); // will not compile, as it is unclear which Timer
Timer t2 = new System.Windows.Forms.Timer(); // is declared (as opposed to the type instantiated)
Timer pfld_SysTimrTimrt3 = new System.Timers.Timer(); // using hungarian systems with namespace prefix

    static void Main(global::System.String\[\]\[\] strSrgs)
    {
        global::System.Console.ReadLine();
    }
}

}

And yes, the "console application template" has an entry point which is implicitly private.

Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]