Code Review
-
"CODE REVIEW" - This is a phrase that my boss uses everyday. I am not sure what it exactly means. So everytime I make a work log, I put in "Code Review" against my spare time. Now I am 110% efficient and he likes that.
Here's a Wikipedia[^] definition. Where I work, code reviews are done for every check-in (sometimes after the fact). Although the devs I work with are a bright and seasoned bunch, that doesn't exclude anyone from a code review. Our code reviews mainly focus on performance and security and serve as a "second pair of eyes" to help catch the odd bug. Reviewers rarely end up suggesting rewriting comments or renaming identifiers, because we have a set of guidelines already in place that addresses that sort of stuff. Our code reviews usually take no more than 10-15 minutes and are almost always limited to the developer and a single reviewer. I've learned a lot from having my own code reviewed. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
Here's a Wikipedia[^] definition. Where I work, code reviews are done for every check-in (sometimes after the fact). Although the devs I work with are a bright and seasoned bunch, that doesn't exclude anyone from a code review. Our code reviews mainly focus on performance and security and serve as a "second pair of eyes" to help catch the odd bug. Reviewers rarely end up suggesting rewriting comments or renaming identifiers, because we have a set of guidelines already in place that addresses that sort of stuff. Our code reviews usually take no more than 10-15 minutes and are almost always limited to the developer and a single reviewer. I've learned a lot from having my own code reviewed. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
Once we tried to do code review, but because of the nature of the code we have to gave up - it's mostly write-only code... :(
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
"It never ceases to amaze me that a spacecraft launched in 1977 can be fixed remotely from Earth." ― Brian Cox
-
Once we tried to do code review, but because of the nature of the code we have to gave up - it's mostly write-only code... :(
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
Brrrr! :shudder:
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952) Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt -
Brrrr! :shudder:
Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952) Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)
Tell me about that... I live it every day... All of our code base is in C# now (it's over 5 million lines of code), but when reading parts of it I still can smell COBOL from 20 years before...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
-
Tell me about that... I live it every day... All of our code base is in C# now (it's over 5 million lines of code), but when reading parts of it I still can smell COBOL from 20 years before...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
-
Do you know COBOL's STRING statement?
string Msg = FName + " " + LName + ", " + City;
is almost identical to
STRING FNAME SPACE LNAME ", " CITY DELIMITED BY SIZE INTO MSG.
We also have a lot of code using invalid value initialization for variables, like
int Msl = -1;
While in new code we use null... In COBOL we used LOW-VALUE as no NULL was available...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
-
Do you know COBOL's STRING statement?
string Msg = FName + " " + LName + ", " + City;
is almost identical to
STRING FNAME SPACE LNAME ", " CITY DELIMITED BY SIZE INTO MSG.
We also have a lot of code using invalid value initialization for variables, like
int Msl = -1;
While in new code we use null... In COBOL we used LOW-VALUE as no NULL was available...
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
The code I have been reviewing since the past few days is a VBA application. The developers used a lot of xml files to store all the conditional statements and dynamic data. The VB code contains subs like Call_ARF_something_something_something. I mean the subs are sctually named like that. So if there is call statement, it looks like Call Call_ARF_something. Apart from that, based on actual selections,new xml nodes are formed(by concateneting underscore and selections) and then the dynamic data is recorded inside those nodes. I found nodes like XML_Node_ARF_PFG_PFGOption_CFG_CFGOption_(......... and so on) It's a nightmare for me since there is no documentation and I have to figure out the business logic from all of this.
-
The code I have been reviewing since the past few days is a VBA application. The developers used a lot of xml files to store all the conditional statements and dynamic data. The VB code contains subs like Call_ARF_something_something_something. I mean the subs are sctually named like that. So if there is call statement, it looks like Call Call_ARF_something. Apart from that, based on actual selections,new xml nodes are formed(by concateneting underscore and selections) and then the dynamic data is recorded inside those nodes. I found nodes like XML_Node_ARF_PFG_PFGOption_CFG_CFGOption_(......... and so on) It's a nightmare for me since there is no documentation and I have to figure out the business logic from all of this.
-
Once we tried to do code review, but because of the nature of the code we have to gave up - it's mostly write-only code... :(
I'm not questioning your powers of observation; I'm merely remarking upon the paradox of asking a masked man who he is. (V)
At least it isn't APL! On a side note, I know someone who can READ APL code! No joke, he even demonstrated it with random code someone who was visiting from Germany came up with!
What do you get when you cross a joke with a rhetorical question?
-
At least it isn't APL! On a side note, I know someone who can READ APL code! No joke, he even demonstrated it with random code someone who was visiting from Germany came up with!
What do you get when you cross a joke with a rhetorical question?
