migration from Visual studio 6
-
Yes the code is ancient, everything seems reverse to me. as you suggested i commented second block. #ifdef __STDC__ DWORD WINAPI process( LPVOID Var ) //#else //DWORD WINAPI process( var) // LPVOID var; #endif lot many errors are reduced, now what I get is: xyz.cpp(46) : error C2447: '{' : missing function header (old-style formal list?) xyz.cpp(46) : error C2447: '{' : missing function header (old-style formal list?) xyz.cpp(46) : error C2447: '{' : missing function header (old-style formal list?) xyz.cpp(46) : error C2059: syntax error : '}' xyz.cpp(46) : error C2143: syntax error : missing ';' before '}' xyz.cpp(196) : error C2059: syntax error : '}'
#if n def __STDC__ DWORD WINAPI process( LPVOID Var ) //#else //DWORD WINAPI process( var) // LPVOID var; #endif it compiled with NO ERRORS. i changed #ifdef to #ifndef to execute DWORD WINAPI process( LPVOID Var ) part of the code - and no errors in compilations.
-
It should look like this:
//#ifdef __STDC__
DWORD WINAPI ZI_process_monitor( LPVOID TA_arg )
//#else
//DWORD WINAPI ZI_process_monitor( TA_arg )
// LPVOID TA_arg;
//#endifwhen
__STDC__is not defined. Finally you should delete all commented lines. -
It should look like this:
//#ifdef __STDC__
DWORD WINAPI ZI_process_monitor( LPVOID TA_arg )
//#else
//DWORD WINAPI ZI_process_monitor( TA_arg )
// LPVOID TA_arg;
//#endifwhen
__STDC__is not defined. Finally you should delete all commented lines.my PQR.cpp file which was originally failing at ctype.h line#362 - #if !__STDC__ saying "Compiling...PQR.cpp include\ctype.h(362) : fatal error C1017: invalid integer constant expression for which i went on to fix file xyz.cpp, xyz.cpp got fixed when i undid my __STDC__ related changes and applied your suggestions but the old one PQR.cpp is still breaking with same error at same location :(( I applied your suggestions to PQR.CPP (The real file and real error for which i started all this) also thinking that if XYZ.CPP works PQR.cpp also should work, I can finally get rid of ctype.h but NOOO :(
-
my PQR.cpp file which was originally failing at ctype.h line#362 - #if !__STDC__ saying "Compiling...PQR.cpp include\ctype.h(362) : fatal error C1017: invalid integer constant expression for which i went on to fix file xyz.cpp, xyz.cpp got fixed when i undid my __STDC__ related changes and applied your suggestions but the old one PQR.cpp is still breaking with same error at same location :(( I applied your suggestions to PQR.CPP (The real file and real error for which i started all this) also thinking that if XYZ.CPP works PQR.cpp also should work, I can finally get rid of ctype.h but NOOO :(
Was ctype.h included before or did you add it? If you added it, remove the including. If it was there, check the line with the failure in ctype.h. Check also if the failing code is guarded by some preprocessor definition. A common error would be that some type or definition used by ctype.h is improperly defined somewhere in your header files. You may also move the including of ctype.h on top before inclduing any other file (except stdafx.h if used).
-
Was ctype.h included before or did you add it? If you added it, remove the including. If it was there, check the line with the failure in ctype.h. Check also if the failing code is guarded by some preprocessor definition. A common error would be that some type or definition used by ctype.h is improperly defined somewhere in your header files. You may also move the including of ctype.h on top before inclduing any other file (except stdafx.h if used).
it all began with __STDC__. I took the VS6 codebase dump and started compiling for that 1) lots of tagVariant related to fix that i removed __STDC__ from project properties. 2) now i stared getting syntax related error in my .cpp and .c files in thousands. 3) to remove that I added __STDC__ locally in some of the files like xyz.cpp 4)Then most of the files compiled but PQR.cpp and ABC.cpp gave an error failure in ctype.h at line 362 5)then I contacted you 6) I learnt about __STDC__ more in detail and removed __STDC__ from my files where ever i had added it to fix syntax errors and did the proper code fix with your help. 7)I am again back ctype.h file error in PQR and ABC .cpp files. I am trying what you are suggesting now...atleast that seems a right way to go...
-
Was ctype.h included before or did you add it? If you added it, remove the including. If it was there, check the line with the failure in ctype.h. Check also if the failing code is guarded by some preprocessor definition. A common error would be that some type or definition used by ctype.h is improperly defined somewhere in your header files. You may also move the including of ctype.h on top before inclduing any other file (except stdafx.h if used).
Wow...I could compile the project. :-D I do have lot of LINK errors but I will work on it. I learnt this "Use precompiled headers - stdafx.h. This must be the first include in your .cpp file." Changed the sequence of the .h files and I am all set now. Thanks a TON Jochen...you are awesome !! :rose:
-
Wow...I could compile the project. :-D I do have lot of LINK errors but I will work on it. I learnt this "Use precompiled headers - stdafx.h. This must be the first include in your .cpp file." Changed the sequence of the .h files and I am all set now. Thanks a TON Jochen...you are awesome !! :rose:
Fine that you finally solved all compiling errors.
-
Then blame the one who has written the code. What you need is
DWORD WINAPI process( LPVOID Var1)
That is valid C++ and C (including ANSI C). The second block is old style K&R C which is not used anymore since about 30 years. If such conditions are used all over your source files, you must remove the conditions and the second block.
-
how can i get rid of lot of the below mentioned warnings : warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'VAR1' ? Are they serious ?
To get rid of the warning ensure that the parameter lists of the functions agree. If this is serious depends on the assignment. It is just a warning and the code will be compiled. But your application may crash when passing incompatible parameters. You should show the assignment and the definitions.
-
To get rid of the warning ensure that the parameter lists of the functions agree. If this is serious depends on the assignment. It is just a warning and the code will be compiled. But your application may crash when passing incompatible parameters. You should show the assignment and the definitions.
below given code in file 'some.c' --------------------------------
#ifdef __STDC__
static int fun1 ( struct1_inlistfile membervar1, void_pointerinlist_file membervar2 )
#elsestatic int fun1 (membervar1, membervar2)
struct1_inlistfile membervar1;
void_pointerinlist_file membervar2;#endif
if the code is as above - I get this warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'RECORDstructinlistheader' file if i comment the above code like you showed the other day the warning goes away. .h file has record defination in the form off struct. the 'some.c' file has another list class defination static RECORDstructinlistheader Listclass = { sizeof(RECORD), sizeof(element in record), add function , search function, /*This is the line where warning is pointed to */ pointer set, . . . I am afraid I am confusing, but I am giving much details to understand it correctly. pls help.
-
below given code in file 'some.c' --------------------------------
#ifdef __STDC__
static int fun1 ( struct1_inlistfile membervar1, void_pointerinlist_file membervar2 )
#elsestatic int fun1 (membervar1, membervar2)
struct1_inlistfile membervar1;
void_pointerinlist_file membervar2;#endif
if the code is as above - I get this warning C4113: 'int (__cdecl *)()' differs in parameter lists from 'RECORDstructinlistheader' file if i comment the above code like you showed the other day the warning goes away. .h file has record defination in the form off struct. the 'some.c' file has another list class defination static RECORDstructinlistheader Listclass = { sizeof(RECORD), sizeof(element in record), add function , search function, /*This is the line where warning is pointed to */ pointer set, . . . I am afraid I am confusing, but I am giving much details to understand it correctly. pls help.
So you did not get the warning when removing the
__STDC__stuff? Then its should be OK. To resolve the error check the declaration ofsearch_functionand the correspondingRECORDstructinlistheaderstructure member (structure definition in some header file). -
So you did not get the warning when removing the
__STDC__stuff? Then its should be OK. To resolve the error check the declaration ofsearch_functionand the correspondingRECORDstructinlistheaderstructure member (structure definition in some header file).right no warnings when removing __STDC__ stuff. I am trying to resolve where is that disagreement happening - but I am confused looking what is the meaning of these four statement ?
typedef int (*p)(void *, void *);
typedef void *P;
typedef void* P;
typedef void* (*p)();
-
right no warnings when removing __STDC__ stuff. I am trying to resolve where is that disagreement happening - but I am confused looking what is the meaning of these four statement ?
typedef int (*p)(void *, void *);
typedef void *P;
typedef void* P;
typedef void* (*p)();
Swap9 wrote:
right no warnings when removing __STDC__ stuff.
Then don't care about it.
// A pointer to a function returning an int and accepting to parameters of type void*
typedef int (*p)(void *, void *);
// Use it this way:
// int some_func(void *p1, void *p2);
// p my_func = some_func;
// Then you can call the function
// int nRet = my_func(param1, param2);// A pointer to an unspecified object
typedef void *P;// A pointer to a function returning void*
typedef void* (*p)();
// With the preceeding typedef it can be also written as
typedef P (*p)(); -
Swap9 wrote:
right no warnings when removing __STDC__ stuff.
Then don't care about it.
// A pointer to a function returning an int and accepting to parameters of type void*
typedef int (*p)(void *, void *);
// Use it this way:
// int some_func(void *p1, void *p2);
// p my_func = some_func;
// Then you can call the function
// int nRet = my_func(param1, param2);// A pointer to an unspecified object
typedef void *P;// A pointer to a function returning void*
typedef void* (*p)();
// With the preceeding typedef it can be also written as
typedef P (*p)(); -
So you did not get the warning when removing the
__STDC__stuff? Then its should be OK. To resolve the error check the declaration ofsearch_functionand the correspondingRECORDstructinlistheaderstructure member (structure definition in some header file). -
I also have another issue - posted at http://www.codeproject.com/Messages/4873177/How-can-I-display-Japanese-characters-in-an-applic.aspx[^] Will be able to help please ?
I saw that post but thought it was (partially) solved. When the application uses Japanese Multi Byte characters, support for this characters must be installed in Windows. The best approach would be converting the application to Unicode. But that might be a lot of work (all char and string literals must be manually rewritten by enclosing them using the
_T()macro and the resource strings must be also updated). -
I saw that post but thought it was (partially) solved. When the application uses Japanese Multi Byte characters, support for this characters must be installed in Windows. The best approach would be converting the application to Unicode. But that might be a lot of work (all char and string literals must be manually rewritten by enclosing them using the
_T()macro and the resource strings must be also updated).Ok thats another approach - but if its easy I can do it. Will you be able to show me a simple example of it ? can I compile and execute it in Japanese just by adding _T() on the Japanese windows ? I had another expert suggesting me this option, but that looked like another proj on its own http://social.msdn.microsoft.com/Forums/vstudio/en-US/d3b75db1-3646-4591-84c5-924cd5ec3065/how-to-change-the-application-to-display-gui-screens-captions-etc-in-both-the-languages-japanese?forum=vcgeneral#a4ff216a-fd6c-419f-a8a5-81b40b08e4b8[^]
-
Ok thats another approach - but if its easy I can do it. Will you be able to show me a simple example of it ? can I compile and execute it in Japanese just by adding _T() on the Japanese windows ? I had another expert suggesting me this option, but that looked like another proj on its own http://social.msdn.microsoft.com/Forums/vstudio/en-US/d3b75db1-3646-4591-84c5-924cd5ec3065/how-to-change-the-application-to-display-gui-screens-captions-etc-in-both-the-languages-japanese?forum=vcgeneral#a4ff216a-fd6c-419f-a8a5-81b40b08e4b8[^]
I'm sorry but I can't really help you with the language issues due to lack of experience with multi byte projects. Your link seems to describe the problem. Porting an appplication to Unicode is a lot of work (more than I told you before; I forget to mention additional tasks). If you decide to port your application take special care when reading and writing text file. You may want to let those still use ANSI rather than Unicode.
-
I'm sorry but I can't really help you with the language issues due to lack of experience with multi byte projects. Your link seems to describe the problem. Porting an appplication to Unicode is a lot of work (more than I told you before; I forget to mention additional tasks). If you decide to port your application take special care when reading and writing text file. You may want to let those still use ANSI rather than Unicode.