Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. Other Discussions
  3. The Insider News
  4. Don't waste time on code reviews

Don't waste time on code reviews

Scheduled Pinned Locked Moved The Insider News
javacsssharepointcom
16 Posts 9 Posters 1 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P PIEBALDconsult

    All code is flawless until proven otherwise.

    N Offline
    N Offline
    Nguyen H H Dang
    wrote on last edited by
    #7

    That awkward moment, when my code works and i don't know why :doh:

    In code we trust !

    T 1 Reply Last reply
    0
    • K Kent Sharkey

      DZone[^]:

      Less than half of development teams do code reviews and the other half are probably not getting as much out of code reviews as they should.

      4 Stars: I laughed, I cried.

      R Offline
      R Offline
      Ranjan D
      wrote on last edited by
      #8

      This is what happens when the authors article is not reviewed by his editor :laugh:

      1 Reply Last reply
      0
      • P PIEBALDconsult

        Easy. No time spent on code reviews is ever wasted.

        L Offline
        L Offline
        Lost User
        wrote on last edited by
        #9

        Amen.

        Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]

        1 Reply Last reply
        0
        • P PIEBALDconsult

          Easy. No time spent on code reviews is ever wasted.

          T Offline
          T Offline
          thrakazog
          wrote on last edited by
          #10

          Strongly disagree. I've sat through hours and hours of them with previous employers. In many cases I'd argue that the outcome was worse code. But as the article pointed out, these fell in the: "But you don’t have to do code reviews this way – and you shouldn’t." category.

          Play my game Gravity: Android[^], Windows Phone 7[^]

          P L 2 Replies Last reply
          0
          • T thrakazog

            Strongly disagree. I've sat through hours and hours of them with previous employers. In many cases I'd argue that the outcome was worse code. But as the article pointed out, these fell in the: "But you don’t have to do code reviews this way – and you shouldn’t." category.

            Play my game Gravity: Android[^], Windows Phone 7[^]

            P Offline
            P Offline
            PIEBALDconsult
            wrote on last edited by
            #11

            Still not wasted. You learned something.

            T 1 Reply Last reply
            0
            • N Nguyen H H Dang

              That awkward moment, when my code works and i don't know why :doh:

              In code we trust !

              T Offline
              T Offline
              thrakazog
              wrote on last edited by
              #12

              You ever open up some old code.... and wonder how it even compiled? :rolleyes:

              Play my game Gravity: Android[^], Windows Phone 7[^]

              1 Reply Last reply
              0
              • P PIEBALDconsult

                Still not wasted. You learned something.

                T Offline
                T Offline
                thrakazog
                wrote on last edited by
                #13

                I learned not to do code reviews. So yeah, that's something. :-D

                Play my game Gravity: Android[^], Windows Phone 7[^]

                P 1 Reply Last reply
                0
                • T thrakazog

                  I learned not to do code reviews. So yeah, that's something. :-D

                  Play my game Gravity: Android[^], Windows Phone 7[^]

                  P Offline
                  P Offline
                  PIEBALDconsult
                  wrote on last edited by
                  #14

                  I thought you learned to find a job at a company with a better process.

                  1 Reply Last reply
                  0
                  • T thrakazog

                    Strongly disagree. I've sat through hours and hours of them with previous employers. In many cases I'd argue that the outcome was worse code. But as the article pointed out, these fell in the: "But you don’t have to do code reviews this way – and you shouldn’t." category.

                    Play my game Gravity: Android[^], Windows Phone 7[^]

                    L Offline
                    L Offline
                    Lost User
                    wrote on last edited by
                    #15

                    thrakazog wrote:

                    Strongly disagree. I've sat through hours and hours of them with previous employers

                    Into the same category as the smoking uncle of 120 years old.

                    Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]

                    T 1 Reply Last reply
                    0
                    • L Lost User

                      thrakazog wrote:

                      Strongly disagree. I've sat through hours and hours of them with previous employers

                      Into the same category as the smoking uncle of 120 years old.

                      Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]

                      T Offline
                      T Offline
                      thrakazog
                      wrote on last edited by
                      #16

                      I'd say it belongs more in the category of the uncle once bit by a dog who was forever more a cat person. There might be a right way to do code reviews. But I've yet to see it.

                      Play my game Gravity: Android[^], Windows Phone 7[^]

                      1 Reply Last reply
                      0
                      Reply
                      • Reply as topic
                      Log in to reply
                      • Oldest to Newest
                      • Newest to Oldest
                      • Most Votes


                      • Login

                      • Don't have an account? Register

                      • Login or register to search.
                      • First post
                        Last post
                      0
                      • Categories
                      • Recent
                      • Tags
                      • Popular
                      • World
                      • Users
                      • Groups