Being told to fix bugs caused by others
-
Pawel Krakowiak wrote:
bugs caused by others
NO WAY! You mean to tell me bugs are caused by others? :omg: :wtf:
»»» Loading Signature «««· · · Please Wait · · ·:badger: :badger: :badger:CBadger wrote:
NO WAY! You mean to tell me bugs are caused by others? :OMG: :WTF:
Or Microsoft. :-O
-
Pawel Krakowiak wrote:
Another dev went in and changed how some code works
Pawel Krakowiak wrote:
This really grinds my gears.
This brings back old memories. Years ago at a large corp. I was forced to write code over a weekend, because "it had to be comleted". I did the work, wrote some documentation, wrote test cases and put the code out for QA team. Of course, even though it had to be done immediately, they never got around to the code for weeks later. Oh, yes, this was HIGH PRIORITY. Whatever. Anyways, weeks later, the guy puts the stuff into production and someone comes to me. "That fails upon start up. Can you have a look." I looked at the code. What? Wait. I've never seen this code. Even though it's supposedly my code. What is going on? After much searching I find a contractor. An architect who is certainly my genius master. He says, "Oh, I rewrote that code." "Well, you did a bang up job," I said. "It doesn't even start. You're going to have to fix it." "I don't do that," he said. Later my boss told me I had to fix The Genius Architect's code even though I had already written code that worked and the GENIUS rewrote my code. What?!? (deployment of interrobang) That is utter stupidity!!! I totally understand your frustration. He who touches code should fix it!!!
newton.saber wrote:
Later my boss told me I had to fix The Genius Architect's code even though I had already written code that worked and the GENIUS rewrote my code.
What?!? (deployment of interrobang)At which point you just reverted the architards checkin to the prior working version?
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt
-
newton.saber wrote:
Later my boss told me I had to fix The Genius Architect's code even though I had already written code that worked and the GENIUS rewrote my code.
What?!? (deployment of interrobang)At which point you just reverted the architards checkin to the prior working version?
Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt
Dan Neely wrote:
reverted the architards checkin to the prior working version?
That's exactly what I wanted to do, but I wasn't allowed. It was completely political. Basically, without examining anything my boss said, "His unworking code is better than your working code." Now you could assume I'm an idiot and my code is complete crap. But, honestly, the code worked very well and was actually designed and I had unit tests, etc. Here's the kicker... The code was never put into production anyway, because the entire project went belly-up after they spent millions $$$ paying for contractors (such as the architect) who never could get the final product running. ugh!
-
This is good advice. Maybe unless they never listen to you.
I'm with Pete on this one, as I see team work more valuable than being the sole star in the eyes of manager. However with that said it depends mostly on the team AND the manager. If your teammate doesn't care (again?) then definitely bring it to your manager. If he also doesn't care... well... I would say time for a new job. In a company I worked for a while ago, management added mandatory field to bugs in JIRA - you had to choose from the list of devs who caused the bug. Needless to say it didn't work very well in the long run...
-- "My software never has bugs. It just develops random features."
-
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
In my previous job, a successful (I developed it) application's second version was outsourced, they paid hundreds of thousands of dollars for that external development and when it came back, they assigned me to fix it. I think it beats that. :laugh: Also in that marvelous company with stellar management, the CIO used to say that debugging and fixing bugs shouldn't be done by people who developed an application, because they wrote the code and will follow the happy path. Apparently he didn't make a distinction between testing and bug fixing.
-
Ahem. With colleagues, always praise in public and criticize them in private (i.e., to them and not just talking about them behind their back).
-
In my previous job, a successful (I developed it) application's second version was outsourced, they paid hundreds of thousands of dollars for that external development and when it came back, they assigned me to fix it. I think it beats that. :laugh: Also in that marvelous company with stellar management, the CIO used to say that debugging and fixing bugs shouldn't be done by people who developed an application, because they wrote the code and will follow the happy path. Apparently he didn't make a distinction between testing and bug fixing.
Kamen Nik wrote:
debugging and fixing bugs shouldn't be done by people who developed an application
It's good to be KING!! (See Mel Brook's History of the World Part I[^]) This terrible logic would seem to create sub-human RULERS who think everything they produce is perfect. (In an exercise of self-control, I will not mention anything toilet-related here.) Blithely they roll on. Ignorance of our own failures is the most beautifully ugly thing. :D
-
CBadger wrote:
NO WAY! You mean to tell me bugs are caused by others? :OMG: :WTF:
Or Microsoft. :-O
-
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
Pawel Krakowiak wrote:
I feel that whoever breaks stuff should be publicly shamed
Impossible! Everyone breaks something once in a while and when everyone is publicly shamed there is no public to watch the shaming and thus no one is publicly shamed. Now let me find that post where your colleague said the same about your code... :D
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
} -
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
That's 'caused'. There. Now it's fixed.
-
That's 'caused'. There. Now it's fixed.
I'm not a native English speaker, so I'd appreciate if you could elaborate. :) Perhaps the word choice is incorrect in the first place. Maybe one can't "cause" a bug. I guess I should have said "introduced".
-
I'm not a native English speaker, so I'd appreciate if you could elaborate. :) Perhaps the word choice is incorrect in the first place. Maybe one can't "cause" a bug. I guess I should have said "introduced".
Sorry Pawel, I was just joking about the slight spelling mistake in your heading. It was a bug. 'Caused' is a good word to use. And I see you fixed it! :-D
-
Like Windows Vista
»»» Loading Signature «««· · · Please Wait · · ·:badger: :badger: :badger: -
What, there are unemployed software engineers?!
-
I used to list HTML under known programming languages on my CV. ;)
-
I thought Vista was a virus. I tried installing XP but Vista insists it's a "better version". Now I just use 3.1 and have no viruses!
-
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
<OldWarStory>When I graduated from college, I went to work for the same company I'd worked for as an intern. My boss was pretty overbearing and judgmental. We wrote a data acquisition system for a customer, and were doing some on-site debugging. On the first day, I fixed an issue we found. A couple days later, the issue started happening again, and my boss starts yelling at me. I looked at the code, and my fix was gone. The original code had been restored. Come to find out, my boss didn't like how I'd done something else and restored an earlier version of the entire source file, without regard to any changes. The remaining two days of the trip, and the 8-hour drive home, were spent in utter silence on my part. During the drive home he tried to half-way apologize, but the damage was done.</OldWarStory>Software Zen:
delete this; -
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
You have my deepest sympathies.
Some years back, my department was afflicted with a manager who thought he could and should "fix the inefficiencies" in other people's code. The responsibility for dealing with problems he created invariably wound up on those hapless "other people's" desks...mine included. The ill will he generated that way was thick enough to be carved into entrée portions and served with hollandaise sauce.
Needless to say, the manager was never taken to task by his superiors for his arrogant interference in things he knew next to nothing about. However, the problem went away when he met an untimely demise: run over by an SUV, right in our very own parking lot. And they say there's no justice in this world!
(This message is programming you in ways you cannot detect. Be afraid.)
-
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
Well this is a matter of the tension between 'get her done' and teaching. The solution my currant company has come up with is using a web based code review system. When I get someone else bug, I fix it, but then I make sure they are on the code review so they can see the fix. If they are someone I know well, I will talk with them about what and why I did it. This allows me to get her done for the business while still making it a teaching opportunity. Mind you, if the other developer does not care, I totally agree with the other poster that said you need to take that to your manager, that IS why they are there:)
-
I created part of a web app. Another dev went in and changed how some code works and a modal dialog stopped working (it shows as an empty modal with only the title, but underneath there's an exception). Guess who was assigned the bug? Of course the creator of the tool, that would be me. This happens from time to time and I hate it. I feel that whoever breaks stuff should be publicly shamed ;) (for example in the CI server's website, but of course my client doesn't have CI...) and responsible for fixing it. I am sure this was discussed a dozen times here, sorry. This really grinds my gears.
Maybe you can take this negative and turn it into a positive. A true team really doesn't need a manager or to be publicly shamed, they're able to communicate among themselves and tackle issues together. Play dumb and ask the guy that wrote the code to help you. Point out the error and ask for his input. Get an understanding of what he did and hopefully he gets an understanding of what you did.
