Sloppy Code - thoughts
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
However awful my code might be, at least it's properly formatted... :-) I agree with you; it's the same when I interview a developer that turns up looking like a homeless person: if you can't be bothered to take care of yourself, why would I believe that you'd be any different with your attitude to coding?
-
However awful my code might be, at least it's properly formatted... :-) I agree with you; it's the same when I interview a developer that turns up looking like a homeless person: if you can't be bothered to take care of yourself, why would I believe that you'd be any different with your attitude to coding?
Or if they smell bad man. All the sudden the entire interaction becomes about the stinch and how to get away from it.
Jeremy Falcon
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
What Karel said. Coding is, well, a love affair, and I expect code to be treated respectfully, and in part that means it should be visually pleasing, from 10 feet away, to look at.
Jeremy Falcon wrote:
the coders that write messy code tend to also have messy cars and homes. It's gross.
Have you visited them??? But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience. Marc
Imperative to Functional Programming Succinctly Contributors Wanted for Higher Order Programming Project!
-
What Karel said. Coding is, well, a love affair, and I expect code to be treated respectfully, and in part that means it should be visually pleasing, from 10 feet away, to look at.
Jeremy Falcon wrote:
the coders that write messy code tend to also have messy cars and homes. It's gross.
Have you visited them??? But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience. Marc
Imperative to Functional Programming Succinctly Contributors Wanted for Higher Order Programming Project!
Marc Clifton wrote:
Have you visited them???
Some I've hung out with over the years and some I just listened to them talk about their habits. It's amazing what you can learn if you really listen to the stuff people say.
Marc Clifton wrote:
But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience.
Agreed. It's just a lazy mentality. And if they're that lazy about formatting, chances are they're that lazy about learning and education.
Jeremy Falcon
-
Or if they smell bad man. All the sudden the entire interaction becomes about the stinch and how to get away from it.
Jeremy Falcon
That is the worst of all possible scenarios. Have had to tell someone that they need to bathe. Was not pleasant.
-
Marc Clifton wrote:
Have you visited them???
Some I've hung out with over the years and some I just listened to them talk about their habits. It's amazing what you can learn if you really listen to the stuff people say.
Marc Clifton wrote:
But even more of an issue for me is, coders that write messy code also write bad code, at least in my experience.
Agreed. It's just a lazy mentality. And if they're that lazy about formatting, chances are they're that lazy about learning and education.
Jeremy Falcon
Jeremy Falcon wrote:
It's amazing what you can learn if you really listen to the stuff people say.
Aye, and listening is a skill I find very few people have. This guy[^] has some short TedTalks on the subject I found quite good, if you're interested. Marc
Imperative to Functional Programming Succinctly Contributors Wanted for Higher Order Programming Project!
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
Code that only a mother could love?
New version: WinHeist Version 2.1.0 My goal in life is to have a psychiatric disorder named after me. I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.
-
Code that only a mother could love?
New version: WinHeist Version 2.1.0 My goal in life is to have a psychiatric disorder named after me. I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.
+5 :thumbsup:
Jeremy Falcon
-
Jeremy Falcon wrote:
It's amazing what you can learn if you really listen to the stuff people say.
Aye, and listening is a skill I find very few people have. This guy[^] has some short TedTalks on the subject I found quite good, if you're interested. Marc
Imperative to Functional Programming Succinctly Contributors Wanted for Higher Order Programming Project!
I will check that out. Thanks.
Jeremy Falcon
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
-
How is it even possible to have badly formatted code in this day and age? You can just press ctrl+shift+alt+windows+1+F and have it automatically formatted.
Formatting is just one piece of the puzzle.
Jeremy Falcon
-
However awful my code might be, at least it's properly formatted... :-) I agree with you; it's the same when I interview a developer that turns up looking like a homeless person: if you can't be bothered to take care of yourself, why would I believe that you'd be any different with your attitude to coding?
So you think Einstein was wrong? ;P
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
Jeremy Falcon wrote:
Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
I was going to point out the same fact, interestingly enough. :thumbsup: Edit: I am saying this is "fact" only because I have never seen otherwise. I am sure it really is not a fact. :rolleyes:
-
How is it even possible to have badly formatted code in this day and age? You can just press ctrl+shift+alt+windows+1+F and have it automatically formatted.
People can also make their bed, take out the trash, and do the dishes...but they don't.
-
Jeremy Falcon wrote:
Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
I was going to point out the same fact, interestingly enough. :thumbsup: Edit: I am saying this is "fact" only because I have never seen otherwise. I am sure it really is not a fact. :rolleyes:
We don't really have time for facts, we mostly go with assumptions instead.
-
While we're on the subject of code reviews, what do you guys think about sloppy code that's not formatted well? I tend to not think I'm that anal retentive, but I admit the poindexter comes out when I see sloppy code that's not kept up to a proper margin, not indented decently, old commented code left in, etc. Oddly enough, the coders that write messy code tend to also have messy cars and homes. It's gross.
Jeremy Falcon
It's so easy to format your code properly... Ctrl + K, Ctrl + D (in Visual Studio anyway). It doesn't delete white spaces, but it does quite a bit for you. I'm amazed at how much badly formatted code I still see! And in my experience if the code is poorly formatted it's poorly written. Comments are as bad, or worse...
// Create a new person
Person p = new Person();NO, REALLY!? Arghhh! And I actually see those kinds of comments... Another thing I can't stand is copy-paste programming. And much too often it's way too obvious. The following is some production code I've had the 'pleasure' of working with (it was an obvious comment that was copy-pasted, but not edited with the code).
// Save the customer
product.Save();I looked at it and screamed in disgust "OH LORD, WHY DO YOU HATE ME SO!? :(( "
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
} -
We don't really have time for facts, we mostly go with assumptions instead.
I'll accept that as a fact.
Jeremy Falcon
-
I'll accept that as a fact.
Jeremy Falcon
You assume too much :laugh:
-
So you think Einstein was wrong? ;P
About what?
