All This For A MessageBox??
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
What a fool. Everyone knows you should use ShowDialog() on MessageBoxes :)
Visit my blog at Sander's bits - Writing the code you need. Or read my articles at my CodeProject profile.
Simplicity is prerequisite for reliability. — Edsger W. Dijkstra
Regards, Sander
-
It does not add any obvious value over the standard way. It does add the obvious disadvantage that it is different from those in all the textbooks and online examples. It would also incur an overhead, introduce the chance of bugs, and increase overall complexity. But does it actually show a real MessageBox? Or is it something similar, with additional stuff? What does t.Result.LockMessage contain? Whotsitstype? If it is simply the Windows MessageBox, then it is adding more costs than value :)
Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^][](X-Clacks-Overhead: GNU Terry Pratchett)
My point exactly... plus, they use the Fluent design (method chaining) EVERYWHERE. I agree - there's not a whole lot of added value, IMHO.
If it's not broken, fix it until it is
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
That's awful. Much easier to just write (and faster to execute) as:
MessageBox (hWnd,
(LPCTSTR) "Warning"
(LPCTSTR) "Please open the state procedure with a lock."
MB_ICONINFORMATION | MB_OK);The heck with localization. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
Coder For Hire wrote:
I've been working at this place about a month now, and EVERYTHING is way too abstracted out...
Are you being required to write shit like that, too? If so, then leave.
-
Coder For Hire wrote:
I've been working at this place about a month now, and EVERYTHING is way too abstracted out...
Are you being required to write shit like that, too? If so, then leave.
Already looking
If it's not broken, fix it until it is
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
You're put off pretty quickly I have to say, this is really just superficial. Looks like the messages are localized, but other than that doesn't seem unnecessarily verbose.
Wout
-
You're put off pretty quickly I have to say, this is really just superficial. Looks like the messages are localized, but other than that doesn't seem unnecessarily verbose.
Wout
There is no good reason to code a messagebox like that. I'm put off because, like I said, EVERYTHING in this app is way over cooked. It takes FOREVERY to find something, and then FOREVER to make a small change.
If it's not broken, fix it until it is
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
You think that's bad, how about working with a class named
VirtualEthernetCardDistributedVirtualPortBackingInfo? -
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
This reminds me of my current workplace. All the C++ class are heavily templated(The one I am working on, 20 data members are generic), even integer type are templated(can use
int32orint64). Very versatile but very difficult to find and read code because intellisense is not working as it does not know the type used; F12 is not working. Development time is impacted. PITA everyday! -
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
Yeah that's pretty horrible. I hate people over-abstracting... nooooooooooo point.
-
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
Navigator
.PrepareMessageBox(
TheApp
.Messages
.ErrorWarningMessages
.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2,
stateProcedure.StateDescription,
t.Result.LockMessage
)
.UseButtons(MessageBoxOptions.OK).Show();If I were to deal with code like this, the first thing I would do is sprinkle newlines *everywhere*...
-
That's awful. Much easier to just write (and faster to execute) as:
MessageBox (hWnd,
(LPCTSTR) "Warning"
(LPCTSTR) "Please open the state procedure with a lock."
MB_ICONINFORMATION | MB_OK);The heck with localization. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
Ravi Bhavnani wrote:
The heck with localization.
Yes, but it's so much fun, Ravi... Been there, done that, got the UNICODE/UTF-8 scars to prove it.
Software Zen:
delete this; -
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
Is this guy channelling Salvador Dali or what?
Software Zen:
delete this; -
Navigator.PrepareMessageBox(TheApp.Messages.ErrorWarningMessages.StateProceduresMenuVM_MsgboxBody_OpenStateProcedureWithLock_2, stateProcedure.StateDescription, t.Result.LockMessage).UseButtons(MessageBoxOptions.OK).Show();
I've been working at this place about a month now, and EVERYTHING is way too abstracted out... This is a classic example of over-coding something.. makes we want to find the guy who wrote and shake him violently.
If it's not broken, fix it until it is
But ... but it's so FLEXIBLE! ;)
-
You're put off pretty quickly I have to say, this is really just superficial. Looks like the messages are localized, but other than that doesn't seem unnecessarily verbose.
Wout
