Maintainable Design Pattern
-
I am the senior engineer at my firm and I have been asked to outsource some of our projects. After much deliberation, we had two projects done this way. Here is the question... my team and I reviewed the solutions and found a pattern that we could not understand... here is one example: The ASP.NET application contained a few work steps where an email was to be sent. There were a total of 13 different instances. Each instance had code to read the app.config settings, set the mail properties and send the email. A new SMTP server required SSL and we had to update all 13 instances. SO... why would the developers code this 13 times, instead of writing a simple static method/function??? We took the solution apart and found this "pattern" all over the place.. lots of cut/paste, hard coded values, etc... I am missing something? Is this something we have to get used to when dealing with outsourcing? I know.. lots of questions.. but some insight would be appreciated... thanks.
LM
-
I am the senior engineer at my firm and I have been asked to outsource some of our projects. After much deliberation, we had two projects done this way. Here is the question... my team and I reviewed the solutions and found a pattern that we could not understand... here is one example: The ASP.NET application contained a few work steps where an email was to be sent. There were a total of 13 different instances. Each instance had code to read the app.config settings, set the mail properties and send the email. A new SMTP server required SSL and we had to update all 13 instances. SO... why would the developers code this 13 times, instead of writing a simple static method/function??? We took the solution apart and found this "pattern" all over the place.. lots of cut/paste, hard coded values, etc... I am missing something? Is this something we have to get used to when dealing with outsourcing? I know.. lots of questions.. but some insight would be appreciated... thanks.
LM
Lucas A. Martinez wrote:
Is this something we have to get used to when dealing with outsourcing
Yes! Think about their business model, they make money from churning out solutions and the hours spent supporting the solutions. So the faster the solution and the more intensive the support the more money they make! Where is the incentive to write elegant, supportable code? It always astonishes me when an organisation outsources their development and then expects quality.
Never underestimate the power of human stupidity RAH
-
I am the senior engineer at my firm and I have been asked to outsource some of our projects. After much deliberation, we had two projects done this way. Here is the question... my team and I reviewed the solutions and found a pattern that we could not understand... here is one example: The ASP.NET application contained a few work steps where an email was to be sent. There were a total of 13 different instances. Each instance had code to read the app.config settings, set the mail properties and send the email. A new SMTP server required SSL and we had to update all 13 instances. SO... why would the developers code this 13 times, instead of writing a simple static method/function??? We took the solution apart and found this "pattern" all over the place.. lots of cut/paste, hard coded values, etc... I am missing something? Is this something we have to get used to when dealing with outsourcing? I know.. lots of questions.. but some insight would be appreciated... thanks.
LM
Next time, give them a small job for a fixed bid that you can review at the end of the week. If they "fail", they don't get paid or hired. Get it in writing. (In the freelance "business", "fixed bids" typically don't get paid if you botch the job). Another thing: the person you interview is not always the one that winds up doing the job ... You can be as skilled as you want interviewing, but in the end, they may very well just pass your project on to some code factory (because you can't see them). And all the while you're thinking: "But they sounded like they knew what they were doing...". And of course they did. Anyway, outsourced or not, there should be some deliverable to review at the end of each week so you can catch issues like the one above. I assume the project manager / lead was "theirs"? No?
-
I am the senior engineer at my firm and I have been asked to outsource some of our projects. After much deliberation, we had two projects done this way. Here is the question... my team and I reviewed the solutions and found a pattern that we could not understand... here is one example: The ASP.NET application contained a few work steps where an email was to be sent. There were a total of 13 different instances. Each instance had code to read the app.config settings, set the mail properties and send the email. A new SMTP server required SSL and we had to update all 13 instances. SO... why would the developers code this 13 times, instead of writing a simple static method/function??? We took the solution apart and found this "pattern" all over the place.. lots of cut/paste, hard coded values, etc... I am missing something? Is this something we have to get used to when dealing with outsourcing? I know.. lots of questions.. but some insight would be appreciated... thanks.
LM
It probably would be best to review the code yourself and make no compromises. Unfortunately, I am one of "them" and have seen stuff that would probably make any sane programmer want to shoot him(her)self, but I have also seen that the above method works. I would recommend trying that, if possible.
-
It probably would be best to review the code yourself and make no compromises. Unfortunately, I am one of "them" and have seen stuff that would probably make any sane programmer want to shoot him(her)self, but I have also seen that the above method works. I would recommend trying that, if possible.
강남풀싸롱 대표미녀 신세결실장 매직미러 후훗^^ 강남풀싸롱1위 PLAY
비용문의 : 미녀실장 신세경♡ ０１０-５９４６-５９１３
동종업계 최고상위권 수질최고!! 플레이
비즈니스 접대, 화끈한 술자리,
동창모임, 직원모임, 바이어접대 등...
어떠한 경우에도 컨셉을 맞춰드립니다~! ^^
미리 연락주시면 그에 맞는 수위로 시스템 조절해드릴게요^^
Hot Place 플레이~!- 룸타임 : 1시간 10분 > 침실 : 45분 - 8시전 이벤트가 적용 단체할인! (한분당 28만원씩!), 양주셋 맥주 음료 안주 무제한 - 8시이후 이벤트가 단체할인 (한분당 32만원씩!), 양주셋 맥주 음료 안주 무제한 믿을 수 있는^^ 미녀실장 신세경실장♡!! ０１０-５９４６-５９１３ ^^#강남풀싸롱신세경,#강남풀쌀롱,#강남풀싸롱,