Department of Redundancy Department

den2k88

AKA I found out that yeasterday I wrote a code like this

if (blnVariable == true) {
setVal(CODE, true);
} else {
setVal(CODE, false);
}

Luckily I got it before someone could shame me forever about it (including myself).

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

kmoorevs

Well, good job on finding it! Bad job at keeping it to yourself! :laugh: While we're telling secrets, I'll just mention that I spent an hour last night transposing javascript from a youtube video...thank goodness for multiple monitors! :laugh: btw, I found myself at least twice trying to copy text from the video...it was late in the day. :doh:

"Go forth into the source" - Neal Morse

Richard Deeming

Was blnVariable ever nullable? But then, even if it was, you could have just used:

setVal(CODE, blnVariable == true);

"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer

Munchies_Matt

Yeah, that bracket layout sucks! Shame on you!!! :mad:

den2k88

HEATHEN!!!!

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

den2k88

It's not, and I know precisely what I could have used :D I was probably just tired or distracted by my many other tasks.

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

raddevus

spoiler below... :-D Right? Right? :-\ I'm trying out for the Department of the Obvious -- I'm hoping to be a Captain! :laugh:

setVal(CODE, blnVariable);

den2k88

Yep, you are now promoted to Admiral Obvious :D

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

raddevus

I knew with hard work, gratuitous flattery and a monetary bribe I would eventually get the promotion. :laugh: ahem...I believe your forgot to upvote me. I may be forced to report you to the moderator. :rolleyes:

CPallini

Oh the gold old days of software paid per LOC. :-D

Foothill

Looks like you might have typed it exactly how you thought it...if this variable over here is true than this other variable has to set to true too.

if (Object.DividedByZero == true) { Universe.Implode(); } Meus ratio ex fortis machina. Simplicitatis de formae ac munus. -Foothill, 2016

Chris Maunder

Someone get this man a beer.

cheers Chris Maunder

den2k88

Using CP from smartphone is painful :D mainly because I write too much and I definetely can't write anything from a teeny tiny phone.

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

den2k88

CPallini wrote:

Oh the gold old days of software paid for

FTFY

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

raddevus

I will allow an exception this one time since you had a good excuse. :laugh:

David ONeil

Yeah, they are far better like this: if (blnVariable = true) { setVal(CODE, true); } else { setVal(CODE, false); }

The forgotten roots of science | C++ Programming | DWinLib

megaadam

That code looks like a pretty decent hangover!

... such stuff as dreams are made on

Dan Neely

If you've replaced that with:

setVal(CODE, bInVariable);

you've introduced a bug whenever `bInVariable` is equal to `FileNotFound`.

Did you ever see history portrayed as an old man with a wise brow and pulseless heart, weighing all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt

den2k88

Impossible as it is VisualBasic (I put it in C only to not hurt anyone sensibility) and not .NET (yes, tried and true VB6, that's what I have to work with) so it is a Boolean that can be only True or False and it is initialized to False. If there was such a possibility I would have kept the code as it was, of course.

GCS d-- s-/++ a- C++++ U+++ P- L+@ E-- W++ N+ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t+ 5? X R+++ tv-- b+(+++) DI+++ D++ G e++ h--- ++>+++ y+++* Weapons extension: ma- k++ F+2 X

obermd

Could you actually have written something else and realized you had "identical" code in both clauses of the if statement, leading to the obvious replacement with your function calls. You just hadn't made the next step yet.