MILLISEC_PER_SEC is never needed

[David Crow]

Yeah, overline works too.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles

[PIEBALDconsult]

I can't be bothered with such fiddling small change.

[Maximilien]

Oh please !!! DO IT!

I'd rather be phishing!

[Jorgen Andersson]

It's easier in Switzerland, they use septante, octante, nonante instead of soixante-dix, quatre-vingts, quatre-vingt-dix. In Belgium they use some bastardised version with septante, quatre-vingt, nonante IIRC.

Wrong is evil and must be defeated. - Jeff Ello

[Lost User]

Call it a feature? ;P

Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^]

[David ONeil]

Relatively speaking, without it, how could you ever know that your MILLISEC_PER_SEC doesn't match mine? :|

The forgotten roots of science | C++ Programming | DWinLib

[Joe Woodbury]

I actually disagree; I often deal with code using second, milliseconds, microseconds and even nanoseconds, sometimes with more than one unit in a function. Having a const (of some sort) declares what conversion was intended.

[Super Lloyd]

But what about ONE_SECOND_MS ?

A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!

[kalberts]

Constants ain't. Variables won't.

[kalberts]

But you wouldn't believe how many people talk about 'kWh per hour' Sure, it could be meaningful if the power varies, but then 'kWh per hour' might vary, too, and cannot be treated as a single value. And lots of people refer to kWh/hour even when the power is constant.

[kalberts]

But we really need a constant - or is that a variable? - ZEROES_IN_ONE_BILLION.

[PIEBALDconsult]

Like a dueling second?

[PIEBALDconsult]

Is that a leading question?

[kalberts]

Consider it as a "Constants ain't, varaiables won't" sample.

[PIEBALDconsult]

I suppose that's the long and short of it.

[Chris Maunder]

A counterargument. Excellent. My counter-counter argument, and the reason my brain popped: I would always prefer to have something like

var timeInSeconds = X;
var timeInMilliseconds = timeInSeconds / 1000;

My point is that the 1000 is always 1000. The variables surrounding that should be the ones clearly named. The "1000" can never be anything other than 1000. At least that's what I think.

cheers Chris Maunder

[Chris Maunder]

So: What if you then had

var kiloWattPerHourPerHour = X;
var kiloWattPerHourPerMinute = kiloWattPerHourPerHour / 60;

Should the 60 be a constant or a literal?

cheers Chris Maunder

[Joe Woodbury]

Aaaaggghhhh, Magic Number..... "It's supposed to be microseconds? Shit." (Near accurate quote.)

[Chris Maunder]

I blame the Brits for that one.

cheers Chris Maunder

[Chris Maunder]

<small pause> OK. That argument I will accept in that the number may appear in more than one place, making refactoring painful. Except, except, except: the calculation should only be done in one place:

var variable = ConvertToMilliFurlongs(X);

...

function ConvertToMilliFurlongs(furlongs)
{
return furlongs / 1000;
}

So if it's "Dammit, Janet. It should be microFurlongs" then you rename ConvertToMilliFurlongs to ConvertToMicroFurlongs and change the 1000 to 1000000. Everything's still clear.

cheers Chris Maunder