Holiday Season Fun Activity ... Not...

virang_21

Going through 400 code files and finding empty catch blocks and fixing them .... Try { // Number of code lines } Catch (Exception exception){ // Nothing here. Exception is swallowed. } Highly paid consultants probably enjoying a holiday season somewhere...:mad:

Zen and the art of software maintenance : rm -rf * Maths is like love : a simple idea but it can get complicated.

PIEBALDconsult

Regular Expressions ;P

Rajesh R Subramanian

virang_21 wrote:

Try { // Number of code lines } Catch (Exception exception){ // Nothing here. Exception is swallowed. }

Assuming that the code not wildly different than this, you could start with a simple regex replace with a blank string (PHP style, just use notepad++):

Try.*?Catch[^,;]*?\}

Update: I greatly simplified the regex ^-^, and also fixed a bug (the previous regex will match and erase any catch block that starts with a comment, but this one won't). What does it do?

If a catch block contains at least one semi-colon, then it's considered as a catch block with some valid code. Therefore, the entire try-catch is left alone.
If a catch block does not contain a semi-colon, the catch is erased, along with the try block that preceeds it (regardless of what's within the try).

Note: The regex will replace EVERY invalid try-catch block depending on the path and file extension selected in your replace in files dialog, so backing up your code beforehand might be a good idea! It should be fairly simple to modify to suit your needs if there's any difference. It replaced everything with an empty string except for the last block in my test cases:

Try {
do stuff
more stuff
blah
}
Catch (Exception exception){
// Nothing here. Exception is swallowed.
}

Try {

// Number of code lines
// Number of code lines
/*
frigging multi-line comment
spanning over many lines

*/
// Number of code lines
}
Catch (Exception exception){

// Nothing here. Exception is swallowed.
}

Try {
// Number of code lines
}
Catch (Exception exception){
// Nothing here. Exception is swallowed.
// blah
}

Try {
// Number of code lines
}
Catch (Exception exception){
//blah
int d = 3;
}

Rajesh R Subramanian

Ha, great minds and all. :-) OTOH, fools seldom differ either. :omg: