Programming peeve of the Day

Chris Maunder

Your rewrite is how it should be done. Now get off my lawn.

cheers Chris Maunder

Forogar

...erm, your code is not the same logic. You have inverted it.

- I would love to change the world, but they won’t give me the source code.

Lost User

I would never do it the same, but I can understand it as a hint and that is ok. Of course

if (condition) return;
// Do otherwhise

would be more appropriate On the other hand: Is it really worth to discuss such little things?

Lost User

Whehe, that's evil :D

Bastard Programmer from Hell :suss: "If you just follow the bacon Eddy, wherever it leads you, then you won't have to think about politics." -- Some Bell.

W Balboos GHB

Member 15092515 wrote:

On the other hand: Is it really worth to discuss such little things?

You're absolutely correct. Let's discuss this, instead: if (condition) { return; } else { // Do something else }

Ravings en masse^

"The difference between genius and stupidity is that genius has its limits." - Albert Einstein

"If you are searching for perfection in others, then you seek disappointment. If you seek perfection in yourself, then you will find failure." - Balboos HaGadol Mar 2010

Lost User

Ah ok I see you have a problem with 'if ... else' ;P [Edit] Is see in your profile "In real life, a research chemist." Yep, better stop programming. This because programming follow strict rules while chemistry has only exceptions ;P

PIEBALDconsult

Is snot.

if ( !condition )
{
// Do something else
}

return ;

NotTodayYo

Chris Maunder wrote:

Your rewrite is how it should be done.

Why? It's not as clear as to what the code will do. Plus, returning from inside an if is bad form.

Mike Hankey

Got it before I did! :)

The less you need, the more you have. JaxCoder.com

Maximilien

when you refactor some code and are too afraid to remove else clauses.

I'd rather be phishing!

realJSOP

I like single exit points... That code would drive me nuts too...

".45 ACP - because shooting twice is just silly" - JSOP, 2010
-----
You can never have too much ammo - unless you're swimming, or on fire. - JSOP, 2010
-----
When you pry the gun from my cold dead hands, be careful - the barrel will be very hot. - JSOP, 2013

Greg Utas

What's wrong with returning from inside an if? The rule about only returning at the end of a function leads to convoluted code where a flag is repeatedly used to bypass stuff just to reach the end of the function. Pure dross.

Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing.

Sander Rossel

No religion in the lounge! ;p

Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript

Mike Hankey

I believe to be totally proper it should be;

if ( !condition )
{
// Do something else
return;
}

return ;

The less you need, the more you have. JaxCoder.com

Lost User

hehe :thumbsup:

PIEBALDconsult

If I had a lawn... :mad:

NotTodayYo

Greg Utas wrote:

The rule about only returning at the end of a function leads to convoluted code

As opposed to it not being clear when and where something can be returned.

Mike Hankey

We have a saying here in the south; Hold my beer[^].

The less you need, the more you have. JaxCoder.com

Chris Maunder

You're asking if it's worth having a pointless whinge about something others do that's outside of one's control? What a silly question!

cheers Chris Maunder

Chris Maunder

Bonus points to JSOP! I actually like having two exit points at most 1st at the very top if your initial sanity checks on input parameters fail. Get that out of the qay early 2nd at the very end of the routine.

cheers Chris Maunder