how to write an approval for a code review
-
Southmountain wrote:
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose.
throw new NotImplementedException();Yup, that definitely requires comprehensive testing and validation! :laugh:Latest Article:
Create a Digital Ocean Droplet for .NET Core Web API with a real SSL Certificate on a Domain// panic!
abort();an old favorite. works as advertised. no obvious flaws. :laugh:
To err is human. Fortune favors the monsters.
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
Southmountain wrote:
I reviewed only one line of code for one business rule.
Delete this part. It completely invalidates your second sentence. If you worked for me, and I read this line in a code review, you'd be looking for work. A one line change usually has many unintended consequences, and a proper review requires a much more extensive analysis. No code change, nor any hardware change, lives in a vacuum; there are always other effects, and they can be very subtle. If you're willing to accept this review as your best work, stick with the second sentence, and be prepared to defend it.
Will Rogers never met me.
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
"Approved after review and testing".
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
I have no idea what system or process you use for your code reviews, but I don't write comments for approvals. I will do 10-20 code reviews per week, sometimes more, sometimes less. We use Azure DevOps Services | Microsoft Azure[^] and I usually only make comments if there are issues, but when I approve I just click the Approve button and that is it, no comments necessary.
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
If there are no comments for the review, we just approve the PR.
CI/CD = Continuous Impediment/Continuous Despair
-
Southmountain wrote:
I reviewed only one line of code for one business rule.
Delete this part. It completely invalidates your second sentence. If you worked for me, and I read this line in a code review, you'd be looking for work. A one line change usually has many unintended consequences, and a proper review requires a much more extensive analysis. No code change, nor any hardware change, lives in a vacuum; there are always other effects, and they can be very subtle. If you're willing to accept this review as your best work, stick with the second sentence, and be prepared to defend it.
Will Rogers never met me.
this part is only put here for explaining info here. not on my approval. your feedback is highly appreciated.:rose::rose::rose:
diligent hands rule....
-
I have no idea what system or process you use for your code reviews, but I don't write comments for approvals. I will do 10-20 code reviews per week, sometimes more, sometimes less. We use Azure DevOps Services | Microsoft Azure[^] and I usually only make comments if there are issues, but when I approve I just click the Approve button and that is it, no comments necessary.
my approval is written in an email to reply to developer's request. this email will be saved and embed into BRD document.
diligent hands rule....
-
my approval is written in an email to reply to developer's request. this email will be saved and embed into BRD document.
diligent hands rule....
your code review system uses email as its method of communication? I don't want to know the answer. :sigh:
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
A coworker always uses "Works as coded".
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.
-
I reviewed only one line of code for one business rule. I did comprehensive testing and validation, and I think this code change meets the purpose. what is the better statement to wrap up my approval? any good words to recommend?
diligent hands rule....
"No concerns".
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
-
A coworker always uses "Works as coded".
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.
-
A coworker always uses "Works as coded".
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.
I will use similar words to this statement:thumbsup:
diligent hands rule....
-
"No concerns".
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
this may not be regarded as an approval :laugh:
diligent hands rule....