Coding Pet Peeves
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
1.2.3.YES
Give me coffee to change the things I can and wine for those I can not! PartsBin an Electronics Part Organizer - An updated version available! JaxCoder.com Latest Article: Simon Says, A Child's Game
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
Kevin Marois wrote:
I just can stand it when someone doesn't use braces in IF statements:
For me, that's acceptable... as long as the rest of the code is formatted well. Especially for stuff that's terse in nature like
if (!blah) return;at the start of a routine. But it would have to be something short and simple.Kevin Marois wrote:
What bugs you when you see someone else's code?
If we harken back to the first point... when folks don't use spacing properly. Code should read like text. And in English we have paragraphs. When I see large code files with no blank lines... I mean... what?
// bro... what
function checkout(goodsPrice, shipmentPrice, taxes) {
const total = goodsPrice + shipmentPrice + taxes;
const para = document.createElement("p");
para.textContent = `Total price is ${total}`;
document.body.appendChild(para);
}// paragraphs logically separate ideas, so should code
function checkout(goodsPrice, shipmentPrice, taxes) {
const total = goodsPrice + shipmentPrice + taxes;
const para = document.createElement("p");para.textContent = `Total price is ${total}`;
document.body.appendChild(para);
}Jeremy Falcon
-
#3 most definitely, #1 less so. Empty 'catch' blocks, ran into that fairly recently...:mad::mad::mad:
"the debugger doesn't tell me anything because this code compiles just fine" - random QA comment "Facebook is where you tell lies to your friends. Twitter is where you tell the truth to strangers." - chriselst "I don't drink any more... then again, I don't drink any less." - Mike Mullikins uncle
Funny enough, for JavaScript it's the exact opposite for #3. My peeve would be not using 1TBS for JavaScript/Typescript. There's actually a technical reason why, but now it's just so ingrained. And it's easy to spot a JavaScript rookie vs a pro if they try and format it like C#. Totally agree about the empty catch blocks though. Even in JS.
Jeremy Falcon
-
Item 1 is just evil. Item 2 - it's xaml. It's not code ;) Item 3 - I prefer braces to be on the line below, but it's just habit. damned if I know where I picked up on that. I just don't think the opening brace on the same line is clear. But that is my preference. I know other folks that go BSC if the brace is under the if...
Charlie Gilley “They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759 Has never been more appropriate.
charlieg wrote:
Item 3 - I prefer braces to be on the line below, but it's just habit. damned if I know where I picked up on that. I just don't think the opening brace on the same line is clear. But that is my preference. I know other folks that go BSC if the brace is under the if...
Except in JavaScript (I realize the OP is C#... just saying) there's a legit reason to not use a new line for the brace.
Jeremy Falcon
-
Use of literal values annoys me a lot. Especially when that hard-coded value needs to be changed.
"They have a consciousness, they have a life, they have a soul! Damn you! Let the rabbits wear glasses! Save our brothers! Can I get an amen?"
That's a good one. Especially if that literal is used more than once...
Jeremy Falcon
-
Funny enough, for JavaScript it's the exact opposite for #3. My peeve would be not using 1TBS for JavaScript/Typescript. There's actually a technical reason why, but now it's just so ingrained. And it's easy to spot a JavaScript rookie vs a pro if they try and format it like C#. Totally agree about the empty catch blocks though. Even in JS.
Jeremy Falcon
Agreed with the opening brace placement in JS/TS vs C#. I've done *very* little JS, but this is something I've quickly adopted, despite doing the opposite in C#. If I see an opening brace on a line on its own in JS, it just looks wrong to me. Somehow I can manage do the context switch in C# as if it was second nature, which is just as well, otherwise I'd really get stuck on this sort of thing. Coding standards are weird. It's just as well there's so many of them.............
-
charlieg wrote:
Item 3 - I prefer braces to be on the line below, but it's just habit. damned if I know where I picked up on that. I just don't think the opening brace on the same line is clear. But that is my preference. I know other folks that go BSC if the brace is under the if...
Except in JavaScript (I realize the OP is C#... just saying) there's a legit reason to not use a new line for the brace.
Jeremy Falcon
Clicked on the link, read what was said there and pondered for a minute. I've decided that is one of the dumber language decisions I've ever seen.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
-
Agreed with the opening brace placement in JS/TS vs C#. I've done *very* little JS, but this is something I've quickly adopted, despite doing the opposite in C#. If I see an opening brace on a line on its own in JS, it just looks wrong to me. Somehow I can manage do the context switch in C# as if it was second nature, which is just as well, otherwise I'd really get stuck on this sort of thing. Coding standards are weird. It's just as well there's so many of them.............
dandy72 wrote:
Somehow I can manage do the context switch in C# as if it was second nature
That's a sign of a good coder actually. Like with JS, there's a technical reason. Being able to let go of things (if there's a good reason) is a good thing. Like for instance, I love camel case. But, I doubt that would fly in Rust.
dandy72 wrote:
Coding standards are weird. It's just as well there's so many of them.............
Preach.
Jeremy Falcon
-
Clicked on the link, read what was said there and pondered for a minute. I've decided that is one of the dumber language decisions I've ever seen.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
MarkTJohnson wrote:
I've decided that is one of the dumber language decisions I've ever seen.
People that dismiss JavaScript really just don't know it. Yes, it started off quickly/rushed, but it's come a long way. It's different. It's both functional and OOP. Nothing more. Nothing less. I think it's a great language, minus a few little quirks... which most languages have. It started off being web centric, so it has historic "issues" from that like ASI. Most web languages are script kiddie friendly, but JavaScript/ECMAScript has come a long, long way. I can promise you that most issues with the language is more so due to it being popular and 99% of people really knowing nothing about it. Not to mention, it's fast. Really fast, thanks to the optimizations over the years. Of course, not Rust/C++/C# fast... but it's one of the fastest scripting languages out there.
Jeremy Falcon
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
It's not exactly code, but comment boxes in the form of complete rectangles. The pinheads who originally drew them presumably believed that other people adding comments in the box would bother to keep its right-hand border nicely aligned. Not to mention that many of those comments provided a revision history for even the most trivial changes when, even in 1981, we had a source code management system that provided a full history, so that you could see who made each change, why, and get a diff between whichever versions you wanted.
Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing. -
MarkTJohnson wrote:
I've decided that is one of the dumber language decisions I've ever seen.
People that dismiss JavaScript really just don't know it. Yes, it started off quickly/rushed, but it's come a long way. It's different. It's both functional and OOP. Nothing more. Nothing less. I think it's a great language, minus a few little quirks... which most languages have. It started off being web centric, so it has historic "issues" from that like ASI. Most web languages are script kiddie friendly, but JavaScript/ECMAScript has come a long, long way. I can promise you that most issues with the language is more so due to it being popular and 99% of people really knowing nothing about it. Not to mention, it's fast. Really fast, thanks to the optimizations over the years. Of course, not Rust/C++/C# fast... but it's one of the fastest scripting languages out there.
Jeremy Falcon
Replying/preaching 6 times in one these types of threads - interesting. Trying to defend javascript - priceless.
-
Replying/preaching 6 times in one these types of threads - interesting. Trying to defend javascript - priceless.
Slacker007 wrote:
Trying to defend javascript - priceless.
:laugh: :laugh: :laugh: Always man.
Jeremy Falcon
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
I would take offense to #1 and #2, but not #3. I use the K&R style of bracing. /ravi
My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
I have enough trouble with my own code... :sigh:
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
#1 and #3, except #3 is the style for JavaScript/TypeScript, so I have to live with it. :( #2 - I don't do XAML but yes, I would agree.
Latest Articles:
A Lightweight Thread Safe In-Memory Keyed Generic Cache Collection Service A Dynamic Where Implementation for Entity Framework -
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
Position first attribute on same line as start tag."Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
I program in VB6..... so none of this matters!!! :-D :-D :-D
-
1. I just can stand it when someone doesn't use braces in IF statements:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) Console.WriteLine("line1") ; Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
2. XAML where the code is all on one line! (This is all on one line!)
3. First brace not on a new line:
static void Main(string[] args)
{
bool isTrue = false;if (isTrue) { Console.WriteLine("line1"); } Console.WriteLine("line2"); Console.WriteLine("line3"); Console.ReadLine();}
What bugs you when you see someone else's code?
In theory, theory and practice are the same. But in practice, they never are.” If it's not broken, fix it until it is. Everything makes sense in someone's mind.
I just follow the house coding standards whatever they are, which just ensures the coding style is consistent across the department. I am not a fan of one line
ifstatements unless the statement is on the same line as the condition.“That which can be asserted without evidence, can be dismissed without evidence.”
― Christopher Hitchens
