Don’t refactor like Uncle Bob. Please
-
Read the article, author has some good points. One thing I would have done was use a switch over a bunch of if/else's. Author's refactor of the original is also something I would approve. Not that anyone was asking.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
-
Read the article, author has some good points. One thing I would have done was use a switch over a bunch of if/else's. Author's refactor of the original is also something I would approve. Not that anyone was asking.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
I was in a car with several greenhorns. One of them said they were in it for the precision. Like math. As though there were explicitly correct answers/ways of getting things done. I found that humorous but couldn't really explain to them why. I feel like the segment of our tribe which came by similar footsteps as that line of thinking though... Upon discovering it doesn't really exist, they set about construction of these various frameworks for perfection and pedantry. Like facades built for personal security these guardrails protecting from the great unknown. It's not all at all bad. It's only the purists I can't stomach. We can entertain "true TDD" or whatever we want from a theoretical/discussion sort of stance. That's awesome. However, I think for some purists this is explicitly antithetical to their puritanical goal of nailing down the 'one right answers' and then never thinking about them or discussing them again.
-
Read the article, author has some good points. One thing I would have done was use a switch over a bunch of if/else's. Author's refactor of the original is also something I would approve. Not that anyone was asking.
I’ve given up trying to be calm. However, I am open to feeling slightly less agitated. I’m begging you for the benefit of everyone, don’t be STUPID.
I'm not sure I agree with most of the points made. In my 35 years of writing software, I have _never_ seen code anally refactored to stupid silly functions. Does this really help understanding? Supportability? I'd say meh.
private void createPluralDependentMessageParts(int count) {
if (count == 0) {
thereAreNoLetters();
} else if (count == 1) {
thereIsOneLetter();
} else {
thereAreManyLetters(count);
}
}Ten days until my retirement sabbatical, but the opening brace on every function or conditional drives me to drink. And yes, I know that's a religious argument. Sure, you save one line on the page, but it just seems to make the code compressed and hard to scan.
Charlie Gilley “They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759 Has never been more appropriate.