Code Reviews
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
If the critisms are valid and constructive, it's a great tool; if the "reviewee" (sp?) never learns from what the reviewer tells him, well, the reviewer can be more harsh in his comments. if should go both ways.
Maximilien Lincourt Your Head A Splode - Strong Bad
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
which code ?
I'll write a suicide note on a hundred dollar bill - Dire Straits
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
I've been there, it's very painful to constantly receive criticism. I have confronted this person which worked a little. I have also found this person quite knowledgable and give him credit when I can. I have learned many things from him and remember that when I can. Trying to maintain objectivity and gratitude where possible. What has worked form is finding support from other developers, using them for reviews when possible. Also using them to vent when this person has attacked your work again. Josef Wainz Software Developer
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
I found code reviews to be very useful. However, we always include at least two reviewers and a moderator - it is never "one on one" thing. And it is moderator's duty to keep reviews civil, short and non personal.
-
I found code reviews to be very useful. However, we always include at least two reviewers and a moderator - it is never "one on one" thing. And it is moderator's duty to keep reviews civil, short and non personal.
-
I found code reviews to be very useful. However, we always include at least two reviewers and a moderator - it is never "one on one" thing. And it is moderator's duty to keep reviews civil, short and non personal.
Nemanja Trifunovic wrote: always include at least two reviewers and a moderator - it is never "one on one" thing. This is usually the single reason for code reviews to fail. Formals reviews that I have been part of used to be made up of five people. Two coders from the group that produced the work being reviewed, two coders from a separate group that have nothing to do with the project and a moderator who was usually a project manager but again not for the project that the reviewed code was part of. This arrangement always kept things very objective and non-personal. This arrangement also led to a lot of cross project synergies that no management type could have ever predicted. :) Chris Meech I am Canadian. [heard in a local bar] I think people should be required to have an operator's permit to use the internet. John Simmons
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
They can work, but as others have noted, get small-ish group, but not just one-on-one. The review should focus on substantial stuff, not nit-picky things like "hey, you forgot a space here" and the like. (Any code-formatting tool can fix those problems.) However, if a reviewer criticizes code because it is hard to read/understand, or if it usese questionable logic, or finds places where you new but forget to delete, that is good information to know, and can improve your code. "Fish and guests stink in three days." - Benjamin Franlkin
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
...especially for the one who is famous for being judgemental and known for blatant criticism. They can work well when the climate is ok - the reviewers have decent teaching skills, and th reviewee can accept criticism. the two-to-one idea sounds good because it eliminates the big trouble in most scenarios (however, not all of them).
we are here to help each other get through this thing, whatever it is Vonnegut jr.
mlog || Agile Programming | doxygen -
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
I think everyone will agree that code reviews are generally very good for code quality tracking and knowledge distribution, but only when there is a fair distribution of programmers involved. Otherwise you will get the situation you described where one may be heavy handed on the other. Unfortunately for me there aren't enough coders here to contitute such a quota. :sigh: srt7 wrote: when one is famous for being judgemental and known for blatant criticism? ..and stop talking about me behind my back! :~
I Dream of Absolute Zero
-
What's you view on code reviews between two developers especially when one is famous for being judgemental and known for blatant criticism? Regards, SRT
I've always gotten good feedback from code reviews both reviewing and getting reviewed, but I've never done a formal 1x1 review. They are a great way to share knowlege as long as all parties are commited. Some things that I've found useful, cut it off after an hour at the longest. Reschedule if you have larger chunks to cover. Don't have a code review unless you have time to make the changes. It's frustrating to make recomendations and then find the original code go straight to production. Make sure all parties have time to look over the code ahead of time. One way to do that is make sure everybody brings their own printouts. As with any development process changes, make sure you can estimate how effective the process is. Not every process works for every group. You need to find out what is most effective for your team and keep building off of that.
If you don't kill me you will only make me stronger That and a cup of coffee will get you 2 cups of coffee