First real one...
-
When I was first learning C#, I had an attitude about it. I was hardcore C++ before that. Now, I love C#, but anyhow... So, I was writing a unit test, and I needed to have every third item do something in a list. I forget what. I knew about Math., and I looked for Math.Mod. Obviously, it's not there, it's the % operator. Which I should have known. But, I was having a bad day, and, cursing C#, I wrote my own mod function. A year or so later, this code was found by someone and sent to the entire company on our social mailing list. I knew right away what I'd done, and I'm glad it happened ( what I did was atypical at the time, but now I'd all the more remember it and dig deeper for obvious stuff that isn't where I first look for it ), but I sure did feel a goose when I saw it and realised that what I wrote was superfluous. C# was my first major language change ( I'd done Python and other stuff, but always C++ at the core, C# was my first change of core language ). I suspect I was a case study for how NOT to approach such a major change. Hopefully the next time things change like that, I'll take it better. I guess the other lesson to be learned out of this is the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
Christian Graus - Microsoft MVP - C++ Metal Musings - Rex and my new metal blog "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )
-
When I was first learning C#, I had an attitude about it. I was hardcore C++ before that. Now, I love C#, but anyhow... So, I was writing a unit test, and I needed to have every third item do something in a list. I forget what. I knew about Math., and I looked for Math.Mod. Obviously, it's not there, it's the % operator. Which I should have known. But, I was having a bad day, and, cursing C#, I wrote my own mod function. A year or so later, this code was found by someone and sent to the entire company on our social mailing list. I knew right away what I'd done, and I'm glad it happened ( what I did was atypical at the time, but now I'd all the more remember it and dig deeper for obvious stuff that isn't where I first look for it ), but I sure did feel a goose when I saw it and realised that what I wrote was superfluous. C# was my first major language change ( I'd done Python and other stuff, but always C++ at the core, C# was my first change of core language ). I suspect I was a case study for how NOT to approach such a major change. Hopefully the next time things change like that, I'll take it better. I guess the other lesson to be learned out of this is the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
Christian Graus - Microsoft MVP - C++ Metal Musings - Rex and my new metal blog "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )
Christian Graus wrote:
the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
I've floated that idea and the response has been it would be wonderful to do, but we don't have the time.
Upcoming events: * Glasgow: Geek Dinner (5th March) * Edinburgh: Web Security Conference Day for Windows Developers (12th April) My: Website | Blog | Photos
-
Christian Graus wrote:
the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
I've floated that idea and the response has been it would be wonderful to do, but we don't have the time.
Upcoming events: * Glasgow: Geek Dinner (5th March) * Edinburgh: Web Security Conference Day for Windows Developers (12th April) My: Website | Blog | Photos
Colin Angus Mackay wrote:
I've floated that idea and the response has been it would be wonderful to do, but we don't have the time.
The response back should be: How much time have we spent doing things over because they weren't done right the first time? A code review would have prevented that.
----------------------------- In just two days, tomorrow will be yesterday.
-
Christian Graus wrote:
the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
I've floated that idea and the response has been it would be wonderful to do, but we don't have the time.
Upcoming events: * Glasgow: Geek Dinner (5th March) * Edinburgh: Web Security Conference Day for Windows Developers (12th April) My: Website | Blog | Photos
Colin Angus Mackay wrote:
...but we don't have the time.
It's amazing how many companies find time to redo something, though. "We don't have time to do it correct up front, but we have plenty of time to fix it on the backend."
"Approved Workmen Are Not Ashamed" - 2 Timothy 2:15
"Judge not by the eye but by the heart." - Native American Proverb
-
When I was first learning C#, I had an attitude about it. I was hardcore C++ before that. Now, I love C#, but anyhow... So, I was writing a unit test, and I needed to have every third item do something in a list. I forget what. I knew about Math., and I looked for Math.Mod. Obviously, it's not there, it's the % operator. Which I should have known. But, I was having a bad day, and, cursing C#, I wrote my own mod function. A year or so later, this code was found by someone and sent to the entire company on our social mailing list. I knew right away what I'd done, and I'm glad it happened ( what I did was atypical at the time, but now I'd all the more remember it and dig deeper for obvious stuff that isn't where I first look for it ), but I sure did feel a goose when I saw it and realised that what I wrote was superfluous. C# was my first major language change ( I'd done Python and other stuff, but always C++ at the core, C# was my first change of core language ). I suspect I was a case study for how NOT to approach such a major change. Hopefully the next time things change like that, I'll take it better. I guess the other lesson to be learned out of this is the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
Christian Graus - Microsoft MVP - C++ Metal Musings - Rex and my new metal blog "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )
Having been through several code reviews over the past few years, they do help so long as the people involved in the review understand the objective of the code and its context. Sometimes, major problems are avoided by this process. However, there will be one or more persons involved in the review who consider formatting more important than the functionality. Phil
-
Christian Graus wrote:
the importance of code reviews, which this particular company does not do, to this day ( I floated it once or twice and got laughed to scorn ).
I've floated that idea and the response has been it would be wonderful to do, but we don't have the time.
Upcoming events: * Glasgow: Geek Dinner (5th March) * Edinburgh: Web Security Conference Day for Windows Developers (12th April) My: Website | Blog | Photos
Code Complete has real-world statistics on which techniques spot the most defects. Code Reviews win (with the suggestion that just reading code by different people do the trick for defect finding). And empirical evidence that Increasing QA cost does usually not increase overall cost.
Developers, Developers, Developers, Developers, Developers, Developers, Velopers, Develprs, Developers!
We are a big screwed up dysfunctional psychotic happy family - some more screwed up, others more happy, but everybody's psychotic joint venture definition of CP
Linkify!|Fold With Us!