When feeling dumb...
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
One thing you might want to check out is when to use a period. Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
¡El diablo está en mis pantalones! ¡Mire, mire! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! Personal 3D projects Just Say No to Web 2 Point Blow
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
talk to the reviewer and peers, and try to find out what actually the expectations are.
It is Good to be Important but! it is more Important to be Good
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
I would hardly rate "WTF" as a code review. More of an unbalanced criticism. Is your boss as experienced with the development cycle / platform / language? Or are they from a different background and you're the expert? For coding quality, I follow the standards laid out. If there are no standards, call a meeting or drop an email to whomever to try and get some guidelines set out. I continually review what I've done and try to take criticism of my code in a constructive manner. Do I find myself having to justify my methods sometimes, yes. But, if they're wrong, I learn something, if they're right I can explain myself. Is your boss looking for a reason to get rid of you?
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
emiaj wrote:
for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on
Do you work in the same company I work for ? We have such people here who we could do without. But seriously when you are doing it wrong, you hardly ever know it. And if the boss doesn't like your code, then you better start improving it. Learning from other people's code in the team does help. Choose the code that has the least number of WTF's per page. Write short, easy to understand code. Write it so it can be verified just by reading it. Write it so the code reads like poetry, not like a newspaper, or your post above.
NULL
-
I would hardly rate "WTF" as a code review. More of an unbalanced criticism. Is your boss as experienced with the development cycle / platform / language? Or are they from a different background and you're the expert? For coding quality, I follow the standards laid out. If there are no standards, call a meeting or drop an email to whomever to try and get some guidelines set out. I continually review what I've done and try to take criticism of my code in a constructive manner. Do I find myself having to justify my methods sometimes, yes. But, if they're wrong, I learn something, if they're right I can explain myself. Is your boss looking for a reason to get rid of you?
hammerstein05 wrote:
s your boss as experienced with the development cycle / platform / language? Or are they from a different background and you're the expert?
He definitely has a lot of design skills (not in the photoshop or dreamweaver aspect, I'm talking about the of designing software), and yes, I would call him the expert. Some times what I do is "too simple" others is "too complex".
hammerstein05 wrote:
Is your boss looking for a reason to get rid of you?
I don't think so, I've felt always good with him and all, is the fact that lately I've not been very productive and my work is always subject of being redone, even if I give the best of me (which seems to not be enough). Anyways, thanks for your advice, I suppose I should just stop bitching about it and just do it right. Have a nice day.
-
One thing you might want to check out is when to use a period. Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
¡El diablo está en mis pantalones! ¡Mire, mire! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! Personal 3D projects Just Say No to Web 2 Point Blow
Jim Crafton wrote:
Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
So if they question your code you run them through with a weapon?! ...I find your ideas intriguing and wish to sign up for your newsletter.
If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.
-
Jim Crafton wrote:
Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
So if they question your code you run them through with a weapon?! ...I find your ideas intriguing and wish to sign up for your newsletter.
If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.
ragnaroknrol wrote:
So if they question your code you run them through with a weapon?!
Not immediately. I offer them the chance to challenge me. However most walk away in cowardly shame, nothing but p'tahk BiHnuch.
¡El diablo está en mis pantalones! ¡Mire, mire! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! Personal 3D projects Just Say No to Web 2 Point Blow
-
emiaj wrote:
for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on
Do you work in the same company I work for ? We have such people here who we could do without. But seriously when you are doing it wrong, you hardly ever know it. And if the boss doesn't like your code, then you better start improving it. Learning from other people's code in the team does help. Choose the code that has the least number of WTF's per page. Write short, easy to understand code. Write it so it can be verified just by reading it. Write it so the code reads like poetry, not like a newspaper, or your post above.
NULL
Mechanical wrote:
But seriously when you are doing it wrong, you hardly ever know it.
Exactly!
Mechanical wrote:
And if the boss doesn't like your code, then you better start improving it. Learning from other people's code in the team does help.
What to do when the team is just he and me :) (at least for this project), other projects in the same company aren't green at all, so as you could imagine, they don't have the bar as high as this one but I wouldn't call them bad in terms of coding standards or inner quality, just the fact that this one it seems it requires a super-star developer :). I've been told to take a look at some open source projects from Jeremy Miller (fubumvc), I'm doing that right now, the level of complexity is way out of my league, but I'm doing the effort, though.
Mechanical wrote:
Write short, easy to understand code. Write it so it can be verified just by reading it. Write it so the code reads like poetry, not like a newspaper, or your post above.
I definitely will follow your suggestions. Have a nice day and thanks for your advice.
-
ragnaroknrol wrote:
So if they question your code you run them through with a weapon?!
Not immediately. I offer them the chance to challenge me. However most walk away in cowardly shame, nothing but p'tahk BiHnuch.
¡El diablo está en mis pantalones! ¡Mire, mire! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! Personal 3D projects Just Say No to Web 2 Point Blow
Under ordinary ciscumstances I would attempt to make some kind of joke to this. However, I fear anyone that uses Klingon, cause they are usually disturbed. I will just give you a 5 instead.
If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.
-
Mechanical wrote:
But seriously when you are doing it wrong, you hardly ever know it.
Exactly!
Mechanical wrote:
And if the boss doesn't like your code, then you better start improving it. Learning from other people's code in the team does help.
What to do when the team is just he and me :) (at least for this project), other projects in the same company aren't green at all, so as you could imagine, they don't have the bar as high as this one but I wouldn't call them bad in terms of coding standards or inner quality, just the fact that this one it seems it requires a super-star developer :). I've been told to take a look at some open source projects from Jeremy Miller (fubumvc), I'm doing that right now, the level of complexity is way out of my league, but I'm doing the effort, though.
Mechanical wrote:
Write short, easy to understand code. Write it so it can be verified just by reading it. Write it so the code reads like poetry, not like a newspaper, or your post above.
I definitely will follow your suggestions. Have a nice day and thanks for your advice.
I hope your project needs something that complex. If it is a simple one person project I can see why you are struggling. Going full on TDD with IOC and all that for a simple project will get you something like http://kigg.codeplex.com/[^]. Building a simple app with all that overhead is like crushing an egg with a battleship.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
-
I hope your project needs something that complex. If it is a simple one person project I can see why you are struggling. Going full on TDD with IOC and all that for a simple project will get you something like http://kigg.codeplex.com/[^]. Building a simple app with all that overhead is like crushing an egg with a battleship.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
-
Under ordinary ciscumstances I would attempt to make some kind of joke to this. However, I fear anyone that uses Klingon, cause they are usually disturbed. I will just give you a 5 instead.
If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.
ragnaroknrol wrote:
I will just give you a 5 instead.
Coward! /*duck & run*/
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
-
A cutting edge CMS is the goal. Btw, thanks for the link, I wasn't aware of such project, it may worth take a look and learn some new tricks. Kind regards....
emiaj wrote:
A cutting edge CMS is the goal.
Ok, I can see the need then. However, there are a ton of them out there already. Is this just your boss scratching an itch and building the one true CMS to rule them all, or is there some real functionality that isn't there already?
emiaj wrote:
Btw, thanks for the link, I wasn't aware of such project, it may worth take a look and learn some new tricks.
This is probably a better list: http://www.tampadev.org/News/Details/ASPNETMVCSampleApplicationsOpenSourceExamplesTutorials[^] I downloaded Kigg to modify and learn MVC. I figured it would be a good place to start, and I immediately started drowning in a morass of tightly coupled classes and xml configuration. To add one new object type, you have to end up modifying 5 projects and xml files adding a related class to each one. All that kicks in before you even start writing tests for your new class. The plumbing to application ratio is astronomical, the guys that wrote that have a real architecturalization fetish.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
-
Hi there, I'm facing such a problem at work... All started a couple of weeks ago, the project I'm currently working on is a green project, my boss have envisioned a great architecture and it seems that I'm not doing it right lately, in the beginning there were some bad times but almost always I came up with something that made him feel comfortable with the project cycle, currently for the past few weeks every time he makes a code review I get the code all full of comments like "THIS IS A MESS", "WTF" and so on, I never liked to be a disposable member in any team I've participated before and I've no plans to become one of those...my question is...what do you guys do in order to keeping always up your reputation or coding quality? I kinda started to feel lost and with such a "check-in" fear because I know something terrible it's going to happen :p
You are living the impression, that you are not entirely confident in your own skills and code quality. If it’s so start reviewing your boss’ code and try to figure out how he solves the problems.
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
-
emiaj wrote:
A cutting edge CMS is the goal.
Ok, I can see the need then. However, there are a ton of them out there already. Is this just your boss scratching an itch and building the one true CMS to rule them all, or is there some real functionality that isn't there already?
emiaj wrote:
Btw, thanks for the link, I wasn't aware of such project, it may worth take a look and learn some new tricks.
This is probably a better list: http://www.tampadev.org/News/Details/ASPNETMVCSampleApplicationsOpenSourceExamplesTutorials[^] I downloaded Kigg to modify and learn MVC. I figured it would be a good place to start, and I immediately started drowning in a morass of tightly coupled classes and xml configuration. To add one new object type, you have to end up modifying 5 projects and xml files adding a related class to each one. All that kicks in before you even start writing tests for your new class. The plumbing to application ratio is astronomical, the guys that wrote that have a real architecturalization fetish.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
We do have a cms product already being used by several companies, we want a better one :)
Andy Brummer wrote:
I downloaded Kigg to modify and learn MVC. I figured it would be a good place to start, and I immediately started drowning in a morass of tightly coupled classes and xml configuration. To add one new object type, you have to end up modifying 5 projects and xml files adding a related class to each one. All that kicks in before you even start writing tests for your new class. The plumbing to application ratio is astronomical, the guys that wrote that have a real architecturalization fetish.
:s, hope ours do not end up as something like that :D, seriously, our goal is to have a highly testable cms (thus, the suggestion of checking fubumvc from my boss) without adding too much complexity. Who knows, I may be posting here our final results :)
-
Jim Crafton wrote:
Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
So if they question your code you run them through with a weapon?! ...I find your ideas intriguing and wish to sign up for your newsletter.
If I have accidentally said something witty, smart, or correct, it is purely by mistake and I apologize for it.
Klingons and Simpsons in a single posting. Mo nerds in here, folks. Move on. Nothing to see.
I wanna be a eunuchs developer! Pass me a bread knife!
-
One thing you might want to check out is when to use a period. Other than that I simply use the Klingon rules of coding and challenge anyone to a Bat'leth contest.
¡El diablo está en mis pantalones! ¡Mire, mire! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! Personal 3D projects Just Say No to Web 2 Point Blow
I know this has to have been posted here before, but I could not resist... :) http://www.klingon.org/resources/klingon_code.html[^]
WE ARE DYSLEXIC OF BORG. Refutance is systile. Your a$$ will be laminated. There are 10 kinds of people in the world: People who know binary and people who don't.