JavaScript Conditional

[Andres Martin]

Hi, this is my post! :S

function GoPage(accion)
{
if(accion == "G")
window.location.href = 'resultadointerfaz.asp?vyear='+ document.getElementById('Select2').value+'&vmes='+document.getElementById('Select1').value+'&tipo='+document.getElementById('tipo').value+'&consultar=G';
else
window.location.href = 'resultadointerfaz.asp?vyear='+ document.getElementById('Select2').value+'&vmes='+document.getElementById('Select1').value+'&tipo='+document.getElementById('tipo').value+'&consultar=C';
}

What do you think. I think that the else is not necesary! bye!

[Luc Pattyn]

there is a 1-letter difference near the end! :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use < PRE > tags for code snippets, it preserves indentation, and improves readability.

modified on Wednesday, June 23, 2010 7:41 PM

[oggenok64]

Good spotting. I missed that.

[Kevin Drzycimski]

yes there is =D but the whole function could be written better, with regard to DRY

[Viorel]

Since setting of href does not necessary stop the scripts and jump to new address, I think that else is required. But the code can be probably replaced with a single line like this:

window.location.href = "...&consultar=" + accion;

[Jeroen De Dauw]

Obviously a genetic algorithm should be used to evolve the URL, why can't some programmers figure that out? >_>

Jeroen De Dauw
Blog ; Wiki

[Tsuda Kageyu]

We love copy and paste.

[whatrevolution]

I think: function GoPage(accion) { if (accion == "G") { consultar_val = G; } else { consultar_val = C; } window.location.href = 'resultadointerfaz.asp?vyear='+document.getElementById('Select2').value+'&vmes='+document.getElementById('Select1').value+'&tipo='+document.getElementById('tipo').value+'&consultar='+consultar_val; }

Honestly Illustrated

<Pretentious> Raid tha manyuhl. :E <Pretentious> Aw raid eh own mah meaxbile. :E

[Lutoslaw]

Controls' names Select1 and Select2 are another horror.

Greetings - Jacek

[whatrevolution]

<select id="Select4"><option>Bad Idea></option></select> <select id="Select2"><option>Bad idea></option></select> <select id="Select7"><option>bad Idea></option></select> <select id="Select5"><option>bad idea></option></select> <select id="Select1"><option>BadIdea></option></select> <select id="Select6"><option>badIdea></option></select> <select id="Select3"><option>Bad_Idea></option></select> <select id="Select8"><option>bad_idea></option></select>

Honestly Illustrated

<Pretentious> Raid tha manyuhl. :E <Pretentious> Aw raid eh own mah meaxbile. :E

[Electron Shepherd]

If action is, for example, 'X', your function works differently to the original

Server and Network Monitoring

[jsc42]

Or, simpler:

function GoPage(accion)
{
window.location.href =
'resultadointerfaz.asp?vyear=' +
document.getElementById('Select2').value +
'&vmes=' +
document.getElementById('Select1').value +
'&tipo=' +
document.getElementById('tipo').value +
'&consultar=' +
(accion == 'G' ? 'G' : 'C');
}

[whatrevolution]

I wanted to use the ternary operator there, too; then I thought of the future case of adding a third "accion" and decided to leave an obvious ability to add an "else if" condition at the top.

Honestly Illustrated

<Pretentious> Raid tha manyuhl. :E <Pretentious> Aw raid eh own mah meaxbile. :E