Monday morning excellence...

Iain Clarke Warrior Programmer

Spot the mistake...

cb->SetWindowText ("pSettings->sColName");

Even VS's editor's colourising didn't help. I did spot it in testing though, so some dignity was salvaged. Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Nagy Vilmos

Iain Clarke, Warrior Programmer wrote:

Spot the mistake.

You're not using VB6? :-D [Vilmos runs and hides]

Panic, Chaos, Destruction. My work here is done. Drink. Get drunk. Fall over - P O'H OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre I cannot live by bread alone. Bacon and ketchup are needed as well. - Trollslayer Have a bit more patience with newbies. Of course some of them act dumb - they're often *students*, for heaven's sake - Terry Pratchett

realJSOP

Well, the quotes make it hard to get to the indicated pointer, but other than that, it looks fine (assuming you're using MFC).

".45 ACP - because shooting twice is just silly" - JSOP, 2010
-----
You can never have too much ammo - unless you're swimming, or on fire. - JSOP, 2010
-----
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass." - Dale Earnhardt, 1997

Rajesh R Subramanian

Iain Clarke, Warrior Programmer wrote:

"pSettings->sColName"

That's some funny stuff to deal with on a Monday morning! So, you now have a button (or whatever cb is), that's labelled pSettings->sColName. :laugh:

"Real men drive manual transmission" - Rajesh.

Graham Shanks

Iain Clarke, Warrior Programmer wrote:

cb->SetWindowText ("pSettings->sColName");

Nothing's wrong with it. It compiles and executes without error. If it fails to do wanted you wanted then that's not the computer's problem. Perhaps you should lower your expectations and try again.

Graham Librarians rule, Ook!

CPallini

No error, "pSettings->sColName" is a quite descriptive text... :)

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler. -- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong. -- Iain Clarke
[My articles]

Iain Clarke Warrior Programmer

It is perfectly legit code, so the compiler was of no help at all... It did look odd in the running dialog though! Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Iain Clarke Warrior Programmer

Well, it might start confusing people if my code was in a loop... You must love filling in forms with "Insert Name here"... Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Iain Clarke Warrior Programmer

Contents of a combobox, but yes! Well, not any more, I did fix it! Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Ravi Bhavnani

Ah, a common error. Let me fix it for you:

cb.Text = "pSettings->sColName";

;P /ravi

My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com

Rage

The user should spot it quite quickly, in my opinion. The window/button/caption labeled "pSettings->sColName" is not intuitive in the UI...

Iain Clarke Warrior Programmer

Hehe...

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Iain Clarke Warrior Programmer

I like to think I fix problems first! I like to think... Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Iain Clarke Warrior Programmer

It's a Monday. Expectations are already pretty low! Iain.

I am one of "those foreigners coming over here and stealing our jobs". Yay me!

Gary R Wheeler

It should have been:

#include "tchar.h"
...
cb->SetWindowText(_T("pSettings->sColName"));

so that you could easily compile for either MBCS or UNICODE :rolleyes:.

Software Zen: delete this;