Invalid Argument in For Loop

[computerpublic]

I only need to evaluate if whether or not a "0" exist in the BitArray string. I dont care about the "1".

[computerpublic]

I only need to evaluate if whether or not a "0" exist in the BitArray string. I dont care about the "1".

[Lost User]

Then just test for false; the BitArray[item] is a boolean value.

[computerpublic]

Should it be: bool a = false; a=bits[count]; if (a) { } is this correct?

[Lost User]

No, you should just be testing the specific bit:

if (!bits[count])
// OR
if (bits[count] == false)

However, having looked more closely at your code I am at a loss to understand what the program is supposed to do. In particular why you are reading those files and why you are writing new copies of them, or what any of that has to do with your for loops.

[OriginalGriff]

And what are you going to do if it is a one? now print anything? :laugh: Trust me: AND the value with 1 returns either 0 or 1 depending on the state of teh least significant bit the in value. Using >> then shifts the whole input down a single bit, so the second bit takes the place of first, and so forth. It's a lot more efficient than using a BitString for each byte.

Those who fail to learn history are doomed to repeat it. --- George Santayana (December 16, 1863 – September 26, 1952) Those who fail to clear history are doomed to explain it. --- OriginalGriff (February 24, 1959 – ∞)

[computerpublic]

/*No more errors. My input to the program is letter "e" which is enclosed within a text file in c:\\folder9. The decimal equivalent of letter "e" is 101. When I run 101 thru the BitArray, it evaluates all bits as false which is NOT CORRECT.*/
using System;
using System.IO;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace Applica
{
class Program
{
static void Main(string[] args)
{
DirectoryInfo da = new DirectoryInfo("C:\\Folder9");
FileInfo[] Arr = da.GetFiles();
if (Arr.Length == 0)
{
throw new InvalidOperationException("No files found.");
}
// No need to loop through the array just to get the last item:
FileInfo ap = Arr[Arr.Length - 1];
long Totbyte = ap.Length;
string filePath = ap.FullName;
Console.WriteLine("Total Bytes = {0} bytes", Totbyte);
// GetTempFileName *creates* the file, so it always exists:
string temPath = Path.GetTempFileName();
byte[] data = File.ReadAllBytes(filePath);
File.WriteAllBytes(temPath, data);

        byte\[\] dataB = new byte\[1\];
        BitArray bits = new BitArray(dataB);
        Console.WriteLine("length= {0}",bits.Length);
        for (long counter = 0; counter < Totbyte; counter++)
        {
            dataB\[0\] = data\[counter\];
            Console.WriteLine("{0}", dataB\[0\]);
            for (int count = 0; count < bits.Length; count++)
            {
                if (bits\[count\] == true)
                    Console.WriteLine("{0}", bits\[count\]);
                if (bits\[count\] == false)
                    Console.WriteLine("{0}", bits\[count\]);
            }
        }
    }
}

}

[Lost User]

computerpublic wrote:

When I run 101 thru the BitArray, it evaluates all bits as false which is NOT CORRECT

But the problem is that you do not run that value through it. Your code is:

        byte\[\] dataB = new byte\[1\];
        // set bits to the content of dataB, which is null at this point
        BitArray bits = new BitArray(dataB);
        Console.WriteLine("length= {0}",bits.Length);
        for (long counter = 0; counter < Totbyte; counter++)
        {
            dataB\[0\] = data\[counter\];
            Console.WriteLine("{0}", dataB\[0\]);
            // bits still does not contain any value
            for (int count = 0; count < bits.Length; count++)
            {
                // this can be simplified
                if (bits\[count\] == true)
                    Console.WriteLine("{0}", bits\[count\]);
                if (bits\[count\] == false)
                    Console.WriteLine("{0}", bits\[count\]);
            }
        }

It should be

        byte\[\] dataB = new byte\[1\];
        for (long counter = 0; counter < Totbyte; counter++)
        {
            dataB\[0\] = data\[counter\];
            BitArray bits = new BitArray(dataB);
            Console.WriteLine("length= {0}",bits.Length);
            Console.WriteLine("{0}", dataB\[0\]);
            for (int count = 0; count < bits.Length; count++)
            {
                Console.Write(bits\[count\] ? "1" : "0");
            }
            Console.WriteLine("");
        }

[computerpublic]

I am noticing that the programs default operation is to evaluate the Most Significant Bit First and it evaluates the Least Significant Bit Last. I was not expecting this behavior. This this always the case the default case? Can I change the default operation to do LSB to MSB?

[Lost User]

See http://msdn.microsoft.com/en-us/library/x1xda43a(v=vs.110).aspx[^].