Checking for empty guid

Sander Rossel

Isn't a non-unique GUID pretty unique :D

It's an OO world.

public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}

Sander Rossel

You mean they aren't the letter O?

It's an OO world.

public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}

Bernhard Hiller

Don't fix that! Other places using that function meanwhile rely on its "feature" that it returns a *special* list for Guid.Empty()!

Bernhard Hiller

Exactly. Ought to be

Guid invalid = Guid.Empty();
if (userQueryID.ToString().ToUpper() != invalid.ToString().ToUpper());return null;

Oops;! Happened to add another feature...

Nagy Vilmos

IIRC guid's are value not reference types so they can't be empty. Doesn't it have hasValue() method or some such?

Richard Deeming

They can't be null, but they can be empty, which is the guid equivalent of zero. http://msdn.microsoft.com/en-us/library/system.guid.empty.aspx[^] There's no HasValue property or method; you just need to test whether it's equal to Guid.Empty.

"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer

PIEBALDconsult

Richard Deeming wrote:

you just need to test whether it's equal to Guid.Empty

Except for that you probably don't actually need to. Edit: I'm also suspicious as to whether or not they're actually using System.Guid. The snippet doesn't specify, so it's possible that they rolled their own Guid class and then all bets are off.