Bookmark Button Missing
-
@chris-maunder I cam across something last night and this morning I tried again while at work and it is still happening so I wanted to share with you and see if you can figure out on your end what's happening. As the title says, the bookmark button is missing but let me elaborate a bit more on what I mean. I suspect the addition of the "award badge" is somehow breaking responsiveness of the page and might be neutering the button somehow but I won't assume. Let's just use the link in question, so we have a POC to work with. Using SQLite in C#/VB.Net [^] As you can see here, the bookmark button is missing. I am giving you multiple widths to help visualize the responsive part I mentioned. First (1600x)
Notice on the right, you have the printer button, no bookmark and the award badge below it. Second (~<800x) 
Notice, still no bookmark and now the award badge is gone (and you have a horizontal scrollbar introduced). Third (~>800x) 
Notice, the badge comes into view with the horizontal scrollbars and still no bookmark. At approximately 896px width, the scrollbar disappears and the badge is fully visible. So I decided to do an inspect element and see what it has in the DOM, code wise. It looks like the bookmark "element" is there but not quite properly constructed 
I may very well be wrong about this, but my initial thought is that somehow the responsive coding for the page is being broken by the presence of the badge, and it is somehow causing the bookmark element to not be properly showing up. My anecdotal evidence for this is that when looking at an article without the badge, the bookmark button shows up fine and works as intended. NOTE: I just tested this and now it doesn't show up on ANY article, including any of the ones already on my bookmark list or p -
@chris-maunder I cam across something last night and this morning I tried again while at work and it is still happening so I wanted to share with you and see if you can figure out on your end what's happening. As the title says, the bookmark button is missing but let me elaborate a bit more on what I mean. I suspect the addition of the "award badge" is somehow breaking responsiveness of the page and might be neutering the button somehow but I won't assume. Let's just use the link in question, so we have a POC to work with. Using SQLite in C#/VB.Net [^] As you can see here, the bookmark button is missing. I am giving you multiple widths to help visualize the responsive part I mentioned. First (1600x)
Notice on the right, you have the printer button, no bookmark and the award badge below it. Second (~<800x) Notice, still no bookmark and now the award badge is gone (and you have a horizontal scrollbar introduced). Third (~>800x) Notice, the badge comes into view with the horizontal scrollbars and still no bookmark. At approximately 896px width, the scrollbar disappears and the badge is fully visible. So I decided to do an inspect element and see what it has in the DOM, code wise. It looks like the bookmark "element" is there but not quite properly constructed I may very well be wrong about this, but my initial thought is that somehow the responsive coding for the page is being broken by the presence of the badge, and it is somehow causing the bookmark element to not be properly showing up. My anecdotal evidence for this is that when looking at an article without the badge, the bookmark button shows up fine and works as intended. NOTE: I just tested this and now it doesn't show up on ANY article, including any of the ones already on my bookmark list or p -
As of checking just now, no they are not. Do you have a screenshot to show they are there or are just assuming? The only thing there are now Follow/Unfollow buttons (which are new to me) and the print button, nothing else. The DOM clearly shows that bookmark should be there but is only an empty SPAN element.
-
As of checking just now, no they are not. Do you have a screenshot to show they are there or are just assuming? The only thing there are now Follow/Unfollow buttons (which are new to me) and the print button, nothing else. The DOM clearly shows that bookmark should be there but is only an empty SPAN element.
-
As of checking just now, no they are not. Do you have a screenshot to show they are there or are just assuming? The only thing there are now Follow/Unfollow buttons (which are new to me) and the print button, nothing else. The DOM clearly shows that bookmark should be there but is only an empty SPAN element.
You see a follow *and* and unfollow button? The only way that's possible is due to a Javascript error or some script being blocked. This would explain why there's no bookmark button. If the script died then the bookmark won't get a chance to be created.
cheers Chris Maunder
-
You see a follow *and* and unfollow button? The only way that's possible is due to a Javascript error or some script being blocked. This would explain why there's no bookmark button. If the script died then the bookmark won't get a chance to be created.
cheers Chris Maunder
Chris Maunder wrote:
You see a follow *and* and unfollow button?
Yes, just like you see in the picture. There are no scripts blocked and only these two errors in the console:
TypeError: $(...).doubleTapToGo is not a function article.min.js:1:16968
TypeError: can't redefine non-configurable property "retrievalService" Using-SQLite-in-Csharp-VB-Net:13:5And this is the DOM content for the buttons:
Follow Unfollow [  ](/Articles/1210189/Using-SQLite-in-Csharp-VB-Net?display=Print)As you can see the empty bookmark SPAN and the print are not consistent and the way they are created is not being affected by a script being blocked, but possibly the error above could explain why it is breaking and not finishing, that's possible.
-
You see a follow *and* and unfollow button? The only way that's possible is due to a Javascript error or some script being blocked. This would explain why there's no bookmark button. If the script died then the bookmark won't get a chance to be created.
cheers Chris Maunder
Here is some additional information gathered by running on Edge which resulted in some interesting findings. 1. Visit that link while NOT LOGGED IN and I see this:
As you can see, holy hell, there is the bookmark button and no follow/unfollow in sight; which makes no sense, given that if you are not logged in, where will it be bookmarking this? Now that brings us to what you see in the console:HTML1512: Unmatched end tag. Using-SQLite-in-Csharp-VB-Net (1059,159)(4) HTML1500: Tag cannot be self-closing. Use an explicit closing tag. Using-SQLite-in-Csharp-VB-Net (1420,17)
2. Visit that link while LOGGED IN and I see this:
As you can see, we have a follow (the unfollow shows up and then goes away) and the rest are there too. But this happens ONLY on Edge for me right now, not on Firefox. But you then again you have a ton of stuff suddenly in the console:HTML1512: Unmatched end tag. Using-SQLite-in-Csharp-VB-Net (1038,159)(4) HTML1500: Tag cannot be self-closing. Use an explicit closing tag. Using-SQLite-in-Csharp-VB-Net (1399,17)
HTTP404: NOT FOUND - The server has not found anything matching the requested URI (Uniform Resource Identifier).
GET - https://www.codeproject.com/script/ResearchLibrary/Logos/LibraryItemThumbnail\_261\_100x130.png
SCRIPT5078: SCRIPT5078: Cannot redefine non-configurable property 'retrievalService' Using-SQLite-in-Csharp-VB-Net (13,5)Now if I try to click the bookmark button, the spinner shows up and spin for eternity with absolutely nothing happening, as you see here:
Hopefully this will help you because clearly there are some coding irregularities and/or issues with how you are handling authenticated users and services. Now if it is working for Richard and not me, then perhaps how the users are "classified" is part of the problem and the hierarchy or levels are not working consistently, I don't know, just thinking out loud but it IS happening, it IS NOT working and I will provide whatever you need but before w -
You see a follow *and* and unfollow button? The only way that's possible is due to a Javascript error or some script being blocked. This would explain why there's no bookmark button. If the script died then the bookmark won't get a chance to be created.
cheers Chris Maunder
I just wanted to share with you an update. Without any changes to my setup or taking any special steps, the problem seems to have resolved during checking this morning. The errors I shared with you still show up in the console but the bookmark button is back and only a follow button, not both. Hope it stays that way but wanted to share that with you in case it helps.
-
I just wanted to share with you an update. Without any changes to my setup or taking any special steps, the problem seems to have resolved during checking this morning. The errors I shared with you still show up in the console but the bookmark button is back and only a follow button, not both. Hope it stays that way but wanted to share that with you in case it helps.
I made an update overnight which shouldn't have affected anything. If you clear the console errors and reload do you still get the errors? Thanks for keeping me updated. You've been a huge help in this.
cheers Chris Maunder
-
I made an update overnight which shouldn't have affected anything. If you clear the console errors and reload do you still get the errors? Thanks for keeping me updated. You've been a huge help in this.
cheers Chris Maunder
I don't know what to tell you there as to why it worked afterwards, I didn't know you pushed an update ;) but I can tell you that when I refresh the page this item still shows up in the console:
TypeError: can't redefine non-configurable property "retrievalService" nVLC:13:5
Otherwise, the rest of them don't seem to be there anymore (on Firefox at least) I have not checked on Edge. BTW, do you happen to know why the various options that used to pop up when you pasted into the box here no longer shows up? It was a handy way to format accordingly based on what you were pasting. Just wondering :thumbsup:
-
I don't know what to tell you there as to why it worked afterwards, I didn't know you pushed an update ;) but I can tell you that when I refresh the page this item still shows up in the console:
TypeError: can't redefine non-configurable property "retrievalService" nVLC:13:5
Otherwise, the rest of them don't seem to be there anymore (on Firefox at least) I have not checked on Edge. BTW, do you happen to know why the various options that used to pop up when you pasted into the box here no longer shows up? It was a handy way to format accordingly based on what you were pasting. Just wondering :thumbsup:
GµårÐïåñ wrote:
BTW, do you happen to know why the various options that used to pop up when you pasted into the box here no longer shows up?
I can pretty much guarantee it's the same Javascript issue that's been plaguing you. Just to remind me: which page are you seeing the retrievalService error and under which browser?
cheers Chris Maunder
-
GµårÐïåñ wrote:
BTW, do you happen to know why the various options that used to pop up when you pasted into the box here no longer shows up?
I can pretty much guarantee it's the same Javascript issue that's been plaguing you. Just to remind me: which page are you seeing the retrievalService error and under which browser?
cheers Chris Maunder
I don't know why that would be, given that nothing is being blocked or showing as failing load, so it should not be causing me any specific errors. In fact while posting this, I am checking the console and there are no errors at all and all resources by the site are showing 200 (successfully loaded). The error mentioned above seems to stem from this resource: https://cdn2.developermedia.com/a.min.js As for the last error I posted for you, it was on this page: https://www.codeproject.com/Articles/109639/nVLC [^] and this is happening on Firefox 56 as of posting the issue. I can check on other browsers and versions if it will help, let me know. Let me know if I can provide anything else. BTW, as stated before, currently the articles menu issue that we had before is functioning properly, so kudos there. Might I ask one other thing, why is it that something that is bookmarked and shows up under my bookmarks, will not display as bookmarked already when visiting the page again, as you can see, it still shows the bookmark icon not that it is already bookmarked, can you look into that.
With regards to the paste options not showing up on this box while post, including "uploading" pictures, I believe I might have figured out the cause of that, so I will share it with you in case you encounter issues about it in the future, you can suggest checking this. If you havedom.event.clipboardevents.enabled;false
on Firefox, it will cause that issue given that you are relying on clipboard events to perform those tasks. I confirmed that setting it to TRUE will resolve that particular issue. So that one is on me, sorry I didn't catch that before mentioning it.
-
I don't know why that would be, given that nothing is being blocked or showing as failing load, so it should not be causing me any specific errors. In fact while posting this, I am checking the console and there are no errors at all and all resources by the site are showing 200 (successfully loaded). The error mentioned above seems to stem from this resource: https://cdn2.developermedia.com/a.min.js As for the last error I posted for you, it was on this page: https://www.codeproject.com/Articles/109639/nVLC [^] and this is happening on Firefox 56 as of posting the issue. I can check on other browsers and versions if it will help, let me know. Let me know if I can provide anything else. BTW, as stated before, currently the articles menu issue that we had before is functioning properly, so kudos there. Might I ask one other thing, why is it that something that is bookmarked and shows up under my bookmarks, will not display as bookmarked already when visiting the page again, as you can see, it still shows the bookmark icon not that it is already bookmarked, can you look into that.
With regards to the paste options not showing up on this box while post, including "uploading" pictures, I believe I might have figured out the cause of that, so I will share it with you in case you encounter issues about it in the future, you can suggest checking this. If you havedom.event.clipboardevents.enabled;false
on Firefox, it will cause that issue given that you are relying on clipboard events to perform those tasks. I confirmed that setting it to TRUE will resolve that particular issue. So that one is on me, sorry I didn't catch that before mentioning it.
Another day, another update. Can you let me know the current state for you now? Two other things. 1. The bookmark icon. I have a mode I can enable that will set the bookmark state based on whether the item is currently bookmarked. This adds extra load and we've been battling some nasty load issues these past 2 weeks so I've deliberately kept it turned off. We can re-enable it soon I hope. 2. The paste thing. Ah Firefox. The original incarnation of this feature was very complicated specifically to work around firefox paste permissions. The code, if I remember rightly, was simplified as these issues were addressed by Firefox. If we'd kept the complicated horrible code we would have nicely avoided the issue you mentioned. C'est la vie...
cheers Chris Maunder
-
Another day, another update. Can you let me know the current state for you now? Two other things. 1. The bookmark icon. I have a mode I can enable that will set the bookmark state based on whether the item is currently bookmarked. This adds extra load and we've been battling some nasty load issues these past 2 weeks so I've deliberately kept it turned off. We can re-enable it soon I hope. 2. The paste thing. Ah Firefox. The original incarnation of this feature was very complicated specifically to work around firefox paste permissions. The code, if I remember rightly, was simplified as these issues were addressed by Firefox. If we'd kept the complicated horrible code we would have nicely avoided the issue you mentioned. C'est la vie...
cheers Chris Maunder
Quote:
Another day, another update. Can you let me know the current state for you now?
The never ending curse of an admin developer ;) I went to the latest articles page and clicked on the first one I saw and the only error I see is:
TypeError: can't redefine non-configurable property "retrievalService" Software-Project-Development-and-Decision-Making:13:5
But it is not affecting the bookmark button or anything anymore, and I didn't expect this would be a blocking error where it would affect ancillary objects and seems whatever resolved the button issue wasn't related to this and is working fine now. I cannot detect anything obvious to me that this particular error would affect but if I do figure out what this error "actually" breaks on the page, I will share it with you ASAP. But the original issue of "missing button" resolved and as already stated, I check the dropdown "articles menu" each day I visit and the issue with the menu is gone too, so technically both of the original issues reported are now resolved in effect.
Quote:
1. The bookmark icon. I have a mode I can enable that will set the bookmark state based on whether the item is currently bookmarked. This adds extra load and we've been battling some nasty load issues these past 2 weeks so I've deliberately kept it turned off. We can re-enable it soon I hope.
Understood :thumbsup: makes perfect sense, just wanted to let you know in case you didn't now, clearly you do, so apologies.
Quote:
2. The paste thing. Ah Firefox. The original incarnation of this feature was very complicated specifically to work around firefox paste permissions. The code, if I remember rightly, was simplified as these issues were addressed by Firefox. If we'd kept the complicated horrible code we would have nicely avoided the issue you mentioned. C'est la vie...
Hindsight, thou art a heartless bitch :laugh: I hear ya, no worries, once I figured out what was breaking it, just a matter of letting you know. I was actually going to suggest making a more agnostic code, which clearly you had done before, so it is all good, if you choose to try again, let me know and I will gladly test it for you, if not then I will adapt when necessary to be able to use the current implementation.
-
Quote:
Another day, another update. Can you let me know the current state for you now?
The never ending curse of an admin developer ;) I went to the latest articles page and clicked on the first one I saw and the only error I see is:
TypeError: can't redefine non-configurable property "retrievalService" Software-Project-Development-and-Decision-Making:13:5
But it is not affecting the bookmark button or anything anymore, and I didn't expect this would be a blocking error where it would affect ancillary objects and seems whatever resolved the button issue wasn't related to this and is working fine now. I cannot detect anything obvious to me that this particular error would affect but if I do figure out what this error "actually" breaks on the page, I will share it with you ASAP. But the original issue of "missing button" resolved and as already stated, I check the dropdown "articles menu" each day I visit and the issue with the menu is gone too, so technically both of the original issues reported are now resolved in effect.
Quote:
1. The bookmark icon. I have a mode I can enable that will set the bookmark state based on whether the item is currently bookmarked. This adds extra load and we've been battling some nasty load issues these past 2 weeks so I've deliberately kept it turned off. We can re-enable it soon I hope.
Understood :thumbsup: makes perfect sense, just wanted to let you know in case you didn't now, clearly you do, so apologies.
Quote:
2. The paste thing. Ah Firefox. The original incarnation of this feature was very complicated specifically to work around firefox paste permissions. The code, if I remember rightly, was simplified as these issues were addressed by Firefox. If we'd kept the complicated horrible code we would have nicely avoided the issue you mentioned. C'est la vie...
Hindsight, thou art a heartless bitch :laugh: I hear ya, no worries, once I figured out what was breaking it, just a matter of letting you know. I was actually going to suggest making a more agnostic code, which clearly you had done before, so it is all good, if you choose to try again, let me know and I will gladly test it for you, if not then I will adapt when necessary to be able to use the current implementation.
You're a gentleman and a scholar. Thanks again for all your help. You've truly gone above and beyond. Thank you.
cheers Chris Maunder
-
You're a gentleman and a scholar. Thanks again for all your help. You've truly gone above and beyond. Thank you.
cheers Chris Maunder
