Implementing a moving average

[auting82]

Hi Ralf, see the links from my GUI, perhaps its easier to understand what I want and what I currently get: Link1: Moving average applied — imgbb.com[^] Link2: What happens — imgbb.com[^] In the filter textbooks I need to see moving averaged filtered values for each sensor A1 up to A7.

[Ralf Meier]

OK ... in your code snippet (before my last response) I haven't seen (or realized) that your loop works with the Analogue Inputs - not the different values from each Input (in that case my posted Solution has matched). So you have another loop (outside the AI-Loop) which takes the samples ...? I will create another code-suggestion for you which works with an array you need. But now (and that is what you really wanted to have) you would get a method which builds an Average at the end of the meassurering - not moving. The difference is : Moving means during and not at the End ... One moment please ...

[Ralf Meier]

      double\[,\] AnalogSensorValue  = new double\[7,6\];

        // take the samples
        for (int cycle = 1; cycle <= 5; cycle++)
        {
            for (int sensor = 0; sensor <= 6; sensor++)
            {
                AnalogSensorValue\[sensor, cycle\] = 1234;  // <- assign your meassurering-value here instead of 1234
                // do your Textbox-Assignment here as you need
            }
        }

        // finally the evaluation
        for (int sensor = 0; sensor <= 6; sensor++)
        {
            AnalogSensorValue\[sensor, 0\] = 0;
            for (int cycle = 1; cycle <= 5; cycle++)
            {
                AnalogSensorValue\[sensor, 0\] += AnalogSensorValue\[sensor, cycle\];
            }
            AnalogSensorValue\[sensor, 0\] /= 5;  //AnalogSensorValue\[sensor, 0\] now holds your average for each sensor
        }

programming in C# is not my favourite ... :cool:

[auting82]

Thanks a lot.Have some questions. Trying to understand your code. You are running 5 cycles to save 5 sensor values? What is the measuring value you are referring to?:confused: Are you talking about:

Analogsensorvalues=sObj[id].GetDigitalValue();

Because this is where and how I actually enter or get the randomly generated sensor values from the Sensor.cs class.

// take the samples
for (int cycle = 1; cycle <= 5; cycle++)
{
for (int sensor = 0; sensor <= 6; sensor++)
{
AnalogSensorValue[sensor, cycle] = AnalogSensorValues; // <- assign your meassurering-value here instead of 1234
txtNumberWritings.Text += sensor.ToString(); // do your Textbox-Assignment here as you need
}
}

I tired something here, but not really sure if I understood how I am suppose to store my values.:~ I am just getting 0,1,2,3,4,5,6 in the text box If the code works as intended I should be getting values I have for each sensor?

[Ralf Meier]

Yes ... I'm talking about that assignment

Analogsensorvalues=sObj[id].GetDigitalValue();

This couldn't be tested by me. But you have to realize that in my "method" the variable 'id' isn't used. I guess you you replace it by my loop-variable 'sensor'. Inside the loop which you refer you assign 'sensor.toString' to the Textbox. That isn't correct - here you have to assign 'AnalogSensorValues.toString' as you have done before. If you make all changes to my code-snippet as necessary the code should work as you want ... If not please provide your actual code - apologize that my code-suggestion wasn't better ... but because C# isn't my 1st choice for coding I had to test my code before providing - so some of your assignments couldn't be made by me because I didn't have your complete project ... Waiting for your Feedback ...

[auting82]

Hi Ralf, I think I have solved the problem now. I created a class for MovingAverageFilter. The only little problem I have left is implementing an automatic sampling by ticking off check box. Struggling with that at the moment. Also I guess I do not have proper Random numbers as I always start off from the same Seed No., would be great to Randomize that properly, so that it creates completely new numbers next time I run the app. See my code: Main Form1.cs

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.IO;
using System.Xml.Linq;
using System.Windows.Forms;
using System.Globalization;
using System.Linq;
using System.Collections.Generic;
using System.Collections;

namespace DAQ_Simulator
{
public partial class Form1 : Form
{
int counter;
int count_lines;
System.Timers.Timer t;
//Log time varibles
int LoggingTime=56;
int LogTimeLeft;

    //Sampling variables
    float SamplingTime = 5.9f;        
    private int clickcounterSampling;
    private DateTime datetime;
    private DateTime datetime2;
    private DateTime NextLoggingTime;
    int maxAI = 7;
    int maxDI = 3;
    int maxSid = 9;
    String SensorText;
    String sTxt1;
    String fTxt;
    // Create an array of 10 sensor objects
    Sensor\[\] SensorObject = new Sensor\[10\];
    MA\_Filter\[\] FilterObject = new MA\_Filter\[10\];
    
    public Form1()
    {
        InitializeComponent();

        for (counter = 0; counter < maxSid; counter++)
        {
            SensorObject\[counter\] = new Sensor(counter);
           FilterObject\[counter\] = new MA\_Filter(counter); //Create filters
        }        
    }
    private void displaySensorData(object sender, EventArgs e)
    {
    }
    private void groupSampl\_Enter(object sender, EventArgs e)
    {

    }
    private void textSampling\_TextChanged(object sender, EventArgs e)
    {



    }
    private void btnSampling\_Click(object sender, EventArgs e)
    {
        txtNextSamplingTime.Text = "5.9sec";
        clickcounterSampling++;
        if (clickcounterSampling == 1)
        {
            txtSensorValues.Text = "TimeStamp        AI.1,      AI.2,

[Ralf Meier]

Well ... very good if it works now. What I like to know now : for what is that good ? OK ... you have a kind of Simulation ... but what is the final goal ? Do you want to communicate with a PLC which will give you Values of a Meassurement ? In that case you should realize that a PLC (or something similar) will give you each Millisecond a new Value ... and those Values (of course) need to be smoothed - but continiuesly. Or is the goal something complete different ?

[auting82]

I just did an assignment for a specific course I am doing at the Uni.This was just meant as a simulation so there really is no further goal behind this. Sensors were suppose to simulate signals from field instruments I guess. Thanks for the help Ralf Maier.