This has probably been on here before, but if so, enjoy again
-
[how we write/review code in big tech companies](https://www.youtube.com/watch?v=rR4n-0KYeKQ)
The Science of King David's Court | Object Oriented Programming with C++
-
[how we write/review code in big tech companies](https://www.youtube.com/watch?v=rR4n-0KYeKQ)
The Science of King David's Court | Object Oriented Programming with C++
"I have no idea" seems to sum up about everyone I've ever worked with :sigh: One time, I had to fix this production issue. People were standing still and the company was losing money. I wrote a quick fix from home, asked someone to accept the pull request ASAP and drove to the office (a good one-hour drive). It was literally some literal string that needed to be changed, a one-word fix, so I was sure it was correct, the pull request would be accepted and everything would deploy to production automatically. When I arrived at the office, the reviewer was waiting for me. I had to make the literal string into a constant or he couldn't accept it X| And while I was on it, I had to do this for every literal string in this class X| X| X| The code made an API call and we simply had to pass some constant codes to the API, but instead of
"SomeCode"this developer wanted to seeSomeCode. I asked him if he was out of his :elephant:ing mind and that people were standing still over this. He wouldn't budge and ultimately I changed one or two string literals into consts just to move it along X|Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
"I have no idea" seems to sum up about everyone I've ever worked with :sigh: One time, I had to fix this production issue. People were standing still and the company was losing money. I wrote a quick fix from home, asked someone to accept the pull request ASAP and drove to the office (a good one-hour drive). It was literally some literal string that needed to be changed, a one-word fix, so I was sure it was correct, the pull request would be accepted and everything would deploy to production automatically. When I arrived at the office, the reviewer was waiting for me. I had to make the literal string into a constant or he couldn't accept it X| And while I was on it, I had to do this for every literal string in this class X| X| X| The code made an API call and we simply had to pass some constant codes to the API, but instead of
"SomeCode"this developer wanted to seeSomeCode. I asked him if he was out of his :elephant:ing mind and that people were standing still over this. He wouldn't budge and ultimately I changed one or two string literals into consts just to move it along X|Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
[how we write/review code in big tech companies](https://www.youtube.com/watch?v=rR4n-0KYeKQ)
The Science of King David's Court | Object Oriented Programming with C++
-
The "senior" developer doesn't seem to be much older than the "junior" one. Not surprised they have the same reaction. Agism. It works both ways.
In better workplaces, the terms senior and junior reflect domain experience, not chronological age nor the amount of time since you got your education.
Software Zen:
delete this; -
In better workplaces, the terms senior and junior reflect domain experience, not chronological age nor the amount of time since you got your education.
Software Zen:
delete this;Only better workplaces? If it wasn't like this, I would consider it a huge red flag.
Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing. -
"I have no idea" seems to sum up about everyone I've ever worked with :sigh: One time, I had to fix this production issue. People were standing still and the company was losing money. I wrote a quick fix from home, asked someone to accept the pull request ASAP and drove to the office (a good one-hour drive). It was literally some literal string that needed to be changed, a one-word fix, so I was sure it was correct, the pull request would be accepted and everything would deploy to production automatically. When I arrived at the office, the reviewer was waiting for me. I had to make the literal string into a constant or he couldn't accept it X| And while I was on it, I had to do this for every literal string in this class X| X| X| The code made an API call and we simply had to pass some constant codes to the API, but instead of
"SomeCode"this developer wanted to seeSomeCode. I asked him if he was out of his :elephant:ing mind and that people were standing still over this. He wouldn't budge and ultimately I changed one or two string literals into consts just to move it along X|Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
May I please request if I understand correctly Is the requested change equivalent from the one below to the second below Thank You Kindly - Cheerio
struct cfoobar
{
basic_string foobar() { return "some string"; }
};struct cfoobar
{
static const basic_string someString;
basic_string foobar() { return someString; }
};
const basic_string cfoobar::someString = "some string"; -
[how we write/review code in big tech companies](https://www.youtube.com/watch?v=rR4n-0KYeKQ)
The Science of King David's Court | Object Oriented Programming with C++
-
Not to defend the guy, but I suspect it all boils down to technical debt. He just didn't want to have to revisit this. He's probably got some horror stories to tell.
I think it was ego. It boiled down to:
someValue = "some code"
vs.
const string SomeCode = "some code";
// ...
someValue = SomeCodeYou literally can't have horror stories with this.
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
May I please request if I understand correctly Is the requested change equivalent from the one below to the second below Thank You Kindly - Cheerio
struct cfoobar
{
basic_string foobar() { return "some string"; }
};struct cfoobar
{
static const basic_string someString;
basic_string foobar() { return someString; }
};
const basic_string cfoobar::someString = "some string";It wasn't C(++?), but I think it comes to that, yes. Literally this in C#: my post above[^]
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
Only better workplaces? If it wasn't like this, I would consider it a huge red flag.
Robust Services Core | Software Techniques for Lemmings | Articles
The fox knows many things, but the hedgehog knows one big thing.There are worse workplaces, of course ;) ...
Software Zen:
delete this;
