Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. The Lounge
  3. Humble Brag

Humble Brag

Scheduled Pinned Locked Moved The Lounge
csscom
4 Posts 3 Posters 0 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • M Offline
    M Offline
    MarkTJohnson
    wrote on last edited by
    #1

    I contributed to my first open source project and my code was approved and merged in. It wasn't much of a change, I simply initialized variables in a default constructor but that should prevent an NPE when the scope chain unwinds and gets back to the root. Added default values to private Scope constructor by MarkTJohnson · Pull Request #3756 · liquibase/liquibase · GitHub[^] Ain't as complicated as what a lot of you guys are doing, but still.

    I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.

    S E M 3 Replies Last reply
    0
    • M MarkTJohnson

      I contributed to my first open source project and my code was approved and merged in. It wasn't much of a change, I simply initialized variables in a default constructor but that should prevent an NPE when the scope chain unwinds and gets back to the root. Added default values to private Scope constructor by MarkTJohnson · Pull Request #3756 · liquibase/liquibase · GitHub[^] Ain't as complicated as what a lot of you guys are doing, but still.

      I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.

      S Offline
      S Offline
      Slacker007
      wrote on last edited by
      #2

      Well according the PR comments, a few other users/devs are super glad for your fix/PR. Most excellent, I would say. :thumbsup: Brag away!

      1 Reply Last reply
      0
      • M MarkTJohnson

        I contributed to my first open source project and my code was approved and merged in. It wasn't much of a change, I simply initialized variables in a default constructor but that should prevent an NPE when the scope chain unwinds and gets back to the root. Added default values to private Scope constructor by MarkTJohnson · Pull Request #3756 · liquibase/liquibase · GitHub[^] Ain't as complicated as what a lot of you guys are doing, but still.

        I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.

        E Offline
        E Offline
        Ed Attfield
        wrote on last edited by
        #3

        I totally understand your feeling of pride. I'm still very pleased with myself for finding a similar initialization problem with the ages-old telnet client and submitting a fix to gnu. You may be smiling about this for years to come.

        1 Reply Last reply
        0
        • M MarkTJohnson

          I contributed to my first open source project and my code was approved and merged in. It wasn't much of a change, I simply initialized variables in a default constructor but that should prevent an NPE when the scope chain unwinds and gets back to the root. Added default values to private Scope constructor by MarkTJohnson · Pull Request #3756 · liquibase/liquibase · GitHub[^] Ain't as complicated as what a lot of you guys are doing, but still.

          I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.

          M Offline
          M Offline
          MarkTJohnson
          wrote on last edited by
          #4

          We need this to work, the version we are currently having to use has Vulnerabilities that newer versions address but the newer versions had scoping issues when under load. I really don't want to have to move to another tool.

          I’ve given up trying to be calm. However, I am open to feeling slightly less agitated.

          1 Reply Last reply
          0
          Reply
          • Reply as topic
          Log in to reply
          • Oldest to Newest
          • Newest to Oldest
          • Most Votes


          • Login

          • Don't have an account? Register

          • Login or register to search.
          • First post
            Last post
          0
          • Categories
          • Recent
          • Tags
          • Popular
          • World
          • Users
          • Groups