Welcome to my (new) life...
-
bug people : hey, there's an issue with a report we generate... me: naively opens up one of 3 report related files. hmmm, resharper doesn't start. looks at the report related files, first one has 37,000 lines and the other 2 files 17,000 and 15,000 lines. There's another file in our solution with 46,000 lines !!! (all formatted by rogue gremlins) :sigh:
CI/CD = Continuous Impediment/Continuous Despair
-
bug people : hey, there's an issue with a report we generate... me: naively opens up one of 3 report related files. hmmm, resharper doesn't start. looks at the report related files, first one has 37,000 lines and the other 2 files 17,000 and 15,000 lines. There's another file in our solution with 46,000 lines !!! (all formatted by rogue gremlins) :sigh:
CI/CD = Continuous Impediment/Continuous Despair
I see your huge files, and raise you 12300 lines of C code for PNG libary validation[^]. This is just the program that runs the tests. It is full of "interesting" things like parameters named "this" and "that":
static void
image_transform_png_set_palette_to_rgb_set(const image_transform *this,
transform_display *that, png_structp pp, png_infop pi)
{
png_set_palette_to_rgb(pp);
this->next->set(this->next, that, pp, pi);
}Also structure members called "new":
char wname[FILE_NAME_SIZE];
png_store_buffer new; /* The end of the new PNG file being written. */
store_pool write_memory_pool;For good measure, you should know that:
#define FILE_NAME_SIZE 64
:omg: If you are wondering how this can work, check this out:
#ifdef __cplusplus
define this not_the_cpp_this
define new not_the_cpp_new
Next time you hear the BS about "given enough eyeballs...", show them this crap open-source code.
Mircea
-
I see your huge files, and raise you 12300 lines of C code for PNG libary validation[^]. This is just the program that runs the tests. It is full of "interesting" things like parameters named "this" and "that":
static void
image_transform_png_set_palette_to_rgb_set(const image_transform *this,
transform_display *that, png_structp pp, png_infop pi)
{
png_set_palette_to_rgb(pp);
this->next->set(this->next, that, pp, pi);
}Also structure members called "new":
char wname[FILE_NAME_SIZE];
png_store_buffer new; /* The end of the new PNG file being written. */
store_pool write_memory_pool;For good measure, you should know that:
#define FILE_NAME_SIZE 64
:omg: If you are wondering how this can work, check this out:
#ifdef __cplusplus
define this not_the_cpp_this
define new not_the_cpp_new
Next time you hear the BS about "given enough eyeballs...", show them this crap open-source code.
Mircea
-
bug people : hey, there's an issue with a report we generate... me: naively opens up one of 3 report related files. hmmm, resharper doesn't start. looks at the report related files, first one has 37,000 lines and the other 2 files 17,000 and 15,000 lines. There's another file in our solution with 46,000 lines !!! (all formatted by rogue gremlins) :sigh:
CI/CD = Continuous Impediment/Continuous Despair
-
So in that first method, there is:
const image_transform *this
:sigh: That's a const image_transform pointer named this!?! Oy!
raddevus wrote:
That's a const image_transform pointer named this!?!
Indeed! But if you look at the
#defineI mentioned, it turns into:const image_transform *not_the_cpp_this
:laugh: And there are many, many functions that all use the
thisandthatparameters. I swear, the guy who wrote this code (John Cunningham Bowler according to copyright notice), had the worst naming system I've ever seen. Also, if you think this is code from the '80-es or'90-es, you are wrong again, at least according to copyright notice:* Copyright (c) 2021 Cosmin Truta
* Copyright (c) 2014-2017 John Cunningham BowlerAnd this is the code used to validate libpng, one of the most popular pieces of open-source software. :wtf:
Mircea
-
Maximilien wrote:
There's another file in our solution with 46,000 lines !!!
But think how convenient this is since you don't have to go searching in numerous files. :rolleyes: Whoever did that is definitely the square root of genius.
I have programs, that will concatenate text files; just so I can browse "the whole thing". I may "globally" change the whole thing; then split it back into its components; particularly when I'm doing a conversion of sorts. I'm inserting meta data as I'm doing this; so that everything that follows becomes trivial.
"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I
-
raddevus wrote:
That's a const image_transform pointer named this!?!
Indeed! But if you look at the
#defineI mentioned, it turns into:const image_transform *not_the_cpp_this
:laugh: And there are many, many functions that all use the
thisandthatparameters. I swear, the guy who wrote this code (John Cunningham Bowler according to copyright notice), had the worst naming system I've ever seen. Also, if you think this is code from the '80-es or'90-es, you are wrong again, at least according to copyright notice:* Copyright (c) 2021 Cosmin Truta
* Copyright (c) 2014-2017 John Cunningham BowlerAnd this is the code used to validate libpng, one of the most popular pieces of open-source software. :wtf:
Mircea
-
I see your huge files, and raise you 12300 lines of C code for PNG libary validation[^]. This is just the program that runs the tests. It is full of "interesting" things like parameters named "this" and "that":
static void
image_transform_png_set_palette_to_rgb_set(const image_transform *this,
transform_display *that, png_structp pp, png_infop pi)
{
png_set_palette_to_rgb(pp);
this->next->set(this->next, that, pp, pi);
}Also structure members called "new":
char wname[FILE_NAME_SIZE];
png_store_buffer new; /* The end of the new PNG file being written. */
store_pool write_memory_pool;For good measure, you should know that:
#define FILE_NAME_SIZE 64
:omg: If you are wondering how this can work, check this out:
#ifdef __cplusplus
define this not_the_cpp_this
define new not_the_cpp_new
Next time you hear the BS about "given enough eyeballs...", show them this crap open-source code.
Mircea
"Take *this job and shove it...
Our Forgotten Astronomy | Object Oriented Programming with C++ | Wordle solver
-
bug people : hey, there's an issue with a report we generate... me: naively opens up one of 3 report related files. hmmm, resharper doesn't start. looks at the report related files, first one has 37,000 lines and the other 2 files 17,000 and 15,000 lines. There's another file in our solution with 46,000 lines !!! (all formatted by rogue gremlins) :sigh:
CI/CD = Continuous Impediment/Continuous Despair
20 years ago... The C++ class had at least 100,000 lines of code. I say at least because besides the include file there were three different code files (which is possible in C++). It is possible there were others. There were at least 200 class attributes and at least 200 methods. Obviously the methods were not small. Design patterns because a thing after that and soon after that one saw "AntiPatterns" (the book by that name.) And so I learned what a God Object is.
