I've started to favour this form:
#define TRUE (!0)
#define FALSE (!TRUE)
But at least I put it in a header rather than within every single source file. In this case, it was in *.c. Can you say "maintenance nightmare"? And they claimed they were a CMM level 5 company, too.
Professional Geek, Amateur Stage-Levelling Gauge
modified on Wednesday, February 4, 2009 6:19 PM
Here's one I spotted in a previous life: We were working in C on protocol stacks. In every C file created by a group of contractors, we found the following statements:
#define True 0
#define False 1
This was endemic throughout the code produced by this particular group of contractors. Fortunately, the product never came to be. The 2001 Tech Wreck did it in. Geoff
Professional Geek, Amateur Stage-Levelling Gauge
And the comments on the terminating braces are useless, too.
Professional Geek, Amateur Stage-Levelling Gauge