I have no sense of humor.... [modified]
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
Unless a comment is particularly witty, you're right, he's wrong and needs to get over it. If we expect to be treated professionally, we need to act like professionals. (Moreover, if a piece of code is ever sold and/or distributed to a vendor or partner, stuff like this makes you look stupid and amateurish.) Besides, it just litters the code with useless verbiage.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
My very first programming gig was just after the Exxon Valdez fiasco. I was working on an oil tank farm system (large repositories that the gas trucks fill up from). One of our clients was Exxon. There was a comments section at the bottom of many screens which the customers used. I was informed that I was replacing a programmer who forgot to remove the test comment "Long Live the Valdez!" For every rule, there is an incident.
Christopher Duncan Author of The Career Programmer and Unite the Tribes Coming soon: Got a career question? Ask the Attack Chihuahua! www.PracticalUSA.com
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
El Corazon wrote:
am I too hard on my team?
Absolutely not. A. The ones you quoted are not at all funny. B. When I am trying to solve a production problem in his code a year from now, I don't want to be distracted by asinine comments. I do understand his impulse, of course. The trick is to make sure that all such 'humor' is tagged in such a way as it can be deleted in swell foop just before the team leader looks at the code.
Jon Smith & Wesson: The original point and click interface
-
El Corazon wrote:
am I too hard on my team?
Absolutely not. A. The ones you quoted are not at all funny. B. When I am trying to solve a production problem in his code a year from now, I don't want to be distracted by asinine comments. I do understand his impulse, of course. The trick is to make sure that all such 'humor' is tagged in such a way as it can be deleted in swell foop just before the team leader looks at the code.
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
The trick is to make sure that all such 'humor' is tagged in such a way as it can be deleted in swell foop just before the team leader looks at the code.
:laugh:
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
Contrarywise; that indicates that you do have a sense of humor.
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
Adding funny comments ONCE IN A WHILE is one thing, but not all over the place ... and as far as I am concerned, harsh comments (e.g. Windows Sucks, What idiot wrote this, etc...) does not belong in a company's code base. Now, something like Holy bad pointer Batman! That object isn't being freed! or If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T. In "my book" those would be O.k.
:..::. Douglas H. Troy ::..
Bad Astronomy |VCF|wxWidgets|WTL -
My very first programming gig was just after the Exxon Valdez fiasco. I was working on an oil tank farm system (large repositories that the gas trucks fill up from). One of our clients was Exxon. There was a comments section at the bottom of many screens which the customers used. I was informed that I was replacing a programmer who forgot to remove the test comment "Long Live the Valdez!" For every rule, there is an incident.
Christopher Duncan Author of The Career Programmer and Unite the Tribes Coming soon: Got a career question? Ask the Attack Chihuahua! www.PracticalUSA.com
Nice, I replaced a guy that complained continuously that security was too lax and too many people had the domain admin account password, so he used it to set everyones home page to monster.com. They figured out one way to improve security.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
-
Adding funny comments ONCE IN A WHILE is one thing, but not all over the place ... and as far as I am concerned, harsh comments (e.g. Windows Sucks, What idiot wrote this, etc...) does not belong in a company's code base. Now, something like Holy bad pointer Batman! That object isn't being freed! or If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T. In "my book" those would be O.k.
:..::. Douglas H. Troy ::..
Bad Astronomy |VCF|wxWidgets|WTLAgree. I do get a smile on my face when I find that kind of comments in others code. But the comments in the first post looks more like clutter.
Blog: http://www.rogeralsing.com Projects: http://www.puzzleframework.com
-
Nice, I replaced a guy that complained continuously that security was too lax and too many people had the domain admin account password, so he used it to set everyones home page to monster.com. They figured out one way to improve security.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
Andy Brummer wrote:
so he used it to set everyones home page to monster.com. They figured out one way to improve security.
Ah... The Los Alamos method of security improvement. (If you don't understand the reference then read "Surely your joking Mr. Feynman". Richard Feynman worked on the project to create the atomic bomb and he was always demonstrating how easy it was to break into safes, so instead of improving the safes, they just removed Feynman from the vicinity of the safes - The book goes in to all the different ways he used to hack into safes, some of them quite ingenious, some scarily simple considering the contents of the safe.)
Upcoming FREE developer events: * Developer Day Scotland Recent blog posts: * Mixins in C#3.0 My website | Blog
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
El Corazon wrote:
am I too hard on my team?
You're not tough enough. Code that's x years old is hard enough to read and maintain, you don't need crap comments added to the mix. If he won't remove them, fire him.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
It could be he feels loss of independance rather than about the comments themselves? Change like this is often painful in the longterm but hopefully soon he wil lsee benefits from the changes. Elaine :rose:
Visit http://www.notreadytogiveup.com/[^] and do something special today.
-
Unless a comment is particularly witty, you're right, he's wrong and needs to get over it. If we expect to be treated professionally, we need to act like professionals. (Moreover, if a piece of code is ever sold and/or distributed to a vendor or partner, stuff like this makes you look stupid and amateurish.) Besides, it just litters the code with useless verbiage.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
Joe Woodbury wrote:
Unless a comment is particularly witty
We have a web service named ELVIS (it's an acronym). The last line of the main web method is a comment that reads: //Elvis has left the building. What makes it even more witty and amusing is that the developer who wrote it isn't a native American, is too young to actually remember Elvis, and normally struggles a bit with obscure cultural references.
Grim MCDBA, MCSD, MCP+SB SELECT * FROM users WHERE clue IS NOT NULL (0 row(s) affected)
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
You know, every time I tried to win a bar-bet about being able to count to 1000 using my fingers I always get punched out when I reach 4.... -- El Corazon
-
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
You know, every time I tried to win a bar-bet about being able to count to 1000 using my fingers I always get punched out when I reach 4.... -- El Corazon
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
-
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
-
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
El Corazon wrote:
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off....
Terminate him. He's a bad apple and ultimately can spoil your whole team
Jon Smith & Wesson: The original point and click interface
-
El Corazon wrote:
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off....
Terminate him. He's a bad apple and ultimately can spoil your whole team
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
Terminate him. He's a bad apple and ultimately can spoil your whole team
Not in my hands. I am "a" senior programmer, not manager, or even project leader. He's talented, just opinionated. Our poor project leader and supervisor get the unenviable job of reigning us all in, thus the beginning of these code reviews.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Adding funny comments ONCE IN A WHILE is one thing, but not all over the place ... and as far as I am concerned, harsh comments (e.g. Windows Sucks, What idiot wrote this, etc...) does not belong in a company's code base. Now, something like Holy bad pointer Batman! That object isn't being freed! or If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T. In "my book" those would be O.k.
:..::. Douglas H. Troy ::..
Bad Astronomy |VCF|wxWidgets|WTLDouglas Troy wrote:
If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T.
I think I wrote that on a routine once... I included a few references to study, though. I believe it was multi-threaded based.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."