I have no sense of humor.... [modified]
-
Adding funny comments ONCE IN A WHILE is one thing, but not all over the place ... and as far as I am concerned, harsh comments (e.g. Windows Sucks, What idiot wrote this, etc...) does not belong in a company's code base. Now, something like Holy bad pointer Batman! That object isn't being freed! or If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T. In "my book" those would be O.k.
:..::. Douglas H. Troy ::..
Bad Astronomy |VCF|wxWidgets|WTLAgree. I do get a smile on my face when I find that kind of comments in others code. But the comments in the first post looks more like clutter.
Blog: http://www.rogeralsing.com Projects: http://www.puzzleframework.com
-
Nice, I replaced a guy that complained continuously that security was too lax and too many people had the domain admin account password, so he used it to set everyones home page to monster.com. They figured out one way to improve security.
I can imagine the sinking feeling one would have after ordering my book, only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon
Andy Brummer wrote:
so he used it to set everyones home page to monster.com. They figured out one way to improve security.
Ah... The Los Alamos method of security improvement. (If you don't understand the reference then read "Surely your joking Mr. Feynman". Richard Feynman worked on the project to create the atomic bomb and he was always demonstrating how easy it was to break into safes, so instead of improving the safes, they just removed Feynman from the vicinity of the safes - The book goes in to all the different ways he used to hack into safes, some of them quite ingenious, some scarily simple considering the contents of the safe.)
Upcoming FREE developer events: * Developer Day Scotland Recent blog posts: * Mixins in C#3.0 My website | Blog
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
El Corazon wrote:
am I too hard on my team?
You're not tough enough. Code that's x years old is hard enough to read and maintain, you don't need crap comments added to the mix. If he won't remove them, fire him.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
It could be he feels loss of independance rather than about the comments themselves? Change like this is often painful in the longterm but hopefully soon he wil lsee benefits from the changes. Elaine :rose:
Visit http://www.notreadytogiveup.com/[^] and do something special today.
-
Unless a comment is particularly witty, you're right, he's wrong and needs to get over it. If we expect to be treated professionally, we need to act like professionals. (Moreover, if a piece of code is ever sold and/or distributed to a vendor or partner, stuff like this makes you look stupid and amateurish.) Besides, it just litters the code with useless verbiage.
Anyone who thinks he has a better idea of what's good for people than people do is a swine. - P.J. O'Rourke
Joe Woodbury wrote:
Unless a comment is particularly witty
We have a web service named ELVIS (it's an acronym). The last line of the main web method is a comment that reads: //Elvis has left the building. What makes it even more witty and amusing is that the developer who wrote it isn't a native American, is too young to actually remember Elvis, and normally struggles a bit with obscure cultural references.
Grim MCDBA, MCSD, MCP+SB SELECT * FROM users WHERE clue IS NOT NULL (0 row(s) affected)
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
You know, every time I tried to win a bar-bet about being able to count to 1000 using my fingers I always get punched out when I reach 4.... -- El Corazon
-
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
You know, every time I tried to win a bar-bet about being able to count to 1000 using my fingers I always get punched out when I reach 4.... -- El Corazon
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
-
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
-
dan neely wrote:
the rule of thumb where i work is "would you be OK having it printed on the front page of the newspaper?"
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off.... :rolleyes:
El Corazon wrote:
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off....
Terminate him. He's a bad apple and ultimately can spoil your whole team
Jon Smith & Wesson: The original point and click interface
-
El Corazon wrote:
that wouldn't work here, he really does hate windows and the absolute worst thing about our company he says is that we support microsoft. He would proclaim it from the tallest mountain in front of the whole world if necessary. If we would just drop this cross-platform and go 100% java and linux, he thinks our company would be much better off....
Terminate him. He's a bad apple and ultimately can spoil your whole team
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
Terminate him. He's a bad apple and ultimately can spoil your whole team
Not in my hands. I am "a" senior programmer, not manager, or even project leader. He's talented, just opinionated. Our poor project leader and supervisor get the unenviable job of reigning us all in, thus the beginning of these code reviews.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Adding funny comments ONCE IN A WHILE is one thing, but not all over the place ... and as far as I am concerned, harsh comments (e.g. Windows Sucks, What idiot wrote this, etc...) does not belong in a company's code base. Now, something like Holy bad pointer Batman! That object isn't being freed! or If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T. In "my book" those would be O.k.
:..::. Douglas H. Troy ::..
Bad Astronomy |VCF|wxWidgets|WTLDouglas Troy wrote:
If you don't understand exactly what the following line of code does, then you're not qualified to modify it; so DON'T.
I think I wrote that on a routine once... I included a few references to study, though. I believe it was multi-threaded based.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Oakman wrote:
Terminate him. He's a bad apple and ultimately can spoil your whole team
Not in my hands. I am "a" senior programmer, not manager, or even project leader. He's talented, just opinionated. Our poor project leader and supervisor get the unenviable job of reigning us all in, thus the beginning of these code reviews.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
El Corazon wrote:
Not in my hands.
That's a shame, but I'd suggest then that you CYA. You may find this dweeb crying to your project leader about your authoritarian and humorless approach to interpersonal interaction. Next time you're put on code review, get a third party to sit in.
Jon Smith & Wesson: The original point and click interface
-
El Corazon wrote:
Not in my hands.
That's a shame, but I'd suggest then that you CYA. You may find this dweeb crying to your project leader about your authoritarian and humorless approach to interpersonal interaction. Next time you're put on code review, get a third party to sit in.
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
You may find this dweeb crying to your project leader about your authoritarian and humorless approach to interpersonal interaction. Next time you're put on code review, get a third party to sit in.
The whole team was in on this one, except the project leader who was called out to Ft Bliss on an emergency and our video expert who is on travel with our supervisor. Management does not sit in on these, but the project leader usually does. I will catch him up today. The easiest fix, was adding white space before in-line comments, several of us requested that.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Oakman wrote:
You may find this dweeb crying to your project leader about your authoritarian and humorless approach to interpersonal interaction. Next time you're put on code review, get a third party to sit in.
The whole team was in on this one, except the project leader who was called out to Ft Bliss on an emergency and our video expert who is on travel with our supervisor. Management does not sit in on these, but the project leader usually does. I will catch him up today. The easiest fix, was adding white space before in-line comments, several of us requested that.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
Swearing at work boosts team spirit[^] :cool: Could it be that YOU are bothered more by the "no sense of humor" comment than he is by not being allowed to? But still if it is as prominent as this sounds:
El Corazon wrote:
it would be impossible to remove all of those because it is in all of his source code everywhere in the system
it is clearly to much. I think a very few instances are ok, but if it is that prominent, it's a detraction and misuse of comments.
El Corazon wrote:
"remove sense of humor."
That shows some sense of humor :) I wouldn't go as far as setting up rules "no swearing allowed in comments", or word filters or whatever, unless he can't cut back to a level acceptable to most. Be friendly, but clear about it, and check if he complies. I'd turn that around - grinningly ask him "so, did you remove all sense of humor from the sources already?"
We are a big screwed up dysfunctional psychotic happy family - some more screwed up, others more happy, but everybody's psychotic joint venture definition of CP
blog: TDD - the Aha! | Linkify!| FoldWithUs! | sighist -
:( first the landlord business, now I guess I upset a programmer on my team... my only real comment was on comments... or rather removing commentary like "well duh!!" and "I hate windows!" from the source code. So he wrote down "remove sense of humor." :( But he admitted it would be impossible to remove all of those because it is in all of his source code everywhere in the system.... am I too hard on my team? I tried to cheer him up. His code was great, clear and easy to read! Overall, I thought the review went even better than mine! I just shudder to think of turning that over to our customers eventually. And we will. His code itself is top notch, we have some talented people here. me thinks we should have had peer review long before.... :sigh: Yours truly, the old fuddy duddy from the 80's business schools who has no sense of humor.... :sigh: ;) told ya I would be lousy at poker. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
modified on Wednesday, April 2, 2008 7:52 PM
El Corazon wrote:
me thinks we should have had peer review long before....
You certainly should have. Schedule them frequently, and make them informal - pizza and beers always go down well. Make them constructive and you will find tha you catch problems and bad habits long before they have a chance to become counterproductive.
Deja View - the feeling that you've seen this post before.
-
El Corazon wrote:
The whole team was in on this one
Good to hear, but be careful around this guy. He is a bad apple. Or maybe a bad linux.
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
Good to hear, but be careful around this guy. He is a bad apple
The project leader just came to find out the scoop. I never got to see him yesterday, but our programmer did talk with him about my inflexability. :doh: I shrugged, I said I thought it was a minor thing, it was just a presentation thing. We want to be professional when the air force and army have to review our code-base. They may overlook every single one of those comments, or they may see one and think less of us which hurts our image. And especially since it got into the deliverable class documentation, I was just uncomfortable with those kinds of comments. He asked what the comments were and brought up the list. He agreed, and left, end of story. He went off to talk to the programmer, not sure what was said there. :) I really wasn't trying to be picky, I was just worrried about our image, that was how I presented it, and that seemed to have sufficed for now. Now I guess I got two fallouts happening this week. :-D P.S. I'll watch my back for a few weeks....
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Oakman wrote:
Good to hear, but be careful around this guy. He is a bad apple
The project leader just came to find out the scoop. I never got to see him yesterday, but our programmer did talk with him about my inflexability. :doh: I shrugged, I said I thought it was a minor thing, it was just a presentation thing. We want to be professional when the air force and army have to review our code-base. They may overlook every single one of those comments, or they may see one and think less of us which hurts our image. And especially since it got into the deliverable class documentation, I was just uncomfortable with those kinds of comments. He asked what the comments were and brought up the list. He agreed, and left, end of story. He went off to talk to the programmer, not sure what was said there. :) I really wasn't trying to be picky, I was just worrried about our image, that was how I presented it, and that seemed to have sufficed for now. Now I guess I got two fallouts happening this week. :-D P.S. I'll watch my back for a few weeks....
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."