Smart programmers
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
//A day has passed by... this must be definitely an invalid sessionif(m_thisDay != date.T_day)Disconnect(SESSION_PREV, FORCE);
Oh well. At least he commented his incorrect assumptions.
Deja View - the feeling that you've seen this post before.
-
Cool. That must be relieving. I can't access thedailywtf from work. Perhaps will do it from home. :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Given the (apparent) quality of the code, that company needs to unblock TDWTF and they need to do it
Right Effing Now. Reading some of the code samples and comments on that site may have prevented some of that crap from happening in the first place! Peace!-=- James
Please rate this message - let me know if I helped or not! * * *If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
See DeleteFXPFiles -
Rajesh R Subramanian wrote:
//A day has passed by... this must be definitely an invalid sessionif(m_thisDay != date.T_day)Disconnect(SESSION_PREV, FORCE);
Oh well. At least he commented his incorrect assumptions.
Deja View - the feeling that you've seen this post before.
Looks like I have to read up each and every comment in the framework. I could find a gem any time. :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
Given the (apparent) quality of the code, that company needs to unblock TDWTF and they need to do it
Right Effing Now. Reading some of the code samples and comments on that site may have prevented some of that crap from happening in the first place! Peace!-=- James
Please rate this message - let me know if I helped or not! * * *If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
See DeleteFXPFilesFortunately, the code was not written by anyone over here. It was sold to our client by a Korean company. Our client moved the project to us, unsatisfied with the ones who previously 'developed' it.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
Before you took the job did you ask to see the team and look at the code you'll be working on? I always do.
norm .net wrote:
look at the code you'll be working on? I always do.
They let you look at what is probably proprietary code before you've signed the contract? You must look very trustworthy!
-
norm .net wrote:
look at the code you'll be working on? I always do.
They let you look at what is probably proprietary code before you've signed the contract? You must look very trustworthy!
That's what I was wondering about, but then I wildly guessed that such a thing may be allowed in the UK.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
No documentation whatsoever
Quite a common scenario - as with my current app. which I inherited. Plus zero code comments as well. :mad:
Kevin
-
Rajesh R Subramanian wrote:
No documentation whatsoever
Quite a common scenario - as with my current app. which I inherited. Plus zero code comments as well. :mad:
Kevin
Kevin McFarlane wrote:
Plus zero code comments as well.
No documentation? I can live with it. But come on! Code commenting is not *that* hard to do. I won't accept an excuse, whatsoever. Those bastards deserve a slow and painful death.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
Rajesh R Subramanian wrote:
I find this gem comment with relevant code:
Every Indian programmer has be redirected to Correct Forum[^] regardless of how many awards they receive. ;P :laugh:
"Sometimes the greatest journey is the distance between two people" - Nice quote from a Nice Indian Movie
And some Indian programmers are so hopelessly clueless that they can't tell the difference between a programming question and a programming rant.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
Before you took the job did you ask to see the team and look at the code you'll be working on? I always do.
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
And some Indian programmers are so hopelessly clueless that they can't tell the difference between a programming question and a programming rant.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
Kevin McFarlane wrote:
Plus zero code comments as well.
No documentation? I can live with it. But come on! Code commenting is not *that* hard to do. I won't accept an excuse, whatsoever. Those bastards deserve a slow and painful death.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
Those bastards deserve a slow and painful death.
I agree. :) Management and/or Team Leader ought to keep on top of that sort of thing. Ideally there should be code reviews but in environments where there isn't (the vast majority) there should at least be some minimal standards.
Kevin
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001John Simmons / outlaw programmer wrote:
All Indians look the same
Are you confusing India with Japan? :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
norm .net wrote:
look at the code you'll be working on? I always do.
They let you look at what is probably proprietary code before you've signed the contract? You must look very trustworthy!
I'm not being picky here, but you can hardly copy the system by glancing a page of code :wtf:. I always ask to see the system and the codebase I'll be working on, it saves you and the future employer at lot of time when it comes to the start date and you don't feel it's the job for you on day one after looking at the code.
-
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001John Simmons / outlaw programmer wrote:
so it would be like looking in a mirror.
I hope not Johnny Boy, I'm not Indian :rolleyes:.
-
John Simmons / outlaw programmer wrote:
All Indians look the same
Are you confusing India with Japan? :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
:laugh: don't matter to John he tars everyone with the same old brush.
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
needs more comments... "well... duh!" after invalid session and "I hate DST" after the lines shown... ;P hehehe, sorry... just had to.... ;)
-
I'm not being picky here, but you can hardly copy the system by glancing a page of code :wtf:. I always ask to see the system and the codebase I'll be working on, it saves you and the future employer at lot of time when it comes to the start date and you don't feel it's the job for you on day one after looking at the code.
norm .net wrote:
you can hardly copy the system by glancing a page of code
But to make the decision, you surely need to see quite a more than one page anyway?
-
:laugh: don't matter to John he tars everyone with the same old brush.
:laugh: Yes! Sometimes, I've seen him trying to get out a joke desparately, but then he gets out an old fart. But he's one of my fav CPians you see.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP