Smart programmers
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
No documentation whatsoever
Quite a common scenario - as with my current app. which I inherited. Plus zero code comments as well. :mad:
Kevin
-
Rajesh R Subramanian wrote:
No documentation whatsoever
Quite a common scenario - as with my current app. which I inherited. Plus zero code comments as well. :mad:
Kevin
Kevin McFarlane wrote:
Plus zero code comments as well.
No documentation? I can live with it. But come on! Code commenting is not *that* hard to do. I won't accept an excuse, whatsoever. Those bastards deserve a slow and painful death.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
Rajesh R Subramanian wrote:
I find this gem comment with relevant code:
Every Indian programmer has be redirected to Correct Forum[^] regardless of how many awards they receive. ;P :laugh:
"Sometimes the greatest journey is the distance between two people" - Nice quote from a Nice Indian Movie
And some Indian programmers are so hopelessly clueless that they can't tell the difference between a programming question and a programming rant.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
Before you took the job did you ask to see the team and look at the code you'll be working on? I always do.
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
And some Indian programmers are so hopelessly clueless that they can't tell the difference between a programming question and a programming rant.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001 -
Kevin McFarlane wrote:
Plus zero code comments as well.
No documentation? I can live with it. But come on! Code commenting is not *that* hard to do. I won't accept an excuse, whatsoever. Those bastards deserve a slow and painful death.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
Those bastards deserve a slow and painful death.
I agree. :) Management and/or Team Leader ought to keep on top of that sort of thing. Ideally there should be code reviews but in environments where there isn't (the vast majority) there should at least be some minimal standards.
Kevin
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001John Simmons / outlaw programmer wrote:
All Indians look the same
Are you confusing India with Japan? :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
norm .net wrote:
look at the code you'll be working on? I always do.
They let you look at what is probably proprietary code before you've signed the contract? You must look very trustworthy!
I'm not being picky here, but you can hardly copy the system by glancing a page of code :wtf:. I always ask to see the system and the codebase I'll be working on, it saves you and the future employer at lot of time when it comes to the start date and you don't feel it's the job for you on day one after looking at the code.
-
norm .net wrote:
did you ask to see the team
What good would that do? All Indians look the same, so it would be like looking in a mirror.
"Why don't you tie a kerosene-soaked rag around your ankles so the ants won't climb up and eat your candy ass..." - Dale Earnhardt, 1997
-----
"...the staggering layers of obscenity in your statement make it a work of art on so many levels." - Jason Jystad, 10/26/2001John Simmons / outlaw programmer wrote:
so it would be like looking in a mirror.
I hope not Johnny Boy, I'm not Indian :rolleyes:.
-
John Simmons / outlaw programmer wrote:
All Indians look the same
Are you confusing India with Japan? :)
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
:laugh: don't matter to John he tars everyone with the same old brush.
-
I'm not being picky here, but you can hardly copy the system by glancing a page of code :wtf:. I always ask to see the system and the codebase I'll be working on, it saves you and the future employer at lot of time when it comes to the start date and you don't feel it's the job for you on day one after looking at the code.
norm .net wrote:
you can hardly copy the system by glancing a page of code
But to make the decision, you surely need to see quite a more than one page anyway?
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
needs more comments... "well... duh!" after invalid session and "I hate DST" after the lines shown... ;P hehehe, sorry... just had to.... ;)
-
:laugh: don't matter to John he tars everyone with the same old brush.
:laugh: Yes! Sometimes, I've seen him trying to get out a joke desparately, but then he gets out an old fart. But he's one of my fav CPians you see.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
-
:laugh: Yes! Sometimes, I've seen him trying to get out a joke desparately, but then he gets out an old fart. But he's one of my fav CPians you see.
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
But he's one of my fav CPians you see.
I like Johns, straight to the point - no holds barred attitude.
-
norm .net wrote:
you can hardly copy the system by glancing a page of code
But to make the decision, you surely need to see quite a more than one page anyway?
You can get a gist of whats in store, especially if you see i,j,k and lacking any OO, I've asked to see code many at time and have never been refused (yet).
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Bah! Tell 'em to dump it for a REAL mawnnster framework[^]! :)
¡El diablo está en mis pantalones! ¡Mire, mire! Real Mentats use only 100% pure, unfooled around with Sapho Juice(tm)! SELECT * FROM User WHERE Clue > 0 0 rows returned Save an Orange - Use the VCF! VCF Blog
-
Before you took the job did you ask to see the team and look at the code you'll be working on? I always do.
norm .net wrote:
Before you took the job did you ask to see the team and look at the code you'll be working on? I always do.
Never been in a position to see the code before officially joining the team, but it may be good - after all I have never seen a code base I like :)
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
I feel your pain...Espesially about the not documentaion. Not a single page. 1000s of source files, but no documents. Not. Even. One.
-
So, after I've joined my new employer, they welcomed me with an incomplete mawnnster framework, written in C++. No documentation whatsoever, multi threaded, expected to run on more than one operating system, friendly variable names like
s,t(this is a string),pp1,pp2, etc., A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code://A day has passed by... this must be definitely an invalid session
if(m_thisDay != date.T_day)
Disconnect(SESSION_PREV, FORCE);And this is just the beginning :((
Nobody can give you wiser advice than yourself. - Cicero .·´¯`·->Rajesh<-·´¯`·. Codeproject.com: Visual C++ MVP
Rajesh R Subramanian wrote:
A complaint was that the connection drops out exactly at 12 in the night. Half a day is gone and then I find this gem comment with relevant code:
I know it won't make you feel better, but this is a common problem here. One of the most common time formats we accept is time since midnight with a some nanosecond level of accuracy I always forget.... anyhow, because the time includes no date, you sometimes have to do a little extra math when it comes to elapsed time... or not as in some cases.
elapsedTime=currentTime-lastTime; // get elapsed time since last pass if (elapsedTime<0) exit(1); // we passed midnight, panic, exit!That is more common than you would believe, sometimes even with the comments intact. Of course worse still are those who leave off the if statement at all, and accept time as gospel. When you see time move backwards in data review, you know someone forgot to handle the midnight roll-over. :sigh: Of all the time errors you can imagine, midnight roll-over I have fixed more often than any other. :sigh:_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."