"team" work
-
D. Talk to the original author about the class if possible.
John
Both of us gave up on that. His way is right and the company is wrong. I tried to convince him to try to change the SOP, but it is too much red tape to do what you should have done anyhow. I think the current plan is to change everything to nonSOP and then convince management it will cost less to fix the SOP than to conform the code.... but ONE programmer keeps adding to the workload by writing SOP code he has to change. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
how is a code review, a threat ? I wish more people did it. I submitted some code yesterday, it was reviewed overnight and now I know better how to fit in with the team I am working with. How is that an issue ? If code review is a threat, then it's being done wrong.
Christian Graus Driven to the arms of OSX by Vista.
-
Well as you well know there's the right way and the wrong way and no other way.
"It's so simple to be wise. Just think of something stupid to say and then don't say it." -Sam Levenson
no. There is the way your bosses or your customers tell you to do it. If you don't like it, you try to convince them to change. Not blackmail them into changing. :) I just want the SOP to reflect the code. I have no interest in right or wrong. We get graded on conformance to our own standards. Right now that grade is about 50% or less. how in the hell does one flunk the standards your own company puts forth? at least if we change the SOP we all have the same reference.
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
how is a code review, a threat ? I wish more people did it. I submitted some code yesterday, it was reviewed overnight and now I know better how to fit in with the team I am working with. How is that an issue ? If code review is a threat, then it's being done wrong.
Christian Graus Driven to the arms of OSX by Vista.
Christian Graus wrote:
how is a code review, a threat ?
Maybe it's a threat because there's one guy on the team that believes if he didn't write the code, it's wrong and will destroy the code in the review. Plus, maybe the managers believe what he says is law. So, maybe all code reviews result in the code being needlessly rewritten. Having to rewrite perfectly (and probably correct and efficient) code makes developers angry and frustrated and makes code reviews dreaded ordeals. Not that I've gone through any of that or anything.
Don't blame me. I voted for Chuck Norris.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
I don't envy you at all, El. Since you're asking this question I'm guessing that your SOP doesn't cover this in any way. Ours at work does. It's quite simple: all new code must be written to the current standards, if you are updating existing code then the method(s) you are updating should be rewritten to match the current standards. So, based on what I know to do, I would suggest A. However, you should probably put some comments in saying why you rewrote it. Just my 2 pesos, feel free to ignore it.
Don't blame me. I voted for Chuck Norris.
-
I don't envy you at all, El. Since you're asking this question I'm guessing that your SOP doesn't cover this in any way. Ours at work does. It's quite simple: all new code must be written to the current standards, if you are updating existing code then the method(s) you are updating should be rewritten to match the current standards. So, based on what I know to do, I would suggest A. However, you should probably put some comments in saying why you rewrote it. Just my 2 pesos, feel free to ignore it.
Don't blame me. I voted for Chuck Norris.
actually the SOP does cover this. It is just fewer and fewer programmers are following the SOP. I am about to be the last. :) so the need is to make the decision while its still near 50:50 do we change the code to matche SOP or the SOP to match newer programmers refusal to match it?
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
actually the SOP does cover this. It is just fewer and fewer programmers are following the SOP. I am about to be the last. :) so the need is to make the decision while its still near 50:50 do we change the code to matche SOP or the SOP to match newer programmers refusal to match it?
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
SOPs exist for a reason. At my previous job I was constantly getting in "discussions" with other members of management because they wouldn't follow the policies set forth by the company and I would. It actually makes your job harder if you're the only one who follows the rules. I am a firm believer in following the rules. Developers that don't follow the SOP are compromising the integrity of the team, the integrity of the product, and the company's profits. I say 100%, without a doubt, change the code to match SOP.
Don't blame me. I voted for Chuck Norris.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
Do the things the right way, if the original code was crappy replace it, with your good code. As long as your are really sure the original code is crappy, and your is better, the boss won't mind, I can tell
-
Christian Graus wrote:
If code review is a threat, then it's being done wrong.
At the least, the concept that a code review is a threat suggests an unhealthy corporate culture.
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
unhealthy corporate culture.
In the overwhelming majority of companies that I have worked for, it was the norm for a corporate culture to be unhealthy. If you stand back and look at the whole picture, you're surprised beyond belief as to how the heck is the company actually running successfully?
Don't forget to vote if the response was helpful
Sig history "dad" Ishmail-Samuel Mustafa Unix is a Four Letter Word, and Vi is a Two Letter Abbreviation "There is no wealth like knowledge, no poverty like ignorance" Ali Ibn Abi Talib
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
El Corazon? Are you a man or a marshmallow? Do your job to the best of your ability let "the cards" fall where they may.
Mac
-
Both of us gave up on that. His way is right and the company is wrong. I tried to convince him to try to change the SOP, but it is too much red tape to do what you should have done anyhow. I think the current plan is to change everything to nonSOP and then convince management it will cost less to fix the SOP than to conform the code.... but ONE programmer keeps adding to the workload by writing SOP code he has to change. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
It sounds like a case of a toxic coworker, a prima donna who has nothing to contribute to the team effort but discord. That individual needs to be served for Thanksgiving dinner - a turkey in developer clothing. Management has only two choices available, acknowledge his superior judgement and adopt his way as the SOP, or give him his walking papers, as he's a disruptive element that damages the efficiency of the entire organization. There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
-
It sounds like a case of a toxic coworker, a prima donna who has nothing to contribute to the team effort but discord. That individual needs to be served for Thanksgiving dinner - a turkey in developer clothing. Management has only two choices available, acknowledge his superior judgement and adopt his way as the SOP, or give him his walking papers, as he's a disruptive element that damages the efficiency of the entire organization. There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
Roger Wright wrote:
There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
why do you think I am trying to start my own company? ;)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
El Corazon? Are you a man or a marshmallow? Do your job to the best of your ability let "the cards" fall where they may.
Mac
Boolaboola wrote:
Are you a man or a marshmallow?
I already did my answer, I wasn't asking for permission, or advice. The cards already fell, thus it will be in code-review after our Early Dec release. :-D
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Roger Wright wrote:
There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
why do you think I am trying to start my own company? ;)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
I didn't know you were, but I'm glad to hear it. :-D
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
-
Both of us gave up on that. His way is right and the company is wrong. I tried to convince him to try to change the SOP, but it is too much red tape to do what you should have done anyhow. I think the current plan is to change everything to nonSOP and then convince management it will cost less to fix the SOP than to conform the code.... but ONE programmer keeps adding to the workload by writing SOP code he has to change. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
Isn's it a common practice to escalate issues that cannot be resolved at your level?
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
What does SOP mean?
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
A or B, but C for small changes, like changing or adding one or two lines.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
B and, if given enough time D D) Rewrite the class, following SOP. Unless the author owns the company, he/she doesn't owns the code so they should be grateful for me cleaning up their minor glitches:cool: /Jonas