"team" work
-
actually the SOP does cover this. It is just fewer and fewer programmers are following the SOP. I am about to be the last. :) so the need is to make the decision while its still near 50:50 do we change the code to matche SOP or the SOP to match newer programmers refusal to match it?
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
SOPs exist for a reason. At my previous job I was constantly getting in "discussions" with other members of management because they wouldn't follow the policies set forth by the company and I would. It actually makes your job harder if you're the only one who follows the rules. I am a firm believer in following the rules. Developers that don't follow the SOP are compromising the integrity of the team, the integrity of the product, and the company's profits. I say 100%, without a doubt, change the code to match SOP.
Don't blame me. I voted for Chuck Norris.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
Do the things the right way, if the original code was crappy replace it, with your good code. As long as your are really sure the original code is crappy, and your is better, the boss won't mind, I can tell
-
Christian Graus wrote:
If code review is a threat, then it's being done wrong.
At the least, the concept that a code review is a threat suggests an unhealthy corporate culture.
Jon Smith & Wesson: The original point and click interface
Oakman wrote:
unhealthy corporate culture.
In the overwhelming majority of companies that I have worked for, it was the norm for a corporate culture to be unhealthy. If you stand back and look at the whole picture, you're surprised beyond belief as to how the heck is the company actually running successfully?
Don't forget to vote if the response was helpful
Sig history "dad" Ishmail-Samuel Mustafa Unix is a Four Letter Word, and Vi is a Two Letter Abbreviation "There is no wealth like knowledge, no poverty like ignorance" Ali Ibn Abi Talib
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
El Corazon? Are you a man or a marshmallow? Do your job to the best of your ability let "the cards" fall where they may.
Mac
-
Both of us gave up on that. His way is right and the company is wrong. I tried to convince him to try to change the SOP, but it is too much red tape to do what you should have done anyhow. I think the current plan is to change everything to nonSOP and then convince management it will cost less to fix the SOP than to conform the code.... but ONE programmer keeps adding to the workload by writing SOP code he has to change. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
It sounds like a case of a toxic coworker, a prima donna who has nothing to contribute to the team effort but discord. That individual needs to be served for Thanksgiving dinner - a turkey in developer clothing. Management has only two choices available, acknowledge his superior judgement and adopt his way as the SOP, or give him his walking papers, as he's a disruptive element that damages the efficiency of the entire organization. There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
-
It sounds like a case of a toxic coworker, a prima donna who has nothing to contribute to the team effort but discord. That individual needs to be served for Thanksgiving dinner - a turkey in developer clothing. Management has only two choices available, acknowledge his superior judgement and adopt his way as the SOP, or give him his walking papers, as he's a disruptive element that damages the efficiency of the entire organization. There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
Roger Wright wrote:
There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
why do you think I am trying to start my own company? ;)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
El Corazon? Are you a man or a marshmallow? Do your job to the best of your ability let "the cards" fall where they may.
Mac
Boolaboola wrote:
Are you a man or a marshmallow?
I already did my answer, I wasn't asking for permission, or advice. The cards already fell, thus it will be in code-review after our Early Dec release. :-D
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
Roger Wright wrote:
There is no middle ground, and if management attempts to weasel out of making the decision, it's time to find another employer.
why do you think I am trying to start my own company? ;)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
I didn't know you were, but I'm glad to hear it. :-D
"A Journey of a Thousand Rest Stops Begins with a Single Movement"
-
Both of us gave up on that. His way is right and the company is wrong. I tried to convince him to try to change the SOP, but it is too much red tape to do what you should have done anyhow. I think the current plan is to change everything to nonSOP and then convince management it will cost less to fix the SOP than to conform the code.... but ONE programmer keeps adding to the workload by writing SOP code he has to change. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
Isn's it a common practice to escalate issues that cannot be resolved at your level?
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
What does SOP mean?
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
A or B, but C for small changes, like changing or adding one or two lines.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
B and, if given enough time D D) Rewrite the class, following SOP. Unless the author owns the company, he/she doesn't owns the code so they should be grateful for me cleaning up their minor glitches:cool: /Jonas
-
Oakman wrote:
unhealthy corporate culture.
In the overwhelming majority of companies that I have worked for, it was the norm for a corporate culture to be unhealthy. If you stand back and look at the whole picture, you're surprised beyond belief as to how the heck is the company actually running successfully?
Don't forget to vote if the response was helpful
Sig history "dad" Ishmail-Samuel Mustafa Unix is a Four Letter Word, and Vi is a Two Letter Abbreviation "There is no wealth like knowledge, no poverty like ignorance" Ali Ibn Abi Talib
-
What does SOP mean?
peterchen wrote:
What does SOP mean?
Standard Operating Procedure
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
-
how is a code review, a threat ? I wish more people did it. I submitted some code yesterday, it was reviewed overnight and now I know better how to fit in with the team I am working with. How is that an issue ? If code review is a threat, then it's being done wrong.
Christian Graus Driven to the arms of OSX by Vista.
Christian, I couldn't agree with you more. If your company uses it as a threat, then find a new company. (Or change your attitude. Ask for a review and use it as a chance to improve your design and code.) I wish my group had more code reviews/inspections. And, the more people reviewing it, the less chance there will be a bug when it goes to test. Also, more people would get to know my area and could help me with issues. There are even tools out there that make it easier for a team to do this, for example, Code Collaborator. I welcome the chance to have someone check my logic and coding style. Sometimes, the checker gives me useful ideas and new techniques. Other time, I have used the code review process as a teaching moment. I have used my code as an example in review meetings for teaching new techniques. As far as keeping the "company line" of coding practice, this is an important concept. If each programmer had his own different style of coding on the team, it would be difficult to understand and review. But, on the other side, I do find it difficult to find time to review someone else's code. Try to find the positive side of it, and also, take the time to review someone else's code, even your leader's or manager's code.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
I see below that you went for B. But why not first approach management and asking them what they recommend, rather than letting them intervene afterwards.
Kevin
-
What does SOP mean?
I'm glad you asked the question -- now I feel like less of an idiot for not knowing myself.
-
without naming names... ;-) how would you handle adding to someone else's class... as part of your assigned tasks... but that code does not follow company SOP. A) Fix the code to spec and thoroughly piss off the original author B) write all new routines in company spec format thus showing two different formats in the same code and thoroughly pissing off the original author but letting management deal with the solution. C) write non SOP code to match the original author and not pissing off the original author. :) I also want my sharks with fricken' laser beams for Christmas. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb) John Andrew Holmes "It is well to remember that the entire universe, with one trifling exception, is composed of others."
El Corazon wrote:
A) Fix the code to spec and thoroughly piss off the original author
Frack the original author. If his ego was too big to write it to spec, it's too big to avoid complaining about it...and get taken down a peg for not writing it to spec in the first place. However, if you do this, you'd better make NO mistakes whatsoever in the conversion.
-
The original author is the owner of the code.
xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 beta 1 - out now!
((lambda (x) `((lambda (x) ,x) ',x)) '`((lambda (x) ,x) ',x))leppie wrote:
The original author is the owner of the code.
Nonsense. The employer owns the code. The original author wrote the first take of the code, and if he hasn't twigged onto the fact that software is written on toilet paper, then he needs to get a clue. Now, I'll give a caveat - function should not be part of the coding standards. Example: standardizing on one sort algorithm is stupid. A code format standard, however, simply insures that everyone in the organization can expect to read anyone's code without having to allow for umpteen variations in indentation, block marking, etc.