var
-
So, there's been a lot of posts about whether var (C# thingy, for those non-C# folks) is good, bad, or just ugly. Well, I can deal with:
var foo = new List();as an example, because it's obvious what foo is. What I really hate is something like this:var foo = factory.CreateAFoo()That's where I despise seeing a "var"! MarcI'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner
Marc Clifton wrote:
var foo = factory.CreateAFoo() That's where I despise seeing a "var"!
That's where I despise seeing factories... ;) Think about it:
new List()obviously creates an instance ofList, hence the utility ofvar. You'd expect CreateAFoo() to create an instance of something namedFoo, thereby preserving the utility ofvar- since the author instead chose to return a list without indicating this anywhere in the method name, you're trapped, trapped like a rat, between the choice to write code that is verbose and code that is unclear. The problem hardly begins withvareither; your code becomes similarly opaque if you pass the result of the Create... call directly as a parameter to another method. -
It still bugs me that you can't write "new List" in C#, you have to write "new List()" But maybe I'm just a crusty old C++ guy. ;P
--Mike-- Dunder-Mifflin, this is Pam
Does the 'crusty old' relate to you or C++? ;P Use parentheses to disambiguate, young man - either (crusty old) (C++ guy) or (((crusty old) C++) guy)!
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
-
Marc Clifton wrote:
var foo = factory.CreateAFoo()
Meh, in your example
foois eitherFooorIFoo. On a slightly related note: why on earth C# (or Java) need keywordnewin the first place? It is completely redundant.Nemanja Trifunovic wrote:
On a slightly related note: why on earth C# (or Java) need keyword new in the first place? It is completely redundant.
So objects can be null. So you can control where an object is declared ( as in, if they are a member, etc ), and also control when you pay the cost of creating them.
Christian Graus Driven to the arms of OSX by Vista. Read my blog to find out how I've worked around bugs in Microsoft tools and frameworks.
-
So, there's been a lot of posts about whether var (C# thingy, for those non-C# folks) is good, bad, or just ugly. Well, I can deal with:
var foo = new List();as an example, because it's obvious what foo is. What I really hate is something like this:var foo = factory.CreateAFoo()That's where I despise seeing a "var"! MarcI'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner
What if
CreateAFoo()returns something ridiculous likeIEnumerable<Dictionary<int, Dictionary<int, List<int>>>>?Adam Maras | Software Developer Microsoft Certified Professional Developer
-
Nemanja Trifunovic wrote:
On a slightly related note: why on earth C# (or Java) need keyword new in the first place? It is completely redundant.
So objects can be null. So you can control where an object is declared ( as in, if they are a member, etc ), and also control when you pay the cost of creating them.
Christian Graus Driven to the arms of OSX by Vista. Read my blog to find out how I've worked around bugs in Microsoft tools and frameworks.
I kind of like the "new" keyword, but technically it shouldn't be needed, unless I'm missing something. Just playing devil's advocate here...
With: List<string> myList = new List<string>();
Without: List<string> myList = List<string>();The parentheses would be enough to indicate that you're calling a constructor... I do think, though, that the "new" keyword keeps things clearer. There could be issues with functions named the same as classes, but that could technically be resolved with absolute references.
Proud to have finally moved to the A-Ark. Which one are you in? Developer, Author (Guardians of Xen)
-
So, there's been a lot of posts about whether var (C# thingy, for those non-C# folks) is good, bad, or just ugly. Well, I can deal with:
var foo = new List();as an example, because it's obvious what foo is. What I really hate is something like this:var foo = factory.CreateAFoo()That's where I despise seeing a "var"! MarcI'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner
Marc Clifton wrote:
var foo = factory.CreateAFoo() That's where I despise seeing a "var"!
So what you have here is
var foo = factory.CreateAPoo();"WPF has many lovers. It's a veritable porn star!" - Josh Smith
As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.
-
What if
CreateAFoo()returns something ridiculous likeIEnumerable<Dictionary<int, Dictionary<int, List<int>>>>?Adam Maras | Software Developer Microsoft Certified Professional Developer
public class MyRidiculousClass : IEnumerable<Dictionary<int, Dictionary<int, List<int>>>>
{
}Now
CreateAFoo()can return something legible :)Proud to have finally moved to the A-Ark. Which one are you in? Developer, Author (Guardians of Xen)
-
Marc Clifton wrote:
var foo = new List();
This is actually more typing than
List foo = new List();
so there it would be kinda useless too.
Wout
varwasn't created to reduce keystrokes, and should not be used as such. Developers should strive to type more keystrokes, not fewer. -
I kind of like the "new" keyword, but technically it shouldn't be needed, unless I'm missing something. Just playing devil's advocate here...
With: List<string> myList = new List<string>();
Without: List<string> myList = List<string>();The parentheses would be enough to indicate that you're calling a constructor... I do think, though, that the "new" keyword keeps things clearer. There could be issues with functions named the same as classes, but that could technically be resolved with absolute references.
Proud to have finally moved to the A-Ark. Which one are you in? Developer, Author (Guardians of Xen)
OK, I guess that would work. If the method was not generic, what if you had an object called List, AND a method called List in scope that returns a List ?
Christian Graus Driven to the arms of OSX by Vista. Read my blog to find out how I've worked around bugs in Microsoft tools and frameworks.
-
varwasn't created to reduce keystrokes, and should not be used as such. Developers should strive to type more keystrokes, not fewer.Huh? Isn't the point of var and anonymous types less typing? Otherwise one would type out all these types explicitly. Other than amount of typing I see no advantage in var.
Wout
-
Marc Clifton wrote:
var foo = new List();
This is actually more typing than
List foo = new List();
so there it would be kinda useless too.
Wout
Parding? I've looked and looked at your post and according to my count your code has one more letter than Marc's. So how can his be more typing than yourn?
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
-
OK, I guess that would work. If the method was not generic, what if you had an object called List, AND a method called List in scope that returns a List ?
Christian Graus Driven to the arms of OSX by Vista. Read my blog to find out how I've worked around bugs in Microsoft tools and frameworks.
Then there would have to be a standard rule to handle it, the same way the compiler handles ambiguous methods... Local gets priority over external, same assembly gets priority over referenced assembly... Anything that can't be resolved throws an error and forces you to prefix the class or namespace. (But again, just looking at the other side here - I think
newis a good thing)Proud to have finally moved to the A-Ark. Which one are you in? Developer, Author (Guardians of Xen)
-
Parding? I've looked and looked at your post and according to my count your code has one more letter than Marc's. So how can his be more typing than yourn?
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
Well, at least in VS it is... as soon as you type "new " the autocompletion will happen. So you'll type "List" just once, whereas when using var you have to type the extra var.
Wout
-
Well, at least in VS it is... as soon as you type "new " the autocompletion will happen. So you'll type "List" just once, whereas when using var you have to type the extra var.
Wout
OK. Now I understand. :)
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
-
Marc Clifton wrote:
var foo = factory.CreateAFoo() That's where I despise seeing a "var"!
So what you have here is
var foo = factory.CreateAPoo();"WPF has many lovers. It's a veritable porn star!" - Josh Smith
As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes.
That would be a mess...
If the post was helpful, please vote, eh! Current activities: Book: Devils by Fyodor Dostoyevsky Project: Hospital Automation, final stage Learning: Image analysis, LINQ Now and forever, defiant to the end. What is Multiple Sclerosis[^]?
-
Huh? Isn't the point of var and anonymous types less typing? Otherwise one would type out all these types explicitly. Other than amount of typing I see no advantage in var.
Wout
No.
-
Does the 'crusty old' relate to you or C++? ;P Use parentheses to disambiguate, young man - either (crusty old) (C++ guy) or (((crusty old) C++) guy)!
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
Stuart Dootson wrote:
Does the 'crusty old' relate to you or C++?
It works either way. :-D
Stuart Dootson wrote:
(((crusty old) C++) guy)!
Do we allow Lisp in here now? ;)
--Mike-- Dunder-Mifflin, this is Pam
-
No.
Yes.
Wout
-
So, there's been a lot of posts about whether var (C# thingy, for those non-C# folks) is good, bad, or just ugly. Well, I can deal with:
var foo = new List();as an example, because it's obvious what foo is. What I really hate is something like this:var foo = factory.CreateAFoo()That's where I despise seeing a "var"! MarcI'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner
Marc Clifton wrote:
var foo = factory.CreateAFoo() That's where I despise seeing a "var"!
Well if both the variable and the factory method are named properly, I don't think there'd be any confusion here. If they are not, then using var would be the least of the issues here.
Regards, Nish
Nish’s thoughts on MFC, C++/CLI and .NET (my blog)
My latest book : C++/CLI in Action / Amazon.com link -
Huh? Isn't the point of var and anonymous types less typing? Otherwise one would type out all these types explicitly. Other than amount of typing I see no advantage in var.
Wout
no, the point was more to be able to have anonymous types and also in foreach and other like constructs where the type info can be combersomely unwieldy to have something more readable and understandable.