10 Commandments
-
peterchen wrote:
That seems awfully low
Not in the Java/C#/Linq world. For instance, in my code base of around 100,000 Lines, the maximum number of lines in a manually written method is 28. I think 25-30 is a reasonable maximum. Some Java frameworks have as much as 15 as the maximum.
Rama Krishna Vavilala wrote:
I think 25-30 is a reasonable maximum.
I hate large methods as much as the next guy, but in several cases, I have methods running to almost 200 lines. On the code base I'm working on, it seems counter-intuitive to break it up to several methods.
If the post was helpful, please vote, eh! Current activities: Book: Devils by Fyodor Dostoyevsky Project: Hospital Automation, final stage Learning: Image analysis, LINQ Now and forever, defiant to the end. What is Multiple Sclerosis[^]?
-
I have been asked to work on our Code Review Procedure. This sort of thing: Pascal casing used for type and method names Camel casing used for local variable names and method arguments ... A single file should only contribute types to a single namespace. Avoid having multiple namespaces in the same file. Avoid files with more than 500 lines (excluding machine-generated code). Avoid methods with more than 25 lines. ... Never hard-code a numeric value, always declare a constant instead. ... I have the feeling it is missing what really make maintenance go bad. Things like re use existing classes, don't duplicate code, separate logic, data access, and display. Can anyone point me to some documents with good recommendations of this type. The idea is to minimize defect and certainly not to alienate the programmers (including me).
Pascal Ganaye wrote:
Never hard-code a numeric value, always declare a constant instead.
Yikes! What about
if errors.Count() > 0? Surely I don't need a ZERO_ONLY_ZERO constant? :~ -
Look into tools like FxCop, StyleCop and ReSharper. These should take care of formatting and redundant code and things like that. Once you are done with doing all this look into the logic if it adheres to the requirement.
+100 ReSharper. I just love that software
If the post was helpful, please vote, eh! Current activities: Book: Devils by Fyodor Dostoyevsky Project: Hospital Automation, final stage Learning: Image analysis, LINQ Now and forever, defiant to the end. What is Multiple Sclerosis[^]?
-
Rama Krishna Vavilala wrote:
I think 25-30 is a reasonable maximum.
I hate large methods as much as the next guy, but in several cases, I have methods running to almost 200 lines. On the code base I'm working on, it seems counter-intuitive to break it up to several methods.
If the post was helpful, please vote, eh! Current activities: Book: Devils by Fyodor Dostoyevsky Project: Hospital Automation, final stage Learning: Image analysis, LINQ Now and forever, defiant to the end. What is Multiple Sclerosis[^]?
Mustafa Ismail Mustafa wrote:
counter-intuitive to break it up to several methods.
That is where I normally take opinion of someone else. Someone, figures out a clever way, usually. The best way to break a method is in chunks of logic. The bad way is to do the following:
void Method()
{
Portion1();
Portion2();
Portion3();
} -
:wtf: I agree with most of the MS one... how'd that happen? :confused:
I agree with most of them, but one that really bugs me is:
for (int i=0; i<100; i++) { DoSomething(i); }I prefer:for (int i=0; i<100; i++) DoSomething(i);or:for (int i=0; i<100; i++)
{
DoSomething(i);
}With the last one, who knows what future statements may need to be added... Another one that bugs me is stating that 4 spaces should be used instead of Tab, sorry, Tab tab tab ;P
"The clue train passed his station without stopping." - John Simmons / outlaw programmer "Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon "Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
-
peterchen wrote:
That seems awfully low
Not in the Java/C#/Linq world. For instance, in my code base of around 100,000 Lines, the maximum number of lines in a manually written method is 28. I think 25-30 is a reasonable maximum. Some Java frameworks have as much as 15 as the maximum.
Hmm... I've checked a few of recent functions. Observations: It's C++, which has a notable overhead mostly for error handling. However, in most cases I don't see any benefit of breaking them up. One of them, quite simple by this project's standards, is 62 lines, there are 14 opening/closing braces, 6 full-line comments helping understand the code flow, and 11 empty lines to group "logic blocks" (each of the full-line comment is preceded by one). Breaking up the functionality (finding a best match) into three logical pieces was possible (Check A, Check B, Generate Diagnostics), but that would expose a lot of context. With the additional boilerplate, documentation and definition of the functions' contracts, I'd say I'd end up with worse code. Of course, being a C++ programmer, I could write that code in 25 lines, but you really don't want me to :rolleyes:
Agh! Reality! My Archnemesis![^]
| FoldWithUs! | sighist | µLaunch - program launcher for server core and hyper-v server. -
Mustafa Ismail Mustafa wrote:
counter-intuitive to break it up to several methods.
That is where I normally take opinion of someone else. Someone, figures out a clever way, usually. The best way to break a method is in chunks of logic. The bad way is to do the following:
void Method()
{
Portion1();
Portion2();
Portion3();
}Rama Krishna Vavilala wrote:
That is where I normally take opinion of someone else. Someone, figures out a clever way, usually. The best way to break a method is in chunks of logic.
Well yeah, and normally that's the way I'd prefer it to go, but sometimes, you've got your back to the wall...
Rama Krishna Vavilala wrote:
void Method() { Portion1(); Portion2(); Portion3(); }
X| :thumbsdown: I'll admit in my younger days I did that a few times until a friendly senior explained to me some of the facts of programming life.
If the post was helpful, please vote, eh! Current activities: Book: Devils by Fyodor Dostoyevsky Project: Hospital Automation, final stage Learning: Image analysis, LINQ Now and forever, defiant to the end. What is Multiple Sclerosis[^]?
-
I have been asked to work on our Code Review Procedure. This sort of thing: Pascal casing used for type and method names Camel casing used for local variable names and method arguments ... A single file should only contribute types to a single namespace. Avoid having multiple namespaces in the same file. Avoid files with more than 500 lines (excluding machine-generated code). Avoid methods with more than 25 lines. ... Never hard-code a numeric value, always declare a constant instead. ... I have the feeling it is missing what really make maintenance go bad. Things like re use existing classes, don't duplicate code, separate logic, data access, and display. Can anyone point me to some documents with good recommendations of this type. The idea is to minimize defect and certainly not to alienate the programmers (including me).
-
Hmm... I've checked a few of recent functions. Observations: It's C++, which has a notable overhead mostly for error handling. However, in most cases I don't see any benefit of breaking them up. One of them, quite simple by this project's standards, is 62 lines, there are 14 opening/closing braces, 6 full-line comments helping understand the code flow, and 11 empty lines to group "logic blocks" (each of the full-line comment is preceded by one). Breaking up the functionality (finding a best match) into three logical pieces was possible (Check A, Check B, Generate Diagnostics), but that would expose a lot of context. With the additional boilerplate, documentation and definition of the functions' contracts, I'd say I'd end up with worse code. Of course, being a C++ programmer, I could write that code in 25 lines, but you really don't want me to :rolleyes:
Agh! Reality! My Archnemesis![^]
| FoldWithUs! | sighist | µLaunch - program launcher for server core and hyper-v server.When I maintain someone's code, I will prefer to see CheckA(); CheckB(); GeneralDiagniostics(); Seeing that I may get an idea of what the method is doing even though I may be new to the team. However, it may become worse if you are passing lot of parameters around. The thing I like about such rules of enforcing maximum lines is programmers are made to think and when they think good solutions may emerge. The eventual aim is to have fewer methods and fewer classes in other words "less code". Less code less bugs.
-
Hmm... I've checked a few of recent functions. Observations: It's C++, which has a notable overhead mostly for error handling. However, in most cases I don't see any benefit of breaking them up. One of them, quite simple by this project's standards, is 62 lines, there are 14 opening/closing braces, 6 full-line comments helping understand the code flow, and 11 empty lines to group "logic blocks" (each of the full-line comment is preceded by one). Breaking up the functionality (finding a best match) into three logical pieces was possible (Check A, Check B, Generate Diagnostics), but that would expose a lot of context. With the additional boilerplate, documentation and definition of the functions' contracts, I'd say I'd end up with worse code. Of course, being a C++ programmer, I could write that code in 25 lines, but you really don't want me to :rolleyes:
Agh! Reality! My Archnemesis![^]
| FoldWithUs! | sighist | µLaunch - program launcher for server core and hyper-v server.peterchen wrote:
but you really don't want me to
May be if you apply factory pattern, your code may get simpler.:)
-
I have been asked to work on our Code Review Procedure. This sort of thing: Pascal casing used for type and method names Camel casing used for local variable names and method arguments ... A single file should only contribute types to a single namespace. Avoid having multiple namespaces in the same file. Avoid files with more than 500 lines (excluding machine-generated code). Avoid methods with more than 25 lines. ... Never hard-code a numeric value, always declare a constant instead. ... I have the feeling it is missing what really make maintenance go bad. Things like re use existing classes, don't duplicate code, separate logic, data access, and display. Can anyone point me to some documents with good recommendations of this type. The idea is to minimize defect and certainly not to alienate the programmers (including me).
I would echo the posters who suggested that the enforcement of coding guidelines should be largely automated with FxCop and StyleCop. That said, you still need a reference for learning the guidelines, and Design guidelines for Class library Developers[^] on MSDN provides a complete set that is likely to be compatible with FxCop and StyleCop, and which is updated with each new release of Visual Studio.
-
Tab characters (\0x09) should not be used in code. All indentation should be done with 4 space characters.
Why?
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
-
Mustafa Ismail Mustafa wrote:
counter-intuitive to break it up to several methods.
That is where I normally take opinion of someone else. Someone, figures out a clever way, usually. The best way to break a method is in chunks of logic. The bad way is to do the following:
void Method()
{
Portion1();
Portion2();
Portion3();
} -
I agree with most of them, but one that really bugs me is:
for (int i=0; i<100; i++) { DoSomething(i); }I prefer:for (int i=0; i<100; i++) DoSomething(i);or:for (int i=0; i<100; i++)
{
DoSomething(i);
}With the last one, who knows what future statements may need to be added... Another one that bugs me is stating that 4 spaces should be used instead of Tab, sorry, Tab tab tab ;P
"The clue train passed his station without stopping." - John Simmons / outlaw programmer "Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon "Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
Why even have a main body inside the for loop? Why not:
int i = 0; while (i < 100 && ReturnTrue(new MethodInvoker(delegate { DoSomething(i++); }))) ;
:rolleyes:
-
Tab characters (\0x09) should not be used in code. All indentation should be done with 4 space characters.
Why?
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
Because tabs are ambiguous. When viewed with tabs set to, say, 5 spaces, the comments might be misaligned. The IDE can handle spaces like tabs (more or less), so probably best to use those.
-
Tab characters (\0x09) should not be used in code. All indentation should be done with 4 space characters.
Why?
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
So the code looks "good", even if your colleague has different tabs setup. I don;t agree with this theory, but I canunderstand it. Iain.
I have now moved to Sweden for love (awwww).
-
Tab characters (\0x09) should not be used in code. All indentation should be done with 4 space characters.
Why?
The narrow specialist in the broad sense of the word is a complete idiot in the narrow sense of the word. Advertise here – minimum three posts per day are guaranteed.
Why are you asking me? I didn't write them! :) Actually, this is one that I tend to agree with. My reasoning is possibly no longer valid with advances in IDEs/Editors (smart tabs etc.) but historically the different editors used to treat tab characters differently. Some defaulted to 3 spaces, some 4 and some to think of a number. Additionally some of them were fixed at that setting whilst others allowed the user to set the value. The result of all this goodness could be that your code looked a dogs breakfast when viewed in different editors. Now if you are particular about how your code is laid out when working on it, and I am, using spaces gives more consistent results across the various editors.
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
-
When I maintain someone's code, I will prefer to see CheckA(); CheckB(); GeneralDiagniostics(); Seeing that I may get an idea of what the method is doing even though I may be new to the team. However, it may become worse if you are passing lot of parameters around. The thing I like about such rules of enforcing maximum lines is programmers are made to think and when they think good solutions may emerge. The eventual aim is to have fewer methods and fewer classes in other words "less code". Less code less bugs.
Rama Krishna Vavilala wrote:
Less code less bugs.
Now that is very debatable! It's a nice ideal but is simply not true. As peterchen said in one of his posts in this thread <paraphrase>as a c++ programmer he could write using less code, but would you want him to?</paraphrase> <aside>I originally typed that in as "he could write using less cod", now that IS something to aim for. :-D </aside> One of the few (IMHO) major problems with c/c++ is the opportunity for obscure bugs in such compressed code.
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
-
Rama Krishna Vavilala wrote:
Less code less bugs.
Now that is very debatable! It's a nice ideal but is simply not true. As peterchen said in one of his posts in this thread <paraphrase>as a c++ programmer he could write using less code, but would you want him to?</paraphrase> <aside>I originally typed that in as "he could write using less cod", now that IS something to aim for. :-D </aside> One of the few (IMHO) major problems with c/c++ is the opportunity for obscure bugs in such compressed code.
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
Henry Minute wrote:
compressed code
compressed code != less code. Also, by less code means less human written code. More code you write more likely bugs. Actually, it is not just something I made up. Studies (cited in Code Complete book which I do not have with me now) indicates that defects per 1000 lines of code increase as the code size grows. It is logical in the sense that it is difficult to handle code as it grows. Some steps to generate less code: 1. Use code generators (including C++ templates, generics) 2. Use standard tested libraries (as opposed to rewriting code) Also less code means the, less you have to look at. So you can quickly figure out is something is wrong. Obviously, if something is obscure it defeats the purpose.
-
Rama Krishna Vavilala wrote:
void Method() { Portion1(); Portion2(); Portion3(); }Amateurs. It should be:
void Method() { Portion1(); Portion2(); Portion3(); }Wjousts wrote:
void Method() { Portion1(); Portion2(); Portion3(); }
A clear violation of the DRY principle! You should really have a loop that calls
InvokeMethodon Portion{i}.