Because THAT'S what we should be worrying about...
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
Don't tell her about the comments column associated with every table that Oracle has. She'd be losing sleep over that. :)
Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
-
Lead: "Ennis, I like your code but there are too many comments. We don't like our code base full of comments." Ennis: "If you don't like my comments you can remove them" Lead: "We expect you to follow out standards" Ennis: "Fire me" They never did. The bottom line is the incompetent don't like quality because it removes their importance but what they don't like more than quality is waves. Stand-up for yourself, and donate $0.25 to pay for 1 gig of comments to cover the entire teams comments for a century.
Need custom software developed? I do custom programming based primarily on MS tools with an emphasis on C# development and consulting. I also do Android Programming as I find it a refreshing break from the MS. "And they, since they Were not the one dead, turned to their affairs" -- Robert Frost
Your statement on quality is kind of how I feel, but did not say (write) aloud. And comments are not even a standard here! After the discussion the standards were updated with "comments should be kept to a minimum." That's helpful.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
-
Haha I've actually encountered other developers under the delusion that comments slow the program down and wanting to delete them all prior to the compiled and build system going out!
Exactly! The compiler just ignores them. And are we really going to "fill up a server" with a few KBs of comments? Hope we don't buy any more assets--might not be enough room on the server to store those records!
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
Unless every few lines of code has ASCII art murals or you are commenting with things like "this is an if statement -- it provides the ability to conditionally execute a branch of code. A branch of code is...", I very much doubt you have too many comments. At my last job, everybody seemed to be opposed to any formatting or code comments.
-
Haha I've actually encountered other developers under the delusion that comments slow the program down and wanting to delete them all prior to the compiled and build system going out!
If the idiots who thought that knew anything about compilers, never mind. :doh:
That's called seagull management (or sometimes pigeon management)... Fly in, flap your arms and squawk a lot, crap all over everything and fly out again... by _Damian S_
-
I'll refrain from commenting. Don't want to fill up The Lounge. :)
Henry Minute Do not read medical books! You could die of a misprint. - Mark Twain Girl: (staring) "Why do you need an icy cucumber?" “I want to report a fraud. The government is lying to us all.”
Any further comment would be, well, superfluous.
Software Zen:
delete this; -
For some reason, I imagine you to be someone like the fictional Carrie Heffernan :-D
Regards, Nish
Blog: blog.voidnish.com
I had to look that one up--never watched King of Queens. On Wikipedia, the end of the article states: Carrie is a fierce and sarcastic character and is frequently deemed as scary by other characters... Yep, that would be me. :laugh:
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
Just delete all the CRLF and make it one long line. you wouldn't want to waste space on returns and such. :rolleyes:
That's called seagull management (or sometimes pigeon management)... Fly in, flap your arms and squawk a lot, crap all over everything and fly out again... by _Damian S_
-
Don't tell her about the comments column associated with every table that Oracle has. She'd be losing sleep over that. :)
Chris Meech I am Canadian. [heard in a local bar] In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
Yeah, she might decide to nip it in the bud and put a trigger on that column that erases any comments that are inserted.
-
Exactly! The compiler just ignores them. And are we really going to "fill up a server" with a few KBs of comments? Hope we don't buy any more assets--might not be enough room on the server to store those records!
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
If there is enough code to fill up the server, it would probably be good to have enough code comments to explain that giant mess.
-
Girls at work! *ducks*
Agh! Reality! My Archnemesis![^]
| FoldWithUs! | sighist | WhoIncludes - Analyzing C++ include file hierarchy -
Any further comment would be, well, superfluous.
Software Zen:
delete this;I agree wholeheartedly. I won't comment here either.
-
Just delete all the CRLF and make it one long line. you wouldn't want to waste space on returns and such. :rolleyes:
That's called seagull management (or sometimes pigeon management)... Fly in, flap your arms and squawk a lot, crap all over everything and fly out again... by _Damian S_
-
I had to look that one up--never watched King of Queens. On Wikipedia, the end of the article states: Carrie is a fierce and sarcastic character and is frequently deemed as scary by other characters... Yep, that would be me. :laugh:
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
never watched King of Queens
You should. You will like Carrie's character :-)
Regards, Nish
Blog: blog.voidnish.com
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
The only time you have too many comments is when they start getting riciculous. For example:
//Declare variable
int a;But apart from that the more verbose the better (usually).
My current favourite word: Harsh!
-SK Genius
-
She's passive-aggressive, and I have thought of doing this, to give her a taste of her own negativity.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
So here's the plan:- Cntrl X all the comments, and replace them with a code using 0 -> 9, A -> Z and a -> z. This will give you close to 240,000 references using just 3 characters for each comment. Next, type the code into a spreadsheet, and paste the text of the comment next to it. When all the comments have been entered into the spreadsheet, sort the sheet alphabetically on the comment text. Print it all out, and delete the spreadsheet, so it doesn't take up any space. Present the DBA with the sole printout, and suggest she photocopies it. ... and then you pray that you never have to maintain the code yourself. But hey, you can't have everything! :laugh:
-
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS.
Someone holding a post like DBA (even if a female) can't be that dumbo, you might need to check if something else by you pissed her up.
leckey wrote:
too many comments will just fill up the server.
If this is true then her tiny brain is already filled up with s***. Some* girls do not require qualification, eligibility or qualities to held their post, you better know why ;)
WJFK (Write Just for Kicks)
-
I concur! Now stop ducking.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
*peeks out carefully*
Agh! Reality! My Archnemesis![^]
| FoldWithUs! | sighist | WhoIncludes - Analyzing C++ include file hierarchy -
Okay, so been at the new job for about 6 months. Oracle is not my favorite, but it's work. I sent some code to the "code review" group and our very cranky DBA said she did not approve it because it had...drumroll...TOO MANY COMMENTS. WTF? Comments in code up until now has been non-existent and she's worried that too many comments will just fill up the server. This coming from an Oracle DBA who has not recreated any indexes on tables in over 6 years (oh and I've found dozens that need it) and this is what she wants to kvetch about? Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
Yeah, I need to update this. Darn Judge Judy reruns! http://CraptasticNation.blogspot.com/[^]
leckey wrote:
Has anyone ever run across "too many comments" before? I've only heard "not enough" in the past.
I've met some very competent programmers who believe the code should speak for itself and the comments do more harm than good. Personally, I don't buy it...
-
So here's the plan:- Cntrl X all the comments, and replace them with a code using 0 -> 9, A -> Z and a -> z. This will give you close to 240,000 references using just 3 characters for each comment. Next, type the code into a spreadsheet, and paste the text of the comment next to it. When all the comments have been entered into the spreadsheet, sort the sheet alphabetically on the comment text. Print it all out, and delete the spreadsheet, so it doesn't take up any space. Present the DBA with the sole printout, and suggest she photocopies it. ... and then you pray that you never have to maintain the code yourself. But hey, you can't have everything! :laugh:
I once joked with a friend that I would do that for job security. You want to see what these comments say? Then you need my reference sheet. ;P