while (*s++ = ((*t & 0x60) == 0x40 ? *t ^ 0x20 : *t)) t++;

[tom1443]

This looks like an job interview question, in which case I don't want the job.

[PHLIPH]

Yeah, converts to lower case is right - but don't forget it also does '@' => '`', '[' => '{', '\' => '|', ']' => '}', '^' => '-', and '_' => del. Just felt the need to punctuate it. :)

[neil hudson]

It corrupts strings with @ [ \ ] ^ and _ in them.

Neil Hudson

[Rosenne]

Only in America... I mean, only for US ASCII. :thumbsdown:

[yoni at jefco]

I was going to say "Hopefully get someone sacked". Maybe a bit harsh on my part.

[Matthew Barnett]

Larry G. Grimes wrote:

It definitely returns a string with all lowercase characters.

It'll change other characters too, such as '@' to '`'!

[Jonas Hammarberg]

Worked for ANSI to, albeit only the lower parts :rolleyes:

[Lev Vayner]

maybe the author should start writing normal code.. in c#, this would be done with s.ToLower() yeah.. thats it.. no non-sense pointer code with an inline loop referencing hex values

[Rosenne]

I the context of software, only as well as but generally mean a bug.

[stevee1984]

Maybe something like this would work better, then we can use the code for email addresses etc. while (*s++ = (*t >='A' && *t <= 'Z' ? *t ^ 0x20 : *t) ) t++;

[DominLondon]

Robbo!

[Rob Philpott]

Dude!

Regards, Rob Philpott.

[leonej_dt]

I will assume both s and t are char*. *t & 0x60: Filters all but two bits of *t. I will call those bits xy (the most significant one first). (*t & 0x60) == 0x40: Tests whether xy is 10. (*t & 0x60) == 0x40 ? *t ^0x20 : *t: If xy is 10, it returns a new character equal to *t, but with xy equal to 11. Otherwise, it returns the original character. The whole loop iterates through a C string starting at s and copies it to another C string starting at t, but characters from 0x40 to 0x5F are converted into characters from 0x60 to 07F. The original string is left untouched, unless s equals t. (If t points to another character actually inside the C string pointed by s or vice versa, the program goes crazy.) To the end user, this means the following: Uppercase characters are converted into lowercase characters, square brackets are converted into braces, the backslash is converted into a vertical line character, the French circumflex accent character is converted into the tilde character, and the underline character is converted into a DEL character.

If you can play The Dance of Eternity (Dream Theater), then we shall make a band.

[Atanas Palavrov]

This is trivial ToLover() ... well, if you know ASCII. This is better: while (*s++ = ((*t & ~0x1F) == 0x40 ? *t ^ 0x20 : *t)) t++; And this is more clear: #define mask (~('a'-'B')) while (*s++ = ((*t & mask == ('A' & mask) ? *t ^ ('a'-'A') : *t)) t++;

www.codigi.net .NET touch screen GUI components suite