Resharper! Grr.
-
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad:
-
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad:
RCoate wrote:
a good guy (for a South African).
Well, you being in Australia, it is pretty obvious the hatred he will have for you guys up to Sunday, and possibly beyond ;P
-
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad:
And don't forget to restore the previous version from source control before his eyes. Such tools can be useful if used with a little thought. If not, they simply are annoying. My Java friends (thank god this will be over for me next week) think that you can't write any good code without installing at least three or four checking tools and setting up every little thing to be an error. The real errors are hidden well in the resulting endless lists of complaints and, since you can safely ignore most errors and run that junk anyway, mostly causes the developers to be annoyed and care less about the quality of their code. Just yesterday I stumbled over an instance of a DAO - which was conjured into the frontend with the help of Spring. Such a breach of the layer architecture is a real horror worthy of the Hall of Shame (I think I will post that one), but of course the great tools cannot detect such things which can't be pressed into simple rules. That's why I prefer to think for myself and not simply rely on some tools to do it for me.
And from the clouds a mighty voice spoke:
"Smile and be happy, for it could come worse!"And I smiled and was happy
And it came worse. -
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad:
the only reason i use re-sharper is to match the braces and to pick colors on fly :P
-
the only reason i use re-sharper is to match the braces and to pick colors on fly :P
saxenaabhi6 wrote:
the only reason i use re-sharper is to match the braces
VS does that already...
-
RCoate wrote:
a good guy (for a South African).
Well, you being in Australia, it is pretty obvious the hatred he will have for you guys up to Sunday, and possibly beyond ;P
-
And don't forget to restore the previous version from source control before his eyes. Such tools can be useful if used with a little thought. If not, they simply are annoying. My Java friends (thank god this will be over for me next week) think that you can't write any good code without installing at least three or four checking tools and setting up every little thing to be an error. The real errors are hidden well in the resulting endless lists of complaints and, since you can safely ignore most errors and run that junk anyway, mostly causes the developers to be annoyed and care less about the quality of their code. Just yesterday I stumbled over an instance of a DAO - which was conjured into the frontend with the help of Spring. Such a breach of the layer architecture is a real horror worthy of the Hall of Shame (I think I will post that one), but of course the great tools cannot detect such things which can't be pressed into simple rules. That's why I prefer to think for myself and not simply rely on some tools to do it for me.
And from the clouds a mighty voice spoke:
"Smile and be happy, for it could come worse!"And I smiled and was happy
And it came worse.I tend to avoid refractoring another programmers code if they: a. Sit next to you. b. No one has asked for the refractor to be done. c. Have a different skill set. d. I have no idea why they wrote the code in the fist place. e. Sit next to you (I know - I said this twice cause it is kinda the point). I am kind of hot and cold with resharper. It can help tighten things up and is a good learning tool (good for things like lambda expressions), but it realy just changes existing code to look nice. The refractored code still just does the same things the ugly code already did.
-
I tend to avoid refractoring another programmers code if they: a. Sit next to you. b. No one has asked for the refractor to be done. c. Have a different skill set. d. I have no idea why they wrote the code in the fist place. e. Sit next to you (I know - I said this twice cause it is kinda the point). I am kind of hot and cold with resharper. It can help tighten things up and is a good learning tool (good for things like lambda expressions), but it realy just changes existing code to look nice. The refractored code still just does the same things the ugly code already did.
-
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad:
That's a failure of protocol. Never publish without testing the final build starts.
FILETIME to time_t
| FoldWithUs! | sighist | WhoIncludes - Analyzing C++ include file hierarchy -
I tend to avoid refractoring another programmers code if they: a. Sit next to you. b. No one has asked for the refractor to be done. c. Have a different skill set. d. I have no idea why they wrote the code in the fist place. e. Sit next to you (I know - I said this twice cause it is kinda the point). I am kind of hot and cold with resharper. It can help tighten things up and is a good learning tool (good for things like lambda expressions), but it realy just changes existing code to look nice. The refractored code still just does the same things the ugly code already did.
Is 'refractoring' intentional? If so, it's very clever, bringing in fractare = to break. I don't like refactoring tools. If I'm going to mess with some code, I think it's good for me to have to think about it and do it manually, to make sure it is the right thing to do. As you say, for the actual useful refactorings a tool won't do the job for you anyway.
-
There I was with a nice little web app embedded in our production CRM system. All the jQuery.AJAX calls worked nicely. It was a simple tool to do an annoying job easily. Along comes one of my "collegues", a talented programmer and a good guy (for a South African). He decides to run resharper over the code in the asmx.cs file - without telling me. Reshaper doesn't like parameter names that start with a capital, so he goes ahead and fixes that for me. All the parameters are now named likeThis when they were named LikeThis. Great. The asmx.cs file compiles, you can run the webservice fine. Excellent. What about the javascript library that references this stuff? No. Not even thought about. The application gets published, and forgotten about. The tool only gets used about once a year. Next time one of the users tries to run it (today), it breaks. Took all morning trawling through TFS to find out what the actual problem was (as said collegue is not in this week). Man is he going to get it when he shows his face next! GGGGGGRRRRRR!!!! :mad: :mad: :mad: