Pet Peeve

R Giskard Reventlov

Why are people so lazy? For example, how hard is it to

if (condition)
{
DoThis();
}
else
{
DoThat();
}

as opposed to:

if (condition)
DoThis();
else
DoThat();

Pedants :sigh:

Frank Alviani

They think they need to pay for each character entered?

According to my calculations, I should be able to retire about 5 years after I die.

Lost User

I know what you're saying; however, there are times I find the second one easier to read. For example, if I have several of those on a page the extra symbols spread stuff out. I still do it the first way, but there are times when the second is easier for me to read.

Sander Rossel

And why couldn't you write

if (condition)
{
this.DoThis();
}
else
{
this.DoThat();
}

Now this code is totally unambiguous :) Although I know some people who really hate this...

My blog[^]

public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}

Jeremy Falcon

I'm not lazy, but I'll still use the latter. There's no point in always having to use a bracket so I don't, unless it makes things easier to read. Which in your example it doesn't. Wasting space just makes a source code file longer anyway and harder to navigate. Concise wins, unless it's hard to read.

Jeremy Falcon

Tom Clement

If their functions are really long :(, they can see more of it on one screen that way.

Tom Clement articles[^]

Jeremy Falcon

Exactly.

Jeremy Falcon

Maximilien

Cool, Religious war in the Lounge!!! :rolleyes:

I'd rather be phishing!

Mike Hankey

What exactly is a peeve? and how do you train it? I prefer the second method as a matter of style and space. To each his/her own!

New version: WinHeist Version 2.1.0 There's a fine line between crazy and free spirited and it's usually a prescription. I'm currently unsupervised, I know it freaks me out too but the possibilities are endless.

Chris Losinger

it doesn't make anything easier to read, and it definitely makes things harder to maintain.

image processing toolkits | batch image processing

Dan Neely

In a coding standard that put's {'s on their own line I prefer this:

if (condition)
DoThis();
else DoThat();

If you're putting the { on the previous line, IMO they're easy enough to overlook that the explicit closing } is needed. And if you're writing javascript :(( the opening { is obligate and this:

if (condition) { DoThis();
} else {DoThat();}

or this:

if (condition) DoThis() else DoThat();

are obscenities. X|

Did you ever see history portrayed as an old man with a wise brow and pulseless heart, waging all things in the balance of reason? Is not rather the genius of history like an eternal, imploring maiden, full of fire, with a burning heart and flaming soul, humanly warm and humanly beautiful? --Zachris Topelius Training a telescope on one’s own belly button will only reveal lint. You like that? You go right on staring at it. I prefer looking at galaxies. -- Sarah Hoyt

Ian Shlasko

It's not laziness. The second one is quicker and easier to read IF the condition and the branched commands are short. As soon as any of those lines gets the slightest bit complicated, or if there's any nesting at all, I add the braces.

Proud to have finally moved to the A-Ark. Which one are you in?
Author of the Guardians Saga (Sci-Fi/Fantasy novels)

R Giskard Reventlov

I have to { disagree. } I prefer the verbosity and clarity that the braces bring to the code.

Jeremy Falcon wrote:

Concise wins, unless it's hard to read.

Which is usually what happens. People that use the latter form also tend to be the ones that crush every line together so that you first have to separate to properly understand. Is there a lack of space on your screen? In any case a method bigger than a screen is just plain fugly. :)

Jeremy Falcon

Karel Čapek wrote:

I prefer the verbosity and clarity that the braces bring to the code.

You should try VB then.

Jeremy Falcon

Ian Shlasko

That's not good enough...

if
(
condition
)
{
this
.
DoThis
(
)
;
}
else
{
this
.
DoThat
(
)
;
}

It's not properly formatted until there's only one token per line. :)

Proud to have finally moved to the A-Ark. Which one are you in?
Author of the Guardians Saga (Sci-Fi/Fantasy novels)

Jeremy Falcon

Chris, you can't BS me, come on man. You honestly expect me to buy that not using brackets for a single-line if condition makes code harder to maintain? Seriously? Where's the joke icon?

Jeremy Falcon

Jeremy Falcon

Ian Shlasko wrote:

As soon as any of those lines gets the slightest bit complicated, or if there's any nesting at all, I add the braces.

:thumbsup:

Jeremy Falcon

R Giskard Reventlov

Heathen! Blasphemer! How do you even know that VB uses braces???

Jeremy Falcon

Oooooooo, look at how easy that is to maintain now!! :drool:

Jeremy Falcon

Jeremy Falcon

Ha. Well you see... I work for the devil, but it's only because I'm evil.

Jeremy Falcon