Pet Peeve

Andy Brummer

The rule that I have is that you omit the braces iff the statement is a simple single line. Also, if either branch needs braces then both get them, and loops always have braces.

Curvature of the Mind now with 3D

Chris Losinger

but that's the start of the problem! someday, someone is going to have to come along and add some more logic in that if, and you've just forced them to do the work you should've done the first time! IMO

image processing toolkits | batch image processing

Andy Brummer

I understand your point of view, but still prefer my way of doing things. What I find more troubling is that after working on a bunch of javascript, I'm starting to prefer the old school C style brace layout.

Curvature of the Mind now with 3D

Paulo Zemek

I don't do if() and the code in the same line. It is more a debug stuff. If I want to debug the if itself I put the breakpoint in that line. If I only want to debug the method call, after the if succeeded, I put the breakpoint in the call line.

Brady Kelly

This is true. I always use separate lines for everything myself, but all I was saying is I find if (if stuff) [then stuff]; on one line more readable, in established and (hopefully) debugged code. If I have to debug it myself, I just hit enter and add a breakpoint on the new line. Then use the "source control undo" in solution explorer to revert back to the prior pristine state.

No object is so beautiful that, under certain conditions, it will not look ugly. - Oscar Wilde

Mark_Wallace

If there's only one "do", the whole thing should be on one line. The reason the blocks were introduced is because multiple "do"s on one line are hard to read, so insisting that a single "do" be in a block is taking the idea in the wrong direction.

I wanna be a eunuchs developer! Pass me a bread knife!

BillWoodruff

Yes, I am sure for your disciples that's a very good thing :)

«OOP to me means only messaging, local retention and protection and hiding of state-process, and extreme late-binding of all things. » Alan Kay's clarification on what he meant by the term "Object" in "Object-Oriented Programming."

BillWoodruff

Perhaps best to blame the language designers for allowing such freedom ? I'm with Chris L. and others who point out we're no longer in the age of fewer-characters-are-best-because-memory's-so-precious that we can't afford white-space, or beaucoup de braces. C# code that looks like VB has the smell of sewage to me (note: I do not "hate" VB).

«OOP to me means only messaging, local retention and protection and hiding of state-process, and extreme late-binding of all things. » Alan Kay's clarification on what he meant by the term "Object" in "Object-Oriented Programming."

Paulo Zemek

I understand... and I can't say I disagree... that arrives to the point of preference, not to the point of usefulness. But one thing I never do is 2 (or more) real calls in the same line: SomeObject.DoCallOne().DoCall2(otherObject.AnotherCallWithAResult(), evenAnotherObject.WithEvenAnExtraCall(), theFinal.ObjectWithTheFinalCall());

Sandeep Singh Shekhawat

They think, If we write that way then our system will be heavy as each character has some byte. :) :) :) :-D

DJ van Wyk

How would you feel about

condition ? DoThis() : DoThat();

?

My plan is to live forever ... so far so good

JeremyBob

condition
? DoThis()
: DoThat();

And now? All in all none of this really matters. As long as everyone on the project sticks to a predetermined coding standard, then the format doesn't matter as much, as long as its consistent. Consistency in code can resolve a huge amount of misunderstanding.

Andy_L_J

The reason I moved from VB.NET to C# was the curly braces bro! Don't make me give up the curly braces! :laugh:

I don't speak Idiot - please talk slowly and clearly "I have sexdaily. I mean dyslexia. Fcuk!" Driven to the arms of Heineken by the wife

DJ van Wyk

Standard? STANDARD? What's that??? I found that we do keep to standards whenever all the other developers code exactly the same way as I do. ;P

My plan is to live forever ... so far so good

Matthys Terblanche

Totally agree...but for a very spesific reason. I'm using a Braille display with a maximum of 40 chars per line, so it have a influence on my format preferences... ;P Seriously though, if (condition) { Action1(); } else { Action2(); } is my real preference, and there's a plus to that, whenever the situation change to have more than one statement for the if test, the person who has to change it doesn't have to remember to go and fill in the {}.:cool:

Brady Kelly

Just your contrived example hurts my eyes. I'd hate to see that in real life. :~

No object is so beautiful that, under certain conditions, it will not look ugly. - Oscar Wilde

xiecsuk

Of course it is, or at least, it was. That's what we used to do when programming in APL. There were execution costs for each new line you used.

Jorgen Andersson

I don't care very much as long as it's consistent. But since you can't make multiple statements without braces...

Wrong is evil and must be defeated. - Jeff Ello (√-shit)2

Oleg A Lukin

That works fine until you get this in the code after all :)

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
	goto fail;
if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
	goto fail;
	goto fail;
if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
	goto fail;

When I first saw that bug I got even more convinced see that my approach to braces everywhere as a must works better in the end.

Banking establishments are more dangerous than standing armies. T.Jefferson

Johnny J

Either one of those suits me fine. The ones I can't stand are these:

if (condition)
{
DoThis();
}
else
DoThat();

if (condition)
DoThis();
else
{
DoThat();
}

Anything that is unrelated to elephants is irrelephant
Anonymous
-----
The problem with quotes on the internet is that you can never tell if they're genuine
Winston Churchill, 1944
-----
I'd just like a chance to prove that money can't make me happy.
Me, all the time