Pet Peeve

[Paulo Zemek]

I understand... and I can't say I disagree... that arrives to the point of preference, not to the point of usefulness. But one thing I never do is 2 (or more) real calls in the same line: SomeObject.DoCallOne().DoCall2(otherObject.AnotherCallWithAResult(), evenAnotherObject.WithEvenAnExtraCall(), theFinal.ObjectWithTheFinalCall());

[Sandeep Singh Shekhawat]

They think, If we write that way then our system will be heavy as each character has some byte. :) :) :) :-D

[DJ van Wyk]

How would you feel about

condition ? DoThis() : DoThat();

?

My plan is to live forever ... so far so good

[JeremyBob]

condition
? DoThis()
: DoThat();

And now? All in all none of this really matters. As long as everyone on the project sticks to a predetermined coding standard, then the format doesn't matter as much, as long as its consistent. Consistency in code can resolve a huge amount of misunderstanding.

[Andy_L_J]

The reason I moved from VB.NET to C# was the curly braces bro! Don't make me give up the curly braces! :laugh:

I don't speak Idiot - please talk slowly and clearly "I have sexdaily. I mean dyslexia. Fcuk!" Driven to the arms of Heineken by the wife

[DJ van Wyk]

Standard? STANDARD? What's that??? I found that we do keep to standards whenever all the other developers code exactly the same way as I do. ;P

My plan is to live forever ... so far so good

[Matthys Terblanche]

Totally agree...but for a very spesific reason. I'm using a Braille display with a maximum of 40 chars per line, so it have a influence on my format preferences... ;P Seriously though, if (condition) { Action1(); } else { Action2(); } is my real preference, and there's a plus to that, whenever the situation change to have more than one statement for the if test, the person who has to change it doesn't have to remember to go and fill in the {}.:cool:

[Brady Kelly]

Just your contrived example hurts my eyes. I'd hate to see that in real life. :~

No object is so beautiful that, under certain conditions, it will not look ugly. - Oscar Wilde

[xiecsuk]

Of course it is, or at least, it was. That's what we used to do when programming in APL. There were execution costs for each new line you used.

[Jorgen Andersson]

I don't care very much as long as it's consistent. But since you can't make multiple statements without braces...

Wrong is evil and must be defeated. - Jeff Ello (√-shit)2

[Oleg A Lukin]

That works fine until you get this in the code after all :)

if ((err = SSLHashSHA1.update(&hashCtx, &serverRandom)) != 0)
	goto fail;
if ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
	goto fail;
	goto fail;
if ((err = SSLHashSHA1.final(&hashCtx, &hashOut)) != 0)
	goto fail;

When I first saw that bug I got even more convinced see that my approach to braces everywhere as a must works better in the end.

Banking establishments are more dangerous than standing armies. T.Jefferson

[Johnny J]

Either one of those suits me fine. The ones I can't stand are these:

if (condition)
{
DoThis();
}
else
DoThat();

if (condition)
DoThis();
else
{
DoThat();
}

Anything that is unrelated to elephants is irrelephant
Anonymous
-----
The problem with quotes on the internet is that you can never tell if they're genuine
Winston Churchill, 1944
-----
I'd just like a chance to prove that money can't make me happy.
Me, all the time

[Mladen Jankovic]

Well I can't argue with that :)

Commodore 64 emulator for Windows Phone

[Jacquers]

And then there is the choice between: if (condition) vs if (condition == true) if (!condition) vs if (condition == false) I sometimes put in the == false part because the ! is easy to miss when reading.

[Fabio Franco]

Karel Čapek wrote:

Why are people so lazy?

Did it occur to you that it may be about style and not laziness? Some people can have even another style:

if (condition) DoThis();
else DoThat();

To alcohol! The cause of, and solution to, all of life's problems - Homer Simpson ---- Our heads are round so our thoughts can change direction - Francis Picabia

[Daniel Vaughan]

It's slower to read an if statement with code on the same line because your eyes have to track to the right. It's the same reason why you shouldn't place form titles and fields on the same line. Here's some articles on it: http://www.uxmatters.com/mt/archives/2006/07/label-placement-in-forms.php[^] http://uxmag.com/articles/eye-tracking-and-web-usability-a-good-fit[^]

Daniel Vaughan Twitter | Blog | Microsoft MVP | Projects: Calcium SDK, Clog | LinkedIn

[Brady Kelly]

Cool, thanks. I've bookmarked those.

No object is so beautiful that, under certain conditions, it will not look ugly. - Oscar Wilde

[Cloud William]

I am currently working on a system where most of the software was written in C in the early 1980s. It is formatted so badly that stuff like

 if (condition)
DoThis();

else DoThat();
DoAnotherThing();

is not uncommon at all. Add to that, there is no consistent use of tabs vs. spaces, no consistent tab stops, no naming conventions. Honestly, use the braces or don't, just be consistent, dammit. Proper indentation is far more valuable than brace usage; don't use TAB for indentation, and do stuff the same way, every damn time.

"The only thing a free man can be forced to do is die." "The right to defend oneself and ones neighbors is the beginning of freedom." "Freedom? That is a worship word. . ." -- Cloud William "It is our worship word, too." -- James T. Kirk

[Vark111]

I only remove braces on single-line method preconditions at the beginning of a method:

if (arg==null) throw new ArgumentNullException("arg", arg);

Everywhere else I put braces.

[Jim from Indy]

You guys need to investigate APL, a language described by one of my fellow students as "the ultimate in elegance"

Jim