Do you prefix everything with "this"? Did you ever..

TheGreatAndPowerfulOz

I've used "that" for a parameter name, especially in comparison methods. I NEVER, EVER USE "this.". I absolutely HATE code that is littered with "this.someMember" type syntax. I absolutely HATE code that is littered with "pszHungarianAsswipeTypeFuckedupShit" prefix naming crap. I absolutely HATE code that is littered with "m_" name prefix crap. I absolutely HATE classes that start with C for "class". I absolutely HATE K&R formatting of code. I absolutely HATE when C# property get/set code takes up SEVEN FUCKING LINES when all it's doing is returning/setting a member variable! ONE FUCKING LINE WILL DO ASSWIPES!

#SupportHeForShe

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun Only 2 things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

MarkTJohnson

Decaf for you from now on

TheGreatAndPowerfulOz

:^) :~:java::rose:

#SupportHeForShe

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun Only 2 things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

den2k88

Mu code falls in 4 of your 6 categories. :~

Geek code v 3.12 GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- r++>+++ y+++* Weapons extension: ma- k++ F+2 X // No comment

TheGreatAndPowerfulOz

den2k88 wrote:

Mu code

Well, there's your problem. You're using some sort of degenerate mutated cow to do your coding. Repent! I say! Repent! Fix your ways!

#SupportHeForShe

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun Only 2 things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

den2k88

:baaaa!: :baaaa!: :baaaa!: You're right, now I sheep better software! Getting my coat and running

Geek code v 3.12 GCS d--- s-/++ a- C++++ U+++ P- L- E-- W++ N++ o+ K- w+++ O? M-- V? PS+ PE- Y+ PGP t++ 5? X R++ tv-- b+ DI+++ D++ G e++>+++ h--- r++>+++ y+++* Weapons extension: ma- k++ F+2 X // No comment

TheGreatAndPowerfulOz

You better run... I've set the wolves on ya!

#SupportHeForShe

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun Only 2 things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

Lost User

I absolutely LOVE it when I find myself agreeing wholeheartedly with someone about coding style :) Don't read on without your medication :)

private bool m_boolIsInAgreement = true;
public bool IsInAgreement {
get {
return this.m_boolIsInAgreement;
}
set {
if (this.m_boolIsInAgreement != value){
this.m_boolIsInAgreement = value;
}
}
}

PooperPig - Coming Soon

Agent__007

:laugh: And may I add:

internal class CCleanCode{
// ...
}

:-D

Your time will come, if you let it be right.

TheGreatAndPowerfulOz

_Maxxx_ wrote:

coding style

Proper coding style improves comprehension and reduces bugs. Plus it's just damn fun!

_Maxxx_ wrote:

if (this.m_boolIsInAgreement != value){ this.m_boolIsInAgreement = value; }

What the FUCK is that shiite! Whoever wrote this should be raked over hot coals, be tossed into a pool of salt water and be forced to take a rubbing alchohol bath.

#SupportHeForShe

If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams You must accept 1 of 2 basic premises: Either we are alone in the universe or we are not alone. Either way, the implications are staggering!-Wernher von Braun Only 2 things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein

Lost User

_Maxxx_ wrote:

set { if (this.m_boolIsInAgreement != value){ this.m_boolIsInAgreement = value; } }

I would like to improve on that, it doesn't quite meet the required standards. Better:

set {
if (value == true) {
this.m_boolIsInAgreement = true;
} else if (value == false) {
this.m_boolIsInAgreement = false;
}
}

Recursion: see Recursion.

Richard Deeming

No, no, no. You're assigning to the field unnecessarily, which wastes CPU cycles. You also need spaces within the parentheses, and Yoda conditionals. The proper way to do it would be:

if ( true == value && value != this.m_boolIsInAgreement ) {
this.m_boolIsInAgreement = value;
} else if ( false == value && value != this.m_boolIsInAgreement ) {
this.m_boolIsInAgreement = value;
}

There, that's much better! :-\

"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer

Lost User

"Yoda conditionals" made my evening! :laugh: :thumbsup: From now on there'll be at least one funny thought when spotting Yoda code :)

Recursion: see Recursion.

Lost User

Not thread-safe, no error-handling code, no comments.. I assume you left that out so the example is more clear?

Bastard Programmer from Hell :suss: If you can't read my code, try converting it here[^][](X-Clacks-Overhead: GNU Terry Pratchett)

Richard Deeming

Of course - that's left as an exercise for the reader. :laugh:

"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer