Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Code Project
  1. Home
  2. The Lounge
  3. Now, granted, I don't always write "up to snuff" code...

Now, granted, I don't always write "up to snuff" code...

Scheduled Pinned Locked Moved The Lounge
xmloopcsharppythoncom
50 Posts 23 Posters 0 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • M Offline
    M Offline
    Marc Clifton
    wrote on last edited by
    #1

    ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

    V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

    Z R M B M 13 Replies Last reply
    0
    • M Marc Clifton

      ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

      V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

      Z Offline
      Z Offline
      ZurdoDev
      wrote on last edited by
      #2

      I agree. I hate that not all programmers are as smart as me. It's the worst. :mad: Why can't they all know exactly what I know? ;)

      There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

      J R Sander RosselS N M 5 Replies Last reply
      0
      • Z ZurdoDev

        I agree. I hate that not all programmers are as smart as me. It's the worst. :mad: Why can't they all know exactly what I know? ;)

        There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

        J Offline
        J Offline
        Jorgen Andersson
        wrote on last edited by
        #3

        I don't want to know what you know. I want to know what Marc knows.

        Wrong is evil and must be defeated. - Jeff Ello

        Z P M M 4 Replies Last reply
        0
        • M Marc Clifton

          ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

          V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

          R Offline
          R Offline
          Ron Nicholson
          wrote on last edited by
          #4

          Marc Clifton wrote:

          garbage scows.

          Reminds me of the time the Klingons called the Enterprise a 'garbage scow'. Wasn't pretty. :doh:

          Jack of all trades, master of none, though often times better than master of one.

          Richard Andrew x64R M 2 Replies Last reply
          0
          • J Jorgen Andersson

            I don't want to know what you know. I want to know what Marc knows.

            Wrong is evil and must be defeated. - Jeff Ello

            Z Offline
            Z Offline
            ZurdoDev
            wrote on last edited by
            #5

            Jörgen Andersson wrote:

            I don't want to know what you know.

            Too late. ;P

            Jörgen Andersson wrote:

            I want to know what Marc knows.

            Not enough time. :-D

            There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

            J 1 Reply Last reply
            0
            • J Jorgen Andersson

              I don't want to know what you know. I want to know what Marc knows.

              Wrong is evil and must be defeated. - Jeff Ello

              P Offline
              P Offline
              Pualee
              wrote on last edited by
              #6

              :laugh:

              1 Reply Last reply
              0
              • M Marc Clifton

                ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                M Offline
                M Offline
                Mark_Wallace
                wrote on last edited by
                #7

                I have faith. All it needs is a couple of years, and you'll have fixed most of it. i.e. All it needs is someone who actually gives a damn.

                I wanna be a eunuchs developer! Pass me a bread knife!

                1 Reply Last reply
                0
                • J Jorgen Andersson

                  I don't want to know what you know. I want to know what Marc knows.

                  Wrong is evil and must be defeated. - Jeff Ello

                  M Offline
                  M Offline
                  Mark_Wallace
                  wrote on last edited by
                  #8

                  Oh, how I wish I could upvote that twice!

                  I wanna be a eunuchs developer! Pass me a bread knife!

                  1 Reply Last reply
                  0
                  • M Marc Clifton

                    ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                    V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                    B Offline
                    B Offline
                    BillW33
                    wrote on last edited by
                    #9

                    Sounds a lot like the poor code at a place that I used to work. And one of the reasons that I don't work there anymore. ;) Also the reason for my tag line :)

                    Just because the code works, it doesn't mean that it is good code.

                    1 Reply Last reply
                    0
                    • Z ZurdoDev

                      I agree. I hate that not all programmers are as smart as me. It's the worst. :mad: Why can't they all know exactly what I know? ;)

                      There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

                      R Offline
                      R Offline
                      raddevus
                      wrote on last edited by
                      #10

                      I think Marc is just looking for "Best Practices" or some method to the madness. But since I called it Best Practices, which really just means "hey, dev, use a consistent way of doing things that isn't just typing code but actual contains thought", people will freak out. :laugh:

                      1 Reply Last reply
                      0
                      • R Ron Nicholson

                        Marc Clifton wrote:

                        garbage scows.

                        Reminds me of the time the Klingons called the Enterprise a 'garbage scow'. Wasn't pretty. :doh:

                        Jack of all trades, master of none, though often times better than master of one.

                        Richard Andrew x64R Offline
                        Richard Andrew x64R Offline
                        Richard Andrew x64
                        wrote on last edited by
                        #11

                        The Trouble with Tribbles! Laddie, don't you think you better rephrase that? Oh, sure. I didn't mean to say that the Enterprise should be hauling garbage. I meant to say that it should be hauled away AS GARBAGE! <Fists start to fly> :laugh:

                        The difficult we do right away... ...the impossible takes slightly longer.

                        1 Reply Last reply
                        0
                        • M Marc Clifton

                          ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                          V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                          M Offline
                          M Offline
                          Marco Bertschi
                          wrote on last edited by
                          #12

                          Marc Clifton wrote:

                          Let's use bool? as a 3 state variable instead of a readable enum.

                          That is exactly what Microsoft Developers said when they implemented the Window.DialogResult Property (System.Windows)[^]

                          M 1 Reply Last reply
                          0
                          • M Marc Clifton

                            ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                            V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                            J Offline
                            J Offline
                            Jeremy Falcon
                            wrote on last edited by
                            #13

                            Marc Clifton wrote:

                            Let's use bool? as a 3 state variable instead of a readable enum.

                            You have to admit, that's almost ingenious before it was mixed in with round of WTF by not making it readable. I've actually used a triple state boolean before... with yes, no, and maybe for the valid values.

                            Jeremy Falcon

                            D 1 Reply Last reply
                            0
                            • M Marc Clifton

                              ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                              V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                              F Offline
                              F Offline
                              Foothill
                              wrote on last edited by
                              #14

                              I often wonder what the Gurus that haunt this website would feel about my code.

                              if (Object.DividedByZero == true) { Universe.Implode(); } Meus ratio ex fortis machina. Simplicitatis de formae ac munus. -Foothill, 2016

                              1 Reply Last reply
                              0
                              • M Marc Clifton

                                ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                                V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                                L Offline
                                L Offline
                                Lost User
                                wrote on last edited by
                                #15

                                On my personal scale of unmaintainable code that's about 15 of 100. The real grandmasters use such things as mere decoration. Their centerpiece is absolutely uncorrectable. make one little change and everything falls apart like a row of dominos. What they did? Nothing special. They put a part of the application's logic into the data layer as stored procedures. SQL is great to see what's being done, but you get absolutely no clue to what this is supposed to accomplish. Dozens of SPs with no less than 500 lines already make the whole thing unreadable, but that still does not make it uncorrectable. The final blow comes from a first unexpected direction. On every table are at list 5 - 10 triggers which do really obscure things under even more obscure circumstances and modify things in other tables, which fires even more triggers. To keep the whole trigger avalanche under control, there are columns in the tables to hold status codes instead of data. Let's forget database design for a second and just try to figure out what status 1, 2, 3, -1 and -112 could mean. It would have been to easy if any documentation had existed at all and to add insult to injury, the mastermind behind that thing would deny any knowledge, but take any 'unjustified' criticism against his life's work personally. Obviously we were all too dumb to see the true ingenuity behind it all. And now stop complaining. :-)

                                The language is JavaScript. that of Mordor, which I will not utter here
                                This is Javascript. If you put big wheels and a racing stripe on a golf cart, it's still a fucking golf cart.
                                "I don't know, extraterrestrial?" "You mean like from space?" "No, from Canada." If software development were a circus, we would all be the clowns.

                                N M 2 Replies Last reply
                                0
                                • Z ZurdoDev

                                  I agree. I hate that not all programmers are as smart as me. It's the worst. :mad: Why can't they all know exactly what I know? ;)

                                  There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

                                  Sander RosselS Offline
                                  Sander RosselS Offline
                                  Sander Rossel
                                  wrote on last edited by
                                  #16

                                  There is a whole lot between knowing what Marc knows and not knowing a damn thing about programming. Unfortunately, it seems people who know nothing about programming still end up programming somehow :~ How would you react if someone built your house, you pay good money, and your front door could always be opened from the outside (even though it seems to have a lock)? You'd be furious, sue your contractor and find a new door. You'd probably not trust the rest of the house anymore either (check your walls, foundation, windows, etc.). I think that's roughly the equivalent of SQL injection. Yet only one is common practice :)

                                  Best, Sander arrgh.js - Bringing LINQ to JavaScript SQL Server for C# Developers Succinctly Object-Oriented Programming in C# Succinctly

                                  N 1 Reply Last reply
                                  0
                                  • Z ZurdoDev

                                    I agree. I hate that not all programmers are as smart as me. It's the worst. :mad: Why can't they all know exactly what I know? ;)

                                    There are two kinds of people in the world: those who can extrapolate from incomplete data. There are only 10 types of people in the world, those who understand binary and those who don't.

                                    N Offline
                                    N Offline
                                    Nish Nishant
                                    wrote on last edited by
                                    #17

                                    RyanDev wrote:

                                    I hate that not all programmers are as smart as me.

                                    Should be : > I hate that not all programmers are as smart as I think I am. :-D

                                    Nish Nishant Consultant Software Architect Ganymede Software Solutions LLC www.ganymedesoftwaresolutions.com

                                    1 Reply Last reply
                                    0
                                    • M Marc Clifton

                                      ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                                      V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                                      R Offline
                                      R Offline
                                      Ravi Bhavnani
                                      wrote on last edited by
                                      #18

                                      Marc Clifton wrote:

                                      10.  Let's use bool? as a 3 state variable instead of a readable enum.

                                      I think that's called "job security". /ravi

                                      My new year resolution: 2048 x 1536 Home | Articles | My .NET bits | Freeware ravib(at)ravib(dot)com

                                      J 1 Reply Last reply
                                      0
                                      • J Jeremy Falcon

                                        Marc Clifton wrote:

                                        Let's use bool? as a 3 state variable instead of a readable enum.

                                        You have to admit, that's almost ingenious before it was mixed in with round of WTF by not making it readable. I've actually used a triple state boolean before... with yes, no, and maybe for the valid values.

                                        Jeremy Falcon

                                        D Offline
                                        D Offline
                                        David ONeil
                                        wrote on last edited by
                                        #19

                                        Code it as a single bit for extra points!

                                        Sudden Sun Death Syndrome (SSDS) is a very real concern which we should be raising awareness of. 156 billion suns die every year before they're just 1 billion years old. While the military are doing their part, it simply isn't enough to make the amount of nukes needed to save those poor stars. - TWI2T3D (Reddit)

                                        J 1 Reply Last reply
                                        0
                                        • M Marc Clifton

                                          ...but the garbage I've had to look into and fix, well, it's just amazing. 1. Lack of abstraction (makes testing a total PITA) 2. Lack of encapsulation (would be nice to be able to load up the configuration values without hitting a serer that I don't connect to in testing) 3. Absolutely convoluted code for getting something to run on a separate thread (even before Task.Run this was basically a 5 liner, not the 100+ lines of drivel I'm wading through.) 4. How many times do I need to xpath the config file to get the same value in the same loop??? 5. Let's instantiate variables and never use them! 6. Let's add debugging that inspects the .NET stack. And not disable it in a release build. 7. Let's load an XSLT transform from a file every time we need to transform something. 8. And maybe XSLT isn't the most efficient? 9. And let's put in comments about "not too pricey performance-wise" for stupid-arsed things and totally ignore the glaring inefficiencies elsewhere. 10. Let's use bool? as a 3 state variable instead of a readable enum. 11. And the list goes on. I am getting sorely disappointed in the code I've had to work with. I have yet to see something decently implemented in this job. It's pretty clear to me that if I were the Trump of the software engineering world, I would cull 90% of them and relegate them to captaining garbage scows. Marc

                                          V.A.P.O.R.ware - Visual Assisted Programming / Organizational Representation Learning to code with python is like learning to swim with those little arm floaties. It gives you undeserved confidence and will eventually drown you. - DangerBunny Artificial intelligence is the only remedy for natural stupidity. - CDP1802

                                          C Offline
                                          C Offline
                                          ClockMeister
                                          wrote on last edited by
                                          #20

                                          Haven't met a developer yet that doesn't bitch about how lousy the code is that he has to maintain that was written by someone else!

                                          D M 2 Replies Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          • Login

                                          • Don't have an account? Register

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • World
                                          • Users
                                          • Groups