Long Lines

PIEBALDconsult

Splitting _before_ operators tends to help them stand out.

Forogar

Actually I split before dots and most operators, but after equals, etc.

- I would love to change the world, but they won’t give me the source code.

CodeWraith

Just setting the X register to a new value. This means that the value in register 6 is now the new stack pointer.

I have lived with several Zen masters - all of them were cats. His last invention was an evil Lasagna. It didn't kill anyone, and it actually tasted pretty good.

Marc Clifton

PeejayAdams wrote:

Two short-lived variables

Lifetime should not influence readability. I almost always put things into variables not just for readability but that it makes it easier to debug. Given:

OutputImage(file, allFaces.Where(f => f.Proportion > double.Parse(ConfigurationManager.AppSettings["LowerBound"].ToString()) && f.Proportion < double.Parse(ConfigurationManager.AppSettings["UpperBound"].ToString())).ToList().OrderBy(f => f.Proportion).ThenByDescending(f => f.Rectangle.Height).FirstOrDefault());

I do have a penchant for extension methods. As in:

var face = allFaces
.AnyBetween(f => f.Proportion, "LowerBound".AppSetting().to_f(), "UpperBound".AppSetting().to_f())
.OrderBy(f => f.Proportion)
.ThenByDescending(f => f.Rectangle.Height)
.FirstOrDefault();
OutputImage(file, face);

As bizarre as it is to extend string, I find it a lot more readable. The ToList() seems superfluous. Not sure you want to output an image if no images meet the selection criteria. I might move FirstOrDefault into OutputImage(file, face.FirstOrDefault()); as well, who knows, the way you get the faces might be re-usable. I leave it to the reader to figure out to_f, AnyBetween, and AppSettings Should be obvious.

Latest Articles:
Client-Side TypeScript without ASP.NET, Angular, etc.

dandy72

That's my preference as well, unless I'm still debugging the code, and I want to verify the output of one of the chained calls. Otherwise setting a breakpoint, say, on line 6 sets a breakpoint on the entire thing. But once I'm confident I won't have to revisit it, it all goes back to a single statement split among multiple lines.

pkfox

Hear hear Dave - I hate chained statements / method calls - set class properties and call the method - no need for parameters

"We can't stop here - this is bat country" - Hunter S Thompson - RIP

Brisingr Aerowing

I think Richard was making a joke.

What do you get when you cross a joke with a rhetorical question? The metaphorical solid rear-end expulsions have impacted the metaphorical motorized bladed rotating air movement mechanism. Do questions with multiple question marks annoy you???

Roger Wright

Now that makes me miss programming! :)

Will Rogers never met me.

Member 9167057

You're my hero. I also find myself writing lines like this. I kinda consider them a guilty pleasure, they may not look nice, but I like them. Started all the way back at the end of my school time, I was in the Maple math class and my teacher always told me to use variables, they're aplenty and free. He kept telling me every single time.

Sander Rossel

In theory, you can write your entire application on a single line. You're writing for people though, not for machines. So yeah, make two separate lines that make it more readable and the compiler will inline them giving you no added memory or performance impacts. I'd probably also do this:

OutputImage(file, allFaces.Where(f => f.Proportion > lowerBound && f.Proportion < upperBound)
.ToList()
.OrderBy(f => f.Proportion)
.ThenByDescending(f => f.Rectangle.Height)
.FirstOrDefault());

Best, Sander sanderrossel.com Continuous Integration, Delivery, and Deployment arrgh.js - Bringing LINQ to JavaScript Object-Oriented Programming in C# Succinctly

bjongejan

When lines become long, I split before a binary operator, and make sure that binary operators always are in the same line, or, if the line is split, in the same column as the parentheses, if there are any. In addition, I usually put like binary operators in the same column. If a line is split at a binary operator, I indent both operands by the same amount, e.g. two characters to the right. Like so:

OutputImage
( file
, allFaces
. Where
( f
=> f.Proportion
> double.Parse(ConfigurationManager.AppSettings["LowerBound"].ToString())
&& f.Proportion
< double.Parse(ConfigurationManager.AppSettings["UpperBound"].ToString())
)
. ToList()
. OrderBy(f => f.Proportion)
. ThenByDescending(f => f.Rectangle.Height)
. FirstOrDefault()
);

PeejayAdams

Yes, I'd agree with that.