Some C# code that makes me sick...
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
Ugh, I've seen code like that many times!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X.", ex);
}Fixed it. That exclamation mark is just screamy and unprofessional :rolleyes:
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
ditching original exception seems like a good idea (no)
-
I agree that it should probably be something more like:
// TODO: Log an error
try {
DoX();
}
catch {
throw;
}because that will preserve the error, while still putting in an opportunity to add logging, and kind of a placeholder in the code. Avoiding catching the exception type not only makes explicit that you don't care what kind of exception it is, it also forces you to define your exceptions once you add logging. After all you can't log an exception if you don't capture it in a type, so when you do get around to logging it forces you to consider your exception types at that point, leading to at least a half step toward solving your second complaint about throwing a zillion errors, because you're more selective about what you throw. However, I'd argue the above is probably not worth it, but I think that comes down to a matter of style. I certainly wouldn't balk at the above code, but I probably wouldn't write it myself.
Real programmers use butterflies
Because you haven't imagined the horror to its full extent yet!!!
void Method_1()
{
try {
Method_2();
} catch (Exception ex) {
// logging maybe?
throw new Exception("Method_2", ex);
}
}
void Method_2()
{
try {
Method_3();
} catch (Exception ex) {
// logging?
throw new Exception("Method_3", ex);
}
}
void Method_3()
{
try {
Something();
} catch (Exception ex) {
// logging again?
throw new Exception("Something", ex);
}
}I'd say how about that?
void Method_1()
{
Method_2();
}
void Method_2()
{
Method_3();
}
void Method_3()
{
Something();
}or that
void Method_1()
{
try {
Method_2();
} catch (Exception ex) {
// logging perhaps?
throw new Exception("Method_2", ex);
}
}
void Method_2()
{
Method_3();
}
void Method_3()
{
Something();
}instead!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
Ugh, I've seen code like that many times!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X.", ex);
}Fixed it. That exclamation mark is just screamy and unprofessional :rolleyes:
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
Glad you understand! :laugh:
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
<JOKE> Well, obviously it should be more like:
try
{
DoX();
}
catch (Exception ex)
{
throw ex;
};P </JOKE> Personally, I wish the Exception class had been declared abstract. If you need to throw a new exception, it should always be something more specific than the base Exception class. Especially prior to .NET 4 and the HandleProcessCorruptedStateExceptions attribute[^] , when a catch block for the base Exception class would also catch "corrupted process state" exceptions, which should pretty much never be caught.
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
Ugh, I've seen code like that many times!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X.", ex);
}Fixed it. That exclamation mark is just screamy and unprofessional :rolleyes:
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
I always think that putting an exclamation mark at the end of an error message is the equivalent of adding "you idiot!". "Value must be numeric, you idiot!" "Date must be in d-ddd:mmm/yyyyy format, you idiot!" "Credit card number must not include spaces, you idiot!" (world's most annoying message: why can't you remove the spaces yourself?) Or in "success" messages: "File has been saved!" (like it's some sort of special achievement, and the computer is being extra kind to you in doing it)
-
Because you haven't imagined the horror to its full extent yet!!!
void Method_1()
{
try {
Method_2();
} catch (Exception ex) {
// logging maybe?
throw new Exception("Method_2", ex);
}
}
void Method_2()
{
try {
Method_3();
} catch (Exception ex) {
// logging?
throw new Exception("Method_3", ex);
}
}
void Method_3()
{
try {
Something();
} catch (Exception ex) {
// logging again?
throw new Exception("Something", ex);
}
}I'd say how about that?
void Method_1()
{
Method_2();
}
void Method_2()
{
Method_3();
}
void Method_3()
{
Something();
}or that
void Method_1()
{
try {
Method_2();
} catch (Exception ex) {
// logging perhaps?
throw new Exception("Method_2", ex);
}
}
void Method_2()
{
Method_3();
}
void Method_3()
{
Something();
}instead!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
I think this deserves a post in the Weird and the Wonderful forum-
-
I think this deserves a post in the Weird and the Wonderful forum-
Yea, I realized that afterwards! ^_^
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
<JOKE> Well, obviously it should be more like:
try
{
DoX();
}
catch (Exception ex)
{
throw ex;
};P </JOKE> Personally, I wish the Exception class had been declared abstract. If you need to throw a new exception, it should always be something more specific than the base Exception class. Especially prior to .NET 4 and the HandleProcessCorruptedStateExceptions attribute[^] , when a catch block for the base Exception class would also catch "corrupted process state" exceptions, which should pretty much never be caught.
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
another tragic mistake! You should have just
throw;
;P That preserve the calllstack ^_^ Hey, I didn't know this attribute! :O
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
another tragic mistake! You should have just
throw;
;P That preserve the calllstack ^_^ Hey, I didn't know this attribute! :O
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
That was my whole point - I've lost track of the number of times I've seen catch (Exception ex) { throw ex; } used in QA questions. :)
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
-
That was my whole point - I've lost track of the number of times I've seen catch (Exception ex) { throw ex; } used in QA questions. :)
"These people looked deep within my soul and assigned me a number based on the order in which I joined." - Homer
Haha, got me! :)
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
I always think that putting an exclamation mark at the end of an error message is the equivalent of adding "you idiot!". "Value must be numeric, you idiot!" "Date must be in d-ddd:mmm/yyyyy format, you idiot!" "Credit card number must not include spaces, you idiot!" (world's most annoying message: why can't you remove the spaces yourself?) Or in "success" messages: "File has been saved!" (like it's some sort of special achievement, and the computer is being extra kind to you in doing it)
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
It would be better to add info at each step up the call stack (for debugging info) into the exception's Data collection, then just a throw; statement. Once at the top of the call stack, handle the exception and log the contents of the exception and its data collection.
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
try catch statements should only be used in the UI/client layer, not in business layer or data layer - usually. you should ALWAYS log your exceptions to a database or file log without exception. you should not use try/catch/exceptions to control logic flow, whenever possible. my 2 cents. the code you referenced is crap IMHO. instead of re-throwing the exception, it should be logged, and handled gracefully and informatively for the end user.
-
I always think that putting an exclamation mark at the end of an error message is the equivalent of adding "you idiot!". "Value must be numeric, you idiot!" "Date must be in d-ddd:mmm/yyyyy format, you idiot!" "Credit card number must not include spaces, you idiot!" (world's most annoying message: why can't you remove the spaces yourself?) Or in "success" messages: "File has been saved!" (like it's some sort of special achievement, and the computer is being extra kind to you in doing it)
I actually know someone who puts an exclamation behind pretty much every message box! Or three in case of an error!!! Really childish and unprofessional and this is a smart guy with good business instincts (but no programming instincts whatsoever :laugh: ).
Best, Sander Azure DevOps Succinctly (free eBook) Azure Serverless Succinctly (free eBook) Migrating Apps to the Cloud with Azure arrgh.js - Bringing LINQ to JavaScript
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
"And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk..." That's the Java Spring way, and 128 other exceptions ...
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
The code I support came with hundreds of
try
{
... do stuff ...
}
catch (Exception ex)
{
throw ex;
}I spoke to the original developer, but they are still doing the same thing even now.
-
Thankfully I have a robust constitution and delete it viciously... But I thought I should purge here for all to see! The kind of code below makes me sick to the bone... When I see it I need to immediately incinerate this try/catch never to be caught again!
try {
DoX();
}
catch (Exception ex) {
throw new Exception("Having problem Doing X!", ex);
}And don't give me the horseradish about "but they use this opportunity to do logging and stuff". I mean this exact code above! No additional stuff! :O And speaking of logging, I have seen such try/catch/logging being nested zillion of time resulting in zillion of log entry for one single exception... yuk... :sigh: All of that can surmised with this simple hypothetical dialog Q: (Newbye Dev) How do I throw an exception in case of exception? A: (Captain Obvious) Just don't catch the goddamn exception you donkey!
A new .NET Serializer All in one Menu-Ribbon Bar Taking over the world since 1371!
Agree. I did like Sanders fix though. However the sub or function that they are calling is defined as a despicable act. Maybe you should have complained about that as well. :)
"Rock journalism is people who can't write interviewing people who can't talk for people who can't read." Frank Zappa 1980
