OpenStreetMap SlippyMap - MediaWiki extension

[Jeroen De Dauw]

View the complete horror here: http://svn.openstreetmap.org/applications/utils/wiki-extensions/SlippyMap-local/SlippyMap.class.php[^] Some snippets:

	if ( isset( $argv\['lat'\] ) ) {
		$lat = $argv\['lat'\];
	} else {
		$lat = '';
	}
	if ( isset( $argv\['lon'\] ) ) {
		$lon = $argv\['lon'\];
	} else {
		$lon = '';
	}
	if ( isset( $argv\['z'\] ) ) {
		$zoom = $argv\['z'\];
	} else {
	...

Should use array_key_exists and probably simply loop through, and do ${$varName} = $value or something similar.

			$error = wfMsg( 'slippymap\_heightbig' ) . '<br>';
		} else if ( $height < 100 ) {
			$error = wfMsg( 'slippymap\_heightsmall' ) . '<br>';
		} else if ( $lat > 90 ) {
			$error = wfMsg( 'slippymap\_latbig' ) . '<br>';
		} else if ( $lat < -90 ) {
			$error = wfMsg( 'slippymap\_latsmall' ) . '<br>';
		} else if ( $lon > 180 ) {
			$error = wfMsg( 'slippymap\_lonbig' ) . '<br>';

Extremely nice redundancy.

		$output .= '<script type="text/javascript">';

		$output .= "var lon= ${lon}; var lat= ${lat}; var zoom= ${zoom}; var lonLat;";

		$output .= 'var map; ';

		$output .= 'addOnloadHook( slippymap\_init ); ';

		$output .= 'function slippymap\_resetPosition() {';
		$output .= '	map.setCenter(lonLat, zoom);';
		$output .= '}';

You are NOT dreaming. This is JavaScript getting echo'd line by line!!

GSoC 2009 student for SMW! --- My little forums: http://code.bn2vs.com --- 70 72 6F 67 72 61 6D 6D 69 6E 67 20 34 20 6C 69 66 65!

[Corinna John]

But the code works so well! :)

This statement is false.