Refactoring...
-
This looks like a cool tool: Refactory for C#[^] But my question is, why would you do something like that? What's the purpose of refactoring. They show some examples, but it seems to me that there would be a lot of work in taking the code and moving it to a new method. Work that a plug-in couldn't do and that only a human could.
I don't know whether it's just the light but I swear the database server gives me dirty looks everytime I wander past. -Chris Maunder Microsoft has reinvented the wheel, this time they made it round. -Peterchen on VS.NET
After looking at their examples, I would say they have succeeded in extreme simplicity. Extreme simplicity = useless What garbage. Everything is done manually, and it's nothing more than glorified cut&paste and search&replace functions. The darn thing can't even automatically extract loop elements and create functions. That might be marginally useful. "Rename Local Variable". Oh, please. If these examples are the "best" of their product, well... enough said. Taka (see post above yours) has some kind words for refactoring and a fellow by the name of Martin Fowler. Ask Taka for an explanation. I can't give you an unbiased one. On a totally different topic--how's the weather in SD? We just got socked with 8 inches of snow in Rhode Island. Too bad it fell in the afternoon and evening. It would have been a great excuse to cancel school and not go in to work! Marc Help! I'm an AI running around in someone's f*cked up universe simulator.
sensitivity and ethnic diversity means celebrating difference, not hiding from it. - Christian Graus -
Tim Smith wrote: Nothing replaces being a competent programmer with a clue. Of course not. But 1) how do you become a competent programmer and 2) competent programmers will *always* have a really good toolkit. I haven't had a close look at the site but it looks like just another tool, simple as that. Whether or not it's a good tool and does its job well is another question but there's nothing wrong with it in itself. A good idea, in fact, IMO.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.competent programmers will *always* have a really good toolkit. Garbage in -> Garbage out programs aren't really good tools. The are just "refactor" the garbage into another form. Tools don't make a programmer, they enhance them. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
How does one become a competent programmer then? Cheers The universe is driven by the complex interaction between three ingredients: matter, energy, and enlightened self-interest.
By actually programming and not using 1000 mind numbed tools that try to hide the realities of programming from you because some bozo who can't program decided that it just wasn't "safe" to allow you to program properly. Nothing replaces experience. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
competent programmers will *always* have a really good toolkit. Garbage in -> Garbage out programs aren't really good tools. The are just "refactor" the garbage into another form. Tools don't make a programmer, they enhance them. Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: Tools don't make a programmer, they enhance them. Again, of course. My question is, why is this refactoring tool inherently such a bad thing? In the hands of a "competent programmer", wouldn't it actually be a very useful thing to have?
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project. -
Tim Smith wrote: Nothing replaces being a competent programmer with a clue. Of course not. But 1) how do you become a competent programmer and 2) competent programmers will *always* have a really good toolkit. I haven't had a close look at the site but it looks like just another tool, simple as that. Whether or not it's a good tool and does its job well is another question but there's nothing wrong with it in itself. A good idea, in fact, IMO.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.Hi Taka! Did you feel the tremors??? I just sent this email to their sales people (no, I don't show any mercy): To Whom It May Concern, I looked at the examples on your web site, and I would definitely say this product is garbage. In fact, I would say that it besmirches the concept of refactoring. The examples you give are pathetic. Your product I nothing more than glorified cut&paste and search&replace functions. Heavens, you don’t even automate loop function replacement. That would at least give you some justification for your “Rename Type” search and replace function. Basically, you provide keyboard shortcuts that are simply different. Please remove this product from the market. It is pathetic. Marc Clifton Consultant Knowledge Automation Help! I'm an AI running around in someone's f*cked up universe simulator.
sensitivity and ethnic diversity means celebrating difference, not hiding from it. - Christian Graus -
*sigh* More of this "we know everything already and dont need to learn anything knew" garbage. or, at thats how it appears when people bag something that they very obviously haven't spent any time checking out. Cheers The universe is driven by the complex interaction between three ingredients: matter, energy, and enlightened self-interest.
Then tell me what grand thing this tool does that actually IMPROVES the code? What does it do? Ooo it creates new routines. What about the documentation for those routines? You do actually document your code, don't you? Maybe that is why you need tools like this because you lack the self control to actually do it right to start with. You would rather waste money on salary and tools AFTER the fact. Silly if you ask me. It also renames silly variables. Why in the **** do you have silly names to begin with? Why not name them properly from the start? Everything this program tries to "correct" are all BAD PROGRAMMING practices. Chances are, if you really need to use this tool, then your software has more significant problems than just this. Like I said, garbage in, garbage out. Nothing replaces doing it right from the start. It costs more money to come in after the fact and clean up the mess. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
By actually programming and not using 1000 mind numbed tools that try to hide the realities of programming from you because some bozo who can't program decided that it just wasn't "safe" to allow you to program properly. Nothing replaces experience. Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: By actually programming and not using 1000 mind numbed tools that try to hide the realities of programming from Do you use Visual Studio? There are a lot of people who reckon that it's a "mind numbed tool" and prefer Vi or emacs. I've heard this argument x times before. If it was really taken seriously, no one would be programming high level languages, we'd all still be flipping switches, or punching cards. Tim Smith wrote: because some bozo who can't program decided that it just wasn't "safe" to allow you to program properly. Isn't that part of what a compiler does? It checks your code to make sure you are programming properly. So whats wrong with another tool that makes it easier to program? Tim Smith wrote: Nothing replaces experience. Agreed. But why shouldnt I use a tool that safely allows me to automatically rename a variable throughout a program instead of sifting through a thousand lines of code? Why shouldnt I be able to automate the repetitive tasks in programming using a tool? Cheers The universe is driven by the complex interaction between three ingredients: matter, energy, and enlightened self-interest.
-
Tim Smith wrote: Tools don't make a programmer, they enhance them. Again, of course. My question is, why is this refactoring tool inherently such a bad thing? In the hands of a "competent programmer", wouldn't it actually be a very useful thing to have?
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.The tool isn't inherently bad. It is just that it has little or no value. It helps to cover up the real problem of programmers with little or no self control or talent. Tools like this do not improve code quality (IMHO) because if you need a tool like this, the software has more significant problems. Renaming a few variables and making a few new routines will not help. These tools are just marketing hype and panaceas. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
Hi Taka! Did you feel the tremors??? I just sent this email to their sales people (no, I don't show any mercy): To Whom It May Concern, I looked at the examples on your web site, and I would definitely say this product is garbage. In fact, I would say that it besmirches the concept of refactoring. The examples you give are pathetic. Your product I nothing more than glorified cut&paste and search&replace functions. Heavens, you don’t even automate loop function replacement. That would at least give you some justification for your “Rename Type” search and replace function. Basically, you provide keyboard shortcuts that are simply different. Please remove this product from the market. It is pathetic. Marc Clifton Consultant Knowledge Automation Help! I'm an AI running around in someone's f*cked up universe simulator.
sensitivity and ethnic diversity means celebrating difference, not hiding from it. - Christian Graus -
Tim Smith wrote: By actually programming and not using 1000 mind numbed tools that try to hide the realities of programming from Do you use Visual Studio? There are a lot of people who reckon that it's a "mind numbed tool" and prefer Vi or emacs. I've heard this argument x times before. If it was really taken seriously, no one would be programming high level languages, we'd all still be flipping switches, or punching cards. Tim Smith wrote: because some bozo who can't program decided that it just wasn't "safe" to allow you to program properly. Isn't that part of what a compiler does? It checks your code to make sure you are programming properly. So whats wrong with another tool that makes it easier to program? Tim Smith wrote: Nothing replaces experience. Agreed. But why shouldnt I use a tool that safely allows me to automatically rename a variable throughout a program instead of sifting through a thousand lines of code? Why shouldnt I be able to automate the repetitive tasks in programming using a tool? Cheers The universe is driven by the complex interaction between three ingredients: matter, energy, and enlightened self-interest.
safely allows me to automatically rename a variable Does it really? Would you not still test the new changes? Wouldn't you still do a desk check to make sure it hasn't screwed up your code? So really, what has it saved you? Of course, if you aren't going to test the changes or visually verify that the tool hasn't hacked up your code, then just use a global file replace. It is just as safe. FYI: I use VC7 :P But I don't use the class factory because it made me less productive. I don't see the logic in using the new fad tools when I end up being less productive. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
Hi Taka! Did you feel the tremors??? I just sent this email to their sales people (no, I don't show any mercy): To Whom It May Concern, I looked at the examples on your web site, and I would definitely say this product is garbage. In fact, I would say that it besmirches the concept of refactoring. The examples you give are pathetic. Your product I nothing more than glorified cut&paste and search&replace functions. Heavens, you don’t even automate loop function replacement. That would at least give you some justification for your “Rename Type” search and replace function. Basically, you provide keyboard shortcuts that are simply different. Please remove this product from the market. It is pathetic. Marc Clifton Consultant Knowledge Automation Help! I'm an AI running around in someone's f*cked up universe simulator.
sensitivity and ethnic diversity means celebrating difference, not hiding from it. - Christian Graus -
The tool isn't inherently bad. It is just that it has little or no value. It helps to cover up the real problem of programmers with little or no self control or talent. Tools like this do not improve code quality (IMHO) because if you need a tool like this, the software has more significant problems. Renaming a few variables and making a few new routines will not help. These tools are just marketing hype and panaceas. Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: It helps to cover up the real problem of programmers with little or no self control or talent Well, perhaps "fix" rather than "cover up". But that's the whole intent (or a lot of it) with tools like this. Tim Smith wrote: These tools are just marketing hype and panaceas. Maybe some of them are and maybe some of them aren't. Like I said, I haven't had a close look at the site but I think Marc Clifton has already decided... :-)
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project. -
Tim Smith wrote: It helps to cover up the real problem of programmers with little or no self control or talent Well, perhaps "fix" rather than "cover up". But that's the whole intent (or a lot of it) with tools like this. Tim Smith wrote: These tools are just marketing hype and panaceas. Maybe some of them are and maybe some of them aren't. Like I said, I haven't had a close look at the site but I think Marc Clifton has already decided... :-)
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.Well, perhaps "fix" rather than "cover up". But that's the whole intent (or a lot of it) with tools like this. I think this is the crux of our difference in opinion. In my mind, if you find yourselve needing this tool, then it is like painting a cancer growth red to make it look like normal tissue. Sure it looks a little better, but how much have we really done to move forward? Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
Well, perhaps "fix" rather than "cover up". But that's the whole intent (or a lot of it) with tools like this. I think this is the crux of our difference in opinion. In my mind, if you find yourselve needing this tool, then it is like painting a cancer growth red to make it look like normal tissue. Sure it looks a little better, but how much have we really done to move forward? Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: then it is like painting a cancer growth red to make it look like normal tissue. Good analogy. So to continue it, refactoring is the process of cutting it out and (ok, you can't do this with cancer) replacing it with something better. But it seems that this particular tool doesn't do much more than cosmetic stuff so in this particular case, you're right. But I still strongly believe that refactoring is a Good Thing and therefore tools that help with that process are also Good Things.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project. -
:eek: Ok, everyone lay of me and flame this guy. :) Tim Smith I'm going to patent thought. I have yet to see any prior art.
he he he. I like it in the kitchen! Marc Help! I'm an AI running around in someone's f*cked up universe simulator.
sensitivity and ethnic diversity means celebrating difference, not hiding from it. - Christian Graus -
Tim Smith wrote: then it is like painting a cancer growth red to make it look like normal tissue. Good analogy. So to continue it, refactoring is the process of cutting it out and (ok, you can't do this with cancer) replacing it with something better. But it seems that this particular tool doesn't do much more than cosmetic stuff so in this particular case, you're right. But I still strongly believe that refactoring is a Good Thing and therefore tools that help with that process are also Good Things.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.I would nearly bet that I would support manual or semi-automated refactoring. You would learn what the code does as you make deeper cuts into unwinding that nasty cancer. But in general, I feel that refactory should only come into play when things have already gone wrong. I don't see it being a standard day-to-day process. In "theory" properly done code shouldn't need refactoring. Of course, we all know that it will happen even to the best of us. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
I would nearly bet that I would support manual or semi-automated refactoring. You would learn what the code does as you make deeper cuts into unwinding that nasty cancer. But in general, I feel that refactory should only come into play when things have already gone wrong. I don't see it being a standard day-to-day process. In "theory" properly done code shouldn't need refactoring. Of course, we all know that it will happen even to the best of us. Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: I feel that refactory should only come into play when things have already gone wrong. OK, here I totally disagree. It depends on what you mean by "gone wrong". Refactoring is not merely a process by which we try to fix crap code. Developers often (always?) don't fully understand the issues involved when writing a new piece of code, not because they haven't done enough up-front analysis or because they're dumb but because that's the nature of our work. We've all had times when we didn't realise that something in the design was wrong until we sat down and tried to implement it. This is Fred Brooks' "build one to throw away" idea. Part of refactoring is the process of going back and updating code that we have already written to be better, in light of the new knowledge we have gained of the problem. Tim Smith wrote: In "theory" properly done code shouldn't need refactoring. This assumes that we live in an un-changing world. Even if the code we write is perfect now, in a year's time, the customer may have asked for a bunch of new features, legal requirements may have changed, etc. The assumptions we were working under a year ago may not hold true today and so the solution we came up with a year ago may not be the best one today. So again, refactoring is the process of going back and updating that code to once again be perfect :-) Tim Smith wrote: I don't see it being a standard day-to-day process. Maybe not day-to-day but definitely on-going (week-to-week?). This is routine maintenance work. We all put oil in our cars and check the tyres on a regular basis, right, to keep it in good working condition (well, we're *supposed* to)? This is the same thing. Most people would define maintenance work as being fixing bugs, minor enhancements, the kind of stuff you give to the new kid just out of school :-) I would also include refactoring, the process of taking code that already works and making it work better.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project. -
Tim Smith wrote: By actually programming and not using 1000 mind numbed tools that try to hide the realities of programming from Do you use Visual Studio? There are a lot of people who reckon that it's a "mind numbed tool" and prefer Vi or emacs. I've heard this argument x times before. If it was really taken seriously, no one would be programming high level languages, we'd all still be flipping switches, or punching cards. Tim Smith wrote: because some bozo who can't program decided that it just wasn't "safe" to allow you to program properly. Isn't that part of what a compiler does? It checks your code to make sure you are programming properly. So whats wrong with another tool that makes it easier to program? Tim Smith wrote: Nothing replaces experience. Agreed. But why shouldnt I use a tool that safely allows me to automatically rename a variable throughout a program instead of sifting through a thousand lines of code? Why shouldnt I be able to automate the repetitive tasks in programming using a tool? Cheers The universe is driven by the complex interaction between three ingredients: matter, energy, and enlightened self-interest.
Mr Morden wrote: Do you use Visual Studio? There are a lot of people who reckon that it's a "mind numbed tool" and prefer Vi or emacs. Visual Studio is an IDE that doesnt hide anything from you, it simply makes the code more visible and adds a few editing features. Except for the initial app wizards and the class wizards it will not write the code for you, and even then those tools are not all that great. Mr Morden wrote: Isn't that part of what a compiler does? It checks your code to make sure you are programming properly The compiler only checks semantics, it does not verify your logic. That is where the competent programmer is required. Mr Morden wrote: Why shouldnt I be able to automate the repetitive tasks in programming using a tool? You should be able to as long as it does not change the logic. A program that rearranges your logic is dangerous.
Build a man a fire, and he will be warm for a day
Light a man on fire, and he will be warm for the rest of his life! -
Tim Smith wrote: I feel that refactory should only come into play when things have already gone wrong. OK, here I totally disagree. It depends on what you mean by "gone wrong". Refactoring is not merely a process by which we try to fix crap code. Developers often (always?) don't fully understand the issues involved when writing a new piece of code, not because they haven't done enough up-front analysis or because they're dumb but because that's the nature of our work. We've all had times when we didn't realise that something in the design was wrong until we sat down and tried to implement it. This is Fred Brooks' "build one to throw away" idea. Part of refactoring is the process of going back and updating code that we have already written to be better, in light of the new knowledge we have gained of the problem. Tim Smith wrote: In "theory" properly done code shouldn't need refactoring. This assumes that we live in an un-changing world. Even if the code we write is perfect now, in a year's time, the customer may have asked for a bunch of new features, legal requirements may have changed, etc. The assumptions we were working under a year ago may not hold true today and so the solution we came up with a year ago may not be the best one today. So again, refactoring is the process of going back and updating that code to once again be perfect :-) Tim Smith wrote: I don't see it being a standard day-to-day process. Maybe not day-to-day but definitely on-going (week-to-week?). This is routine maintenance work. We all put oil in our cars and check the tyres on a regular basis, right, to keep it in good working condition (well, we're *supposed* to)? This is the same thing. Most people would define maintenance work as being fixing bugs, minor enhancements, the kind of stuff you give to the new kid just out of school :-) I would also include refactoring, the process of taking code that already works and making it work better.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.At this point, refactoring becomes a very ambiguous term that encompasses all forms of code modification. The meaning is so watered down that it can be said that I have been doing refactoring for 20+ years. This just reinforces my opinion that refactoring is just another buzzword for processes people have been doing for years. The write once, burn the code and then do it again is a process I have been preaching for years. Flexible code design that can morph to meet new needs is also a process I have used since I got out of school. These are all processes good shops have been doing for years. Maybe I lead a sheltered life and have been hugely lucky and have only been in top quality shops. Lets just say I hope that isn't true. Tim Smith I'm going to patent thought. I have yet to see any prior art.
-
At this point, refactoring becomes a very ambiguous term that encompasses all forms of code modification. The meaning is so watered down that it can be said that I have been doing refactoring for 20+ years. This just reinforces my opinion that refactoring is just another buzzword for processes people have been doing for years. The write once, burn the code and then do it again is a process I have been preaching for years. Flexible code design that can morph to meet new needs is also a process I have used since I got out of school. These are all processes good shops have been doing for years. Maybe I lead a sheltered life and have been hugely lucky and have only been in top quality shops. Lets just say I hope that isn't true. Tim Smith I'm going to patent thought. I have yet to see any prior art.
Tim Smith wrote: refactoring is just another buzzword for processes people have been doing for years. If you have been making changes to your code with automated regression testing to ensure that you haven't broken anything in the process, then yes, you have. But I have yet to work at a place, or even know anyone who has worked at a place, that does such a thing (except my last job where I put it in place :-)) This is the key to refactoring. "Write once, burn the code, do it again" can be done in any number of ways from "proper", incremental refactoring to literally throwing it out and starting over. Which, btw, is also refactoring as long as you have the automated testing in place. Tim Smith wrote: Flexible code design that can morph to meet new needs is also a process Ah, but how do you achieve this? This is what a lot of this discussion is about - how to perform the process of developing applications better. OK, some of it (a lot of it?) is total crap and marketing hype but some of it is good as well. And the ideas behind refactoring are good ones, IMO. Tim Smith wrote: Lets just say I hope that isn't true. Have to disagree with you again. I think you've been very lucky.
I'd wear a miniskirt and pimp myself for an extra ten grand a year. - David Wulff
Awasu[^]: A free RSS reader with support for Code Project.