As Colin says - easy mistake to make. "On one of my cards it said I had to find temperatures lower than -8. The numbers I uncovered were -6 and -7 so I thought I had won, and so did the woman in the shop. But when she scanned the card the machine said I hadn't. "I phoned Camelot and they fobbed me off with some story that -6 is higher - not lower - than -8 but I'm not having it." -Tina Farrell, a 23 year old thicky from Levenshulme, Manchester.

Thats retarded that they told you to ask here... Try this and forgive VB, I have been stuck in VB land for too long and can no longer do c# from memory. Dim ds as New DataSet() 'substitute your data set Dim dt as DataTable = ds.Tables(0) 'substitute your data table Dim dr as DataRow Dim strColumnAValue as String = String.Empty Dim strColumnBValues as New StringBuilder() For Each dr in dt.Rows  If (Convert.ToString(dr(0)) = strColumnAValue) Then 'we are working on the same user "Siann" in this case and will append values   strColumnBValues.Append(Convert.ToString(dr(1)).Trim() & ",")  Else 'You are working on a new person and not "Siann"   If strColumnBValues.Length <> 0 Then 'there is a user/ skillset to write out    strColumnBValue = strColumnBValue.Remove(strColumnBValue.ToString().LastIndexOf(","), 1) 'remove the last comma    Console.Writeline("User: " & strColumnAValue & " - Skills: " & strColumnBValues.ToString()) 'write out the value    strColumnBValues.Length = 0 'clear the string builder    strColumnAValue = Convert.ToString(dr(0)) 'set the new column A Value    strColumnBValues.Append(Convert.ToString(dr(1)).Trim() & ",") 'add the first value   End If  End If Next 'dr

I got a response from the sql forum but I worked it out myself. Let me know if you want my answer. I have another simple question but I will post a new message. :)

Sorry but I'll give you my code so oyu can see what I currently do. string sql = "bla bla "; SqlDataAdapter myCommand = new SqlDataAdapter(sql, myConnection); //Create dataset and fill it with employee data DataSet ds = new DataSet(); myCommand.Fill(ds); //bind employee data to datagrid DataView Source = ds.Tables[0].DefaultView; Source.Sort = sortField; dgSearchResults.DataSource = ds.Tables[0]; After this would I then create a new datacolumn? I found this link. Is it something like that? and then I have to concatenate string somehow? :) http://msdn2.microsoft.com/en-US/library/system.data.datacolumn.aspx">http://msdn2.microsoft.com/en-US/library/system.data.datacolumn.aspx

Thankyou. I need to have nested loops because I've got multiple user search options on a windows form. I have it working baced on what I said. I just had to do a bit more trial and error and I would've worked it out without asking. Thank you :)

falles01 wrote: I know you usually have get and set methods Really? I do? I don't think so.[^]

What I meant by my post was that the way you are concatenating strings together into a sql statement is very bad practice. Read this very useful article http://www.codeproject.com/cs/database/SqlInjectionAttacks.asp[^] by Colin Mackay. As far as inserting multiple values from a checklistbox selection, techSkillsCheckListBox2.CheckedItems.ToString() is suspect. Isn't there supposed to be an Items collection that you can pull the actual data value from? I am not a 100% but look for something like that. "Try asking what you want to know, rather than asking a question whose answer you know." - Christian Graus

No. A non abstract class is just a class that can be instantiated. The answer to this is to make the class sealed so that it cannot be inherited from. public sealed class CannotBeInherited { } Deja View - the feeling that you've seen this post before.

and what sort of list? I have a checkedlist box which is filled with data from the dataset.

Okay I was wrong. I didn't work it out. I'm still trying to save multiple skills and I thought it was saving them but it was actually saving the number of the index instead of the ID. Here is what I'm using. I still need the answer of how to get the id of the ticked items and then store it. string sql = "SELECT t.TechnicalSkillsID from TechnicalSkills where TechnicalSkillsID = '" + techSkillsCheckListBox2.CheckedItems.ToString() + "'"; if (techSkillsCheckListBox2.CheckedItems.Count != 0) { for (int x = 0; x <= techSkillsCheckListBox2.CheckedItems.Count -1; x++) foreach (int i in techSkillsCheckListBox2.CheckedIndices) { sql = "Insert into EmpSkills(EmployeeID,TechnicalSkillsID) values ('" + this.EmployeeID + "','" + techSkillsCheckListBox2.CheckedIndices[x].ToString() + "')"; SqlCommand adoCmd = new SqlCommand(sql, adoConn); adoCmd.ExecuteNonQuery(); Thank you so much ...this is killing me! I thought I had it. Sianny aka Sharny

First of all you should decide whether you want the TechnicalSkillsID as a column in the employees table - as you have now. If you keep it that way, and you want one empolyee to be able to own several TechnicalSkills, you'll have to store several ID's with a separating value. A better approach, if you ask me, would be to remove the TechnicalSkillsID column from the employee table entirely, and rather create a TechnicalSkills table which uses the employeeID as a keyvalue. Then add one boolean column per technical skill that you want available. You could then use the column name as a the name of the CheckedListBoxItem and set the Checked property according to the value from the database. I'll write an example of the latter one: Create a query for retrieving the row from the TechnicalSkill table with a employeeID equal to the employee you want to configure skills for. Code for propagating and setting the value for CheckedListBoxItems: ... generate and execute the query for returning the techskills for the given employee DataTable techSkillsTable = myDataSet.Tables\[0\]; //Query should return only one row, but we'll go with a foreach foreach(DataRow row in techSkillsTable.Rows) { foreach (DataColumn column in techSkillsTable.Columns) { string techSkillName = column.ColumnName; bool userHasSkill = false; try { userHasSkill = Convert.ToBoolean(row\[column\]); } catch { //Do nothing here as userHasSkill is initialized to false. } techSkillsListBox.Items.Add(techSkillName, userHasSkill); } } Hope it can be of some help. Best regards! -Larantz- for those about to code, we salute you http://www.itverket.no Please refer to the Forum Guidelines for appropriate posting.

It doesn't allow multiple selections though. Okay well apart from the database side of things I believe I have to use a 'for' loop. why does the following return an error?: The name 'Checked' is not permitted in this context. Only constants, expressions, or variables allowed here. Column names are not permitted. foreach (int indexChecked in techSkillsCheckListBox2.CheckedIndices) { string sql = "INSERT INTO employees(Firstname,Lastname,RoleID,DivisionID,ManagerID,TechnicalSkillsID) Values ('" + FirstnameText.Text.ToString() + "' , '" + Lastnametext.Text.ToString() + "' , " + RolecomboBoxTest.SelectedValue.ToString() + "," + DivisioncomboBox2.SelectedValue.ToString() + " , " + ManagercomboBox1.SelectedValue.ToString() + " , " + techSkillsCheckListBox2.GetItemCheckState(indexChecked).ToString() + ")"; SqlCommand sqlC = new SqlCommand(sql, myConnection); } } Anyone. I have been baffled by this for 8 hours. Its especially annoying when it was so easy to work out the combobox selections. Thanks again.

Okay but what about my last question. how do I update the employee table wiht the ID corresponding the combobox selection. EG. Employee table has empID, RoleID, DivisioID etc. But then I have a Role table with roleid description and role, and division table with divisionid, division etc. When a user enters a new employee name, and selects role for example, the employee table should update with a new name and put the correct roleID against the role. Obviously I'm not good with sql at all. :~

The OP said it wasn't important because it was a test. I was referring in the context of the interview tests my company uses. I would be concerned that a person did not account for SQL Injection attacks when they go through that test. Upcoming FREE developer events: * Glasgow: db4o: An Embeddable Database Engine for Object-Oriented Environments, Mock Objects, SQL Server CLR Integration, Reporting Services ... My website

I worked it out thanks. :)

You were right these people are not good to work for. I am going to leave and go back to my old job. I don't need to be this stressed.

Thanks for adding that, there was a danger that she missed the three people who told her already... Christian Graus - Microsoft MVP - C++ "I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )