Hi JB, thanks for sharing your class with us. I have some issues with your design though: 1. In the constructor I would not call Impersonate(...) straight away. There are two reasons for this: a.) Code in a constructor that will likely cause an exception is a real pain in the a**e. b.) Let the user of your library decide when Impersonation starts and ends. Store user account and domain in instance variables. Password should not be stored in the class (as you have already done) but could be retrieved via GetPassword() (see 2.). I would make an additional overload Impersonate() a public function and add another function like Revert() that will call context.Undo() and set context = null. bool IsImpersonating() would be nifty (context != null) too. 2. Move the function GetPassword to a separate class that implements an interface say IStringPasswordProvider. Have a property that allows the user of your library to inject an instance of his or her own implementation of IPasswordProvider. public interface IStringPasswordProvider { String GetPassword(String account); String GetPassword(String account, String domain); } public class DefaultPasswordProvider : IStringPasswordProvider { string GetPassword(string account) { string[] accountSplit = SplitAccount(account); return GetPassword(accountSplit[0], accountSplit[1]); } string GetPassword(string domain, string user) { string pass = string.Empty; pass = "todo"; //todo:add code here to return the password for the given user from the secure store. return pass; } } A password provider might read passwords from a DB or may be the app.config (web.config) file. Please let me know what you think of these changes. Best Regards Manfred

Hey Luc, thanks for your response; adding the encoding fixed the issue. I am a little worried about the possibility of other codepages, since the idea is that this system can take data from any source. Guess I'll have to configure it to allow different data sources (i.e. file locations) to have a custom codepage specified. For people following this thread, you may be interested in the code below, which gives the systems' default codepage (as Luc mentioned, for me it's 1252). Console.WriteLine(Encoding.Default.CodePage.ToString()); I've now modified one line of my code to read as follows, which seems to have fixed the issue: using (TextReader reader = new StreamReader(filename,Encoding.Default,true)) It seems a bit strange that the system's not using the default by default, but hey, all's good. I've also tried chucking UTF-8 and UTF-16 formatted text documents through and these were also encoded correctly. Thanks again, JB

CLIENT <system.serviceModel> <bindings> <netNamedPipeBinding> <binding name="localBinding" closeTimeout="00:01:00" openTimeout="00:01:00" receiveTimeout="00:10:00" sendTimeout="00:01:00" transactionFlow="false" hostNameComparisonMode="StrongWildcard" maxBufferPoolSize="524288" maxReceivedMessageSize="65536"> <readerQuotas maxDepth="32" maxStringContentLength="8192" maxArrayLength="16384" maxBytesPerRead="4096" maxNameTableCharCount="16384" /> </binding> </netNamedPipeBinding> </bindings> <client> <endpoint address="net.pipe://localhost/TranscodeWcfService.svc" binding="netNamedPipeBinding" contract="ITranscodeWcfService" name="endpointITranscodeWcfService" bindingConfiguration="localBinding"/> <endpoint address="net.pipe://localhost/TransformWcfService.svc" binding="netNamedPipeBinding" contract="ITransformWcfService" name="endpointITransformWcfService" bindingConfiguration="localBinding"/> </client> </system.serviceModel> SERVER <system.serviceModel> <services> <service name="CompanyName.ServiceLayer.Transform.TransformWcfService" behaviorConfiguration="CompanyName.ServiceLayer.Transform.TransformWcfServiceBehavior"> <endpoint address="" binding="netNamedPipeBinding" contract="CompanyName.ServiceLayer.Transform.ITransformWcfService" /> <host><baseAddresses><add baseAddress="net.pipe://localhost/TransformWcfService.svc"/></baseAddresses></host> </service> </services> <behaviors> <serviceBehaviors> <behavior name="CompanyName.ServiceLayer.Transform.TransformWcfServiceBehavior"> <serviceMetadata httpGetEnabled="true"/> <serviceDebug includeExceptionDetailInFaults="true"/> </behavior> </serviceBehaviors> </behaviors> </system.serviceModel>

Inverso1 wrote: for getting the input parameters for a stored proc That would depend on the database; not all of them support them.

Thanks for the info about the BackgroundWorker; I hadn't used that before. I had a play, and that works well for running threads and catching exceptions, but as I needed to trigger it from a timer, the issue of bubbling exceptions up past the timer remained. When I tried using the worker's completed event, to retrigger it, this caused a new asynchronous thread to be created, which worried me about the potential for memory leaks and stack overflows; these may not be an issue, but my knowledge isn't good enough to feel comfortable with this yet. However, I realised that I'd missed an obvious solution. The actual issue I was trying to solve is this: I have a windows service, which starts a number of threads to poll different resources at various intervals (e.g. one thread monitors a folder on the file system every 30 seconds, another queries a database every hour). These threads are to run in parallel, and also run the handling code for where results are found (ceasing to poll whilst the handler code runs to avoid overloading it). Should an exception occurs in one of these threads, I wanted to ensure that it was reported to the eventlog, so put a try catch around the service call, hoping for it to catch all exceptions. My solution was to simply change from using a top level exception handler to using a singleton exception handler available to all threads. Each thread then had the standard exception bucket around all of its contents, allowing exceptions to be reported correctly. As I say, this is a solution to a different problem to the one I initially posted, but hopefully this'll help others with similar issues. Thanks again to Luc for all your assistance. JB

you're welcome. :) Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] I only read formatted code with indentation, so please use PRE tags for code snippets. I'm not participating in frackin' Q&A, so if you want my opinion, ask away in a real forum (or on my profile page).

The type of object has nothing to do with your problem. Basically, you have something trying to serve up default.asp and this extension has not been allowed by your web server. I suspect that you should actually have default.aspx in there. "WPF has many lovers. It's a veritable porn star!" - Josh Smith As Braveheart once said, "You can take our freedom but you'll never take our Hobnobs!" - Martin Hughes. My blog | My articles | MoXAML PowerToys | Onyx